ipmi: si: Use platform_get_irq() to retrieve interrupt
PATCH 1/1 ipmi: si: Use platform_get_irq() to retrieve interrupt
Use platform_get_irq() to retrieve the interrupt resource instead of directly parsing and mapping the OF node via irq_of_parse_and_map(). This is the standard pattern for platform devices. irq_of_parse_and_map() requires ire_dispose_mapping(), which is missing.
--- drivers/char/ipmi/ipmi_si_platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/ipmi/ipmi_si_platform.c +1 -1
@@ -276,7 +276,7 @@ static int of_ipmi_probe(struct platform_device *pdev) io.regspacing = regspacing ?be32_to_cpup (regspacing) :DEFAULT_REGSPACING ; io.regshift = regshift ?be32_to_cpup (regshift) :0 ; - io.irq =irq_of_parse_and_map (pdev->dev.of_node,0 ); + io.irq =platform_get_irq (pdev,0 ); io.dev = &pdev->dev; dev_dbg(&pdev->dev, "addr 0x%lx regsize %d spacing %d irq %d\n",
Signature · 1 line
2.54.0
Corey Minyard
maintainerQuoted 16 lines · Rosen Penev
Use
platform_get_irq()to retrieve the interrupt resource instead of directly parsing and mapping the OF node viairq_of_parse_and_map(). This is the standard pattern for platform devices.irq_of_parse_and_map()requiresire_dispose_mapping(), which is missing.Assisted-by Antigravity:Gemini-3.5-FlashSigned-off-by Rosen Penev <[email protected]>--- drivers/char/ipmi/ipmi_si_platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/char/ipmi/ipmi_si_platform.c +0
-0
drivers/char/ipmi/ipmi_si_platform.c static int of_ipmi_probe(struct platform_device *pdev) · line 279
Quoted 5 lines
drivers/char/ipmi/ipmi_si_platform.c +1
-1@@ -276,7 +276,7 @@ static int of_ipmi_probe(struct platform_device *pdev) io.regspacing = regspacing ?be32_to_cpup (regspacing) :DEFAULT_REGSPACING ; io.regshift = regshift ?be32_to_cpup (regshift) :0 ; - io.irq =irq_of_parse_and_map (pdev->dev.of_node,0 ); + io.irq =platform_get_irq (pdev,0 );
This should be something like:
io.irq = platform_get_irq_optional(pdev, 0); if (io.irq > 0) io.irq_setup = ipmi_std_irq_setup; else io.irq = 0;
right?
-corey
Quoted 6 lines
drivers/char/ipmi/ipmi_si_platform.c +0
-0io.dev = &pdev->dev; dev_dbg(&pdev->dev, "addr 0x%lx regsize %d spacing %d irq %d\n",Signature · 1 line
2.54.0
Corey Minyard
maintainerQuoted 25 lines · Corey Minyard
Quoted 16 lines · Rosen Penev
Use
platform_get_irq()to retrieve the interrupt resource instead of directly parsing and mapping the OF node viairq_of_parse_and_map(). This is the standard pattern for platform devices.irq_of_parse_and_map()requiresire_dispose_mapping(), which is missing.Assisted-by Antigravity:Gemini-3.5-FlashSigned-off-by Rosen Penev <[email protected]>--- drivers/char/ipmi/ipmi_si_platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/char/ipmi/ipmi_si_platform.c +0
-0drivers/char/ipmi/ipmi_si_platform.c static int of_ipmi_probe(struct platform_device *pdev) · line 279
Quoted 5 lines
drivers/char/ipmi/ipmi_si_platform.c +1
-1@@ -276,7 +276,7 @@ static int of_ipmi_probe(struct platform_device *pdev) io.regspacing = regspacing ?be32_to_cpup (regspacing) :DEFAULT_REGSPACING ; io.regshift = regshift ?be32_to_cpup (regshift) :0 ; - io.irq =irq_of_parse_and_map (pdev->dev.of_node,0 ); + io.irq =platform_get_irq (pdev,0 );This should be something like:
Quoted 7 lines
io.irq = platform_get_irq_optional(pdev, 0); if (io.irq > 0) io.irq_setup = ipmi_std_irq_setup; else io.irq = 0;right?
Oops, cut and paste error, try:
io.irq = platform_get_irq_optional(pdev, 0); if (io.irq < 0)
io.irq = 0;
This just disables the interrupt if it can't get it.
Quoted 9 lines
-corey
Quoted 6 lines
drivers/char/ipmi/ipmi_si_platform.c +0
-0io.dev = &pdev->dev; dev_dbg(&pdev->dev, "addr 0x%lx regsize %d spacing %d irq %d\n",Signature · 1 line
2.54.0
Quoted 33 lines · Corey Minyard
Quoted 31 lines · Corey Minyard
Quoted 16 lines · Rosen Penev
Use
platform_get_irq()to retrieve the interrupt resource instead of directly parsing and mapping the OF node viairq_of_parse_and_map(). This is the standard pattern for platform devices.irq_of_parse_and_map()requiresire_dispose_mapping(), which is missing.Assisted-by Antigravity:Gemini-3.5-FlashSigned-off-by Rosen Penev <[email protected]>--- drivers/char/ipmi/ipmi_si_platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/char/ipmi/ipmi_si_platform.c +0
-0drivers/char/ipmi/ipmi_si_platform.c static int of_ipmi_probe(struct platform_device *pdev) · line 279
Quoted 5 lines
drivers/char/ipmi/ipmi_si_platform.c +1
-1@@ -276,7 +276,7 @@ static int of_ipmi_probe(struct platform_device *pdev) io.regspacing = regspacing ?be32_to_cpup (regspacing) :DEFAULT_REGSPACING ; io.regshift = regshift ?be32_to_cpup (regshift) :0 ; - io.irq =irq_of_parse_and_map (pdev->dev.of_node,0 ); + io.irq =platform_get_irq (pdev,0 );This should be something like:
io.irq = platform_get_irq_optional(pdev, 0); if (io.irq > 0) io.irq_setup = ipmi_std_irq_setup; else io.irq = 0;
Quoted 7 lines
Quoted 1 line
right?
Oops, cut and paste error, try:
io.irq = platform_get_irq_optional(pdev, 0); if (io.irq < 0) io.irq = 0;
I don't think that if is appropriate.
Quoted 12 lines
This just disables the interrupt if it can't get it.
Quoted 9 lines
-corey
Quoted 6 lines
drivers/char/ipmi/ipmi_si_platform.c +0
-1io.dev = &pdev->dev; dev_dbg(&pdev->dev, "addr 0x%lx regsize %d spacing %d irq %d\n", --2.54.0
Corey Minyard
maintainerQuoted 34 lines · Rosen Penev
Quoted 33 lines · Corey Minyard
Quoted 31 lines · Corey Minyard
Quoted 16 lines · Rosen Penev
Use
platform_get_irq()to retrieve the interrupt resource instead of directly parsing and mapping the OF node viairq_of_parse_and_map(). This is the standard pattern for platform devices.irq_of_parse_and_map()requiresire_dispose_mapping(), which is missing.Assisted-by Antigravity:Gemini-3.5-FlashSigned-off-by Rosen Penev <[email protected]>--- drivers/char/ipmi/ipmi_si_platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/char/ipmi/ipmi_si_platform.c +0
-0drivers/char/ipmi/ipmi_si_platform.c static int of_ipmi_probe(struct platform_device *pdev) · line 279
Quoted 5 lines
drivers/char/ipmi/ipmi_si_platform.c +1
-1@@ -276,7 +276,7 @@ static int of_ipmi_probe(struct platform_device *pdev) io.regspacing = regspacing ?be32_to_cpup (regspacing) :DEFAULT_REGSPACING ; io.regshift = regshift ?be32_to_cpup (regshift) :0 ; - io.irq =irq_of_parse_and_map (pdev->dev.of_node,0 ); + io.irq =platform_get_irq (pdev,0 );This should be something like:
io.irq = platform_get_irq_optional(pdev, 0); if (io.irq > 0) io.irq_setup = ipmi_std_irq_setup; else io.irq = 0;
Quoted 8 lines
Quoted 7 lines
Quoted 1 line
right?
Oops, cut and paste error, try:
io.irq = platform_get_irq_optional(pdev, 0); if (io.irq < 0) io.irq = 0;I don't think that if is appropriate.
Can platform_get_irq[_optional]() return < 0? The driver still has to work even if there is no interrupt specified.
-corey
Quoted 12 lines
Quoted 12 lines
This just disables the interrupt if it can't get it.
Quoted 9 lines
-corey
Quoted 6 lines
drivers/char/ipmi/ipmi_si_platform.c +0
-1io.dev = &pdev->dev; dev_dbg(&pdev->dev, "addr 0x%lx regsize %d spacing %d irq %d\n", --2.54.0
Quoted 40 lines · Corey Minyard
Quoted 38 lines · Rosen Penev
Quoted 37 lines · Corey Minyard
Quoted 25 lines · Corey Minyard
Quoted 16 lines · Rosen Penev
Use
platform_get_irq()to retrieve the interrupt resource instead of directly parsing and mapping the OF node viairq_of_parse_and_map(). This is the standard pattern for platform devices.irq_of_parse_and_map()requiresire_dispose_mapping(), which is missing.Assisted-by Antigravity:Gemini-3.5-FlashSigned-off-by Rosen Penev <[email protected]>--- drivers/char/ipmi/ipmi_si_platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/char/ipmi/ipmi_si_platform.c +0
-0drivers/char/ipmi/ipmi_si_platform.c static int of_ipmi_probe(struct platform_device *pdev) · line 279
Quoted 5 lines
drivers/char/ipmi/ipmi_si_platform.c +1
-1@@ -276,7 +276,7 @@ static int of_ipmi_probe(struct platform_device *pdev) io.regspacing = regspacing ?be32_to_cpup (regspacing) :DEFAULT_REGSPACING ; io.regshift = regshift ?be32_to_cpup (regshift) :0 ; - io.irq =irq_of_parse_and_map (pdev->dev.of_node,0 ); + io.irq =platform_get_irq (pdev,0 );This should be something like:
Quoted 7 lines
io.irq = platform_get_irq_optional(pdev, 0); if (io.irq > 0) io.irq_setup = ipmi_std_irq_setup; else io.irq = 0;right?
Oops, cut and paste error, try:
Quoted 7 lines
Quoted 4 lines
Quoted 3 lines
io.irq = platform_get_irq_optional(pdev, 0); if (io.irq < 0) io.irq = 0;I don't think that if is appropriate.
Can platform_get_irq[_optional]() return < 0? The driver still has to work even if there is no interrupt specified.
It can return -EPROBE_DEFER.
No idea how likely in this driver.
Quoted 15 lines
-corey
Quoted 12 lines
Quoted 12 lines
This just disables the interrupt if it can't get it.
Quoted 9 lines
-corey
Quoted 6 lines
drivers/char/ipmi/ipmi_si_platform.c +0
-1io.dev = &pdev->dev; dev_dbg(&pdev->dev, "addr 0x%lx regsize %d spacing %d irq %d\n", --2.54.0
Corey Minyard
maintainerQuoted 44 lines · Rosen Penev
Quoted 43 lines · Corey Minyard
Quoted 41 lines · Rosen Penev
Quoted 40 lines · Corey Minyard
Quoted 25 lines · Corey Minyard
Quoted 16 lines · Rosen Penev
Use
platform_get_irq()to retrieve the interrupt resource instead of directly parsing and mapping the OF node viairq_of_parse_and_map(). This is the standard pattern for platform devices.irq_of_parse_and_map()requiresire_dispose_mapping(), which is missing.Assisted-by Antigravity:Gemini-3.5-FlashSigned-off-by Rosen Penev <[email protected]>--- drivers/char/ipmi/ipmi_si_platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/char/ipmi/ipmi_si_platform.c +0
-0drivers/char/ipmi/ipmi_si_platform.c static int of_ipmi_probe(struct platform_device *pdev) · line 279
Quoted 5 lines
drivers/char/ipmi/ipmi_si_platform.c +1
-1@@ -276,7 +276,7 @@ static int of_ipmi_probe(struct platform_device *pdev) io.regspacing = regspacing ?be32_to_cpup (regspacing) :DEFAULT_REGSPACING ; io.regshift = regshift ?be32_to_cpup (regshift) :0 ; - io.irq =irq_of_parse_and_map (pdev->dev.of_node,0 ); + io.irq =platform_get_irq (pdev,0 );This should be something like:
Quoted 7 lines
io.irq = platform_get_irq_optional(pdev, 0); if (io.irq > 0) io.irq_setup = ipmi_std_irq_setup; else io.irq = 0;right?
Oops, cut and paste error, try:
io.irq = platform_get_irq_optional(pdev, 0); if (io.irq < 0) io.irq = 0;
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
I don't think that if is appropriate.
Can platform_get_irq[_optional]() return < 0? The driver still has to work even if there is no interrupt specified.
It can return -EPROBE_DEFER.
No idea how likely in this driver.
Well, I have to handle a negative return value here, the comments above platform_get_irq_optional() say so. The value is optional. So it has to be the above.
I'll modify the patch to be what I posted above.
Quoted 15 lines
Quoted 15 lines
-corey
Quoted 12 lines
Quoted 12 lines
This just disables the interrupt if it can't get it.
Quoted 9 lines
-corey
Quoted 6 lines
drivers/char/ipmi/ipmi_si_platform.c +0
-1io.dev = &pdev->dev; dev_dbg(&pdev->dev, "addr 0x%lx regsize %d spacing %d irq %d\n", --2.54.0