Skip to contentSkip to conversation

arm64: dts/bindings: Add support for BeagleBadge

PATCH Applied Judith Mendez 3 participants 7 messages Jun 3 – Jul 21

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v6 cover arm64: dts/bindings: Add support for BeagleBadge

Hi,

BeagleBoard.org BeagleBadge[1] is a compact, affordable open source hardware [2] single board computer based on the Texas Instruments AM62L3 SoC designed for IoT and embedded applications. Add base support for the same.

SD boot:

This patch series adds:
- Device tree bindings update for am62l3-badge
- Device tree source for BeagleBadge board
- Defconfig: drivers for BeagleBadge

Changelog since v5:
DTS
- Fixed aliases/chosen nodes
- Sort Makefile items alphabetically
- Use dual license: GPL-2.0-only or MIT

v5

v4

v3

V2

V1

Patch series depends on:

[1] https://www.beagleboard.org/boards/beaglebadge
[2] https://github.com/beagleboard/BeagleBadge/blob/main/design/BeagleBadge_RevA_V0.7_SCH_251107.pdf

Judith Mendez (3):
dt-bindings: arm: ti: Add am62l3-beaglebadge
arm64: dts: ti: Add k3-am62l3-beaglebadge
arm64: defconfig: Enable drivers for BeagleBadge

 .../devicetree/bindings/arm/ti/k3.yaml        |   1 +
 arch/arm64/boot/dts/ti/Makefile               |   1 +
 .../boot/dts/ti/k3-am62l3-beaglebadge.dts     | 657 ++++++++++++++++++
 arch/arm64/configs/defconfig                  |   5 +
 4 files changed, 664 insertions(+)
 create mode 100644 arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts
Signature · 1 line
2.54.0
#1 lore raw

PATCH v6 1/3 dt-bindings: arm: ti: Add am62l3-beaglebadge

This board is based on ti,am62l3.

https://www.beagleboard.org/boards/beaglebadge

---
Changes since v5:
- No change

---
 Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/ti/k3.yaml +1 -0
index 2a6a9441c23de..d9cd3fb712fdd 100644
@@ -40,6 +40,7 @@ properties:
       - description: K3 AM62L3 SoC and Boards
         items:
           - enum:
+              - beagle,am62l3-beaglebadge
               - ti,am62l3-evm
           - const: ti,am62l3
 
Signature · 1 line
2.54.0
#2 lore raw

PATCH v6 2/3 arm64: dts: ti: Add k3-am62l3-beaglebadge

In reply to Judith Mendez

BeagleBoard.org BeagleBadge is a compact, affordable open source hardware single board computer based on the Texas Instruments AM62L3 SoC designed for IoT and embedded applications with low power consumption. Expansion is provided over open standards based headers including QWIIC and GPIO interfaces.

https://www.beagleboard.org/boards/beaglebadge

---
Changes since v5:
- Fixed aliases/chosen nodes
- Sort Makefile items alphabetically
- Use dual license: GPL-2.0-only or MIT

---
 arch/arm64/boot/dts/ti/Makefile               |   1 +
 .../boot/dts/ti/k3-am62l3-beaglebadge.dts     | 657 ++++++++++++++++++
 2 files changed, 658 insertions(+)
 create mode 100644 arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts
arch/arm64/boot/dts/ti/Makefile +1 -0
index 5269c9619b65c..3f1904a5b622f 100644
@@ -40,6 +40,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-am62a7-phyboard-lyra-rdk.dtb
 dtb-$(CONFIG_ARCH_K3) += k3-am62d2-evm.dtb
 
 # Boards with AM62Lx SoCs
+dtb-$(CONFIG_ARCH_K3) += k3-am62l3-beaglebadge.dtb
 dtb-$(CONFIG_ARCH_K3) += k3-am62l3-evm.dtb
 
 # Boards with AM62Px SoC
arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts new file +657 -0

657 lines not on this page · raw message

Signature · 1 line
2.54.0
#3 lore raw

Re: [PATCH v6 2/3] arm64: dts: ti: Add k3-am62l3-beaglebadge

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [High] Driver-Binding Mismatch: The `mcp23s18` GPIO expander probe will fail due to property size…

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Driver-Binding Mismatch: The mcp23s18 GPIO expander probe will fail due to property size mismatch. --

commit dda0de04ef0f2160008191753ea45cc6c9880fa6
Author: Judith Mendez <[email protected]>

arm64: dts: ti: Add k3-am62l3-beaglebadge

This commit adds the device tree for the BeagleBoard.org BeagleBadge, based on the Texas Instruments AM62L3 SoC. It includes configurations for memory, GPIO keys, LEDs, regulators, MMC, USB, PWM, I2C, SPI, and other peripherals.

Quoted 5 lines
arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts new file +0 -0
new file mode 100644
index 0000000000000..ee2d562baf51a

[ ... ]

Quoted 5 lines

+&spi1 {

arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts new file +4 -0
+	pinctrl-names = "default";
+	pinctrl-0 = <&spi1_pins_default>;
+	status = "okay";
+

arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts line 649

Quoted 10 lines
arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts new file +10 -0
+	mcp23s18: gpio@0 {
+		compatible = "microchip,mcp23s18";
+		reg = <0>;
+		spi-max-frequency = <10000000>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		reset-gpios = <&gpio0 25 GPIO_ACTIVE_LOW>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&mcp23s18_reset_pins_default>;
+		microchip,spi-present-mask = /bits/ 8 <0x01>;

[Severity: High]
Does this 8-bit property cause the driver probe to fail?

Looking at drivers/pinctrl/pinctrl-mcp23s08_spi.c, the driver attempts to read this property using device_property_read_u32(). Because it expects at least 4 bytes of data, of_find_property_value_of_size() will evaluate the length as insufficient and return -EOVERFLOW.

This would cause the driver probe to fail, leaving the MCP23S18 GPIO expander and connected devices non-functional. Should this property be defined as a standard 32-bit value to match the driver's expectations?

Quoted 2 lines
arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts new file +2 -0
+	};
+};
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
#4 lore raw

Re: [PATCH v6 2/3] arm64: dts: ti: Add k3-am62l3-beaglebadge

Hi all,

Quoted 40 lines · On 6/3/26 2:39 PM, [email protected] wrote:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Driver-Binding Mismatch: The mcp23s18 GPIO expander probe will fail due to property size mismatch. --

commit dda0de04ef0f2160008191753ea45cc6c9880fa6
Author: Judith Mendez <[email protected]>

arm64: dts: ti: Add k3-am62l3-beaglebadge

This commit adds the device tree for the BeagleBoard.org BeagleBadge, based on the Texas Instruments AM62L3 SoC. It includes configurations for memory, GPIO keys, LEDs, regulators, MMC, USB, PWM, I2C, SPI, and other peripherals.

Quoted 5 lines
arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts new file +0 -0
new file mode 100644
index 0000000000000..ee2d562baf51a

[ ... ]

Quoted 5 lines

+&spi1 {

arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts new file +4 -0
+	pinctrl-names = "default";
+	pinctrl-0 = <&spi1_pins_default>;
+	status = "okay";
+

arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts line 649

Quoted 10 lines
arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts new file +10 -0
+	mcp23s18: gpio@0 {
+		compatible = "microchip,mcp23s18";
+		reg = <0>;
+		spi-max-frequency = <10000000>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		reset-gpios = <&gpio0 25 GPIO_ACTIVE_LOW>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&mcp23s18_reset_pins_default>;
+		microchip,spi-present-mask = /bits/ 8 <0x01>;

[Severity: High]
Does this 8-bit property cause the driver probe to fail?

Quoted 8 lines

Looking at drivers/pinctrl/pinctrl-mcp23s08_spi.c, the driver attempts to read this property using device_property_read_u32(). Because it expects at least 4 bytes of data, of_find_property_value_of_size() will evaluate the length as insufficient and return -EOVERFLOW.

This would cause the driver probe to fail, leaving the MCP23S18 GPIO expander and connected devices non-functional. Should this property be defined as a standard 32-bit value to match the driver's expectations?

This issue is already addressed, fix has already been merged. Link is here:https://lore.kernel.org/all/[email protected]/

~ Judith

#5 lore raw

PATCH v6 3/3 arm64: defconfig: Enable drivers for BeagleBadge

In reply to Judith Mendez

Enable drivers used on BeagleBadge[1]:
- LED PWM Multicolor driver as a module
- MCP SPI IO Expander driver as a module
- Seven Segment display GPIO driver as module
- Temperature Sensor driver as a module

[1] https://www.beagleboard.org/boards/beaglebadge

---
Changes since v5:
- No change

---
 arch/arm64/configs/defconfig | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm64/configs/defconfig +5 -0
index d905a0777f939..5cfb7f6f2ae78 100644
@@ -634,6 +634,7 @@ CONFIG_PINCTRL_BRCMSTB=y
 CONFIG_PINCTRL_BCM2712=y
 CONFIG_PINCTRL_DA9062=m
 CONFIG_PINCTRL_MAX77620=y
+CONFIG_PINCTRL_MCP23S08=m
 CONFIG_PINCTRL_RK805=m
 CONFIG_PINCTRL_SINGLE=y
 CONFIG_PINCTRL_SX150X=m
@@ -766,6 +767,7 @@ CONFIG_SENSORS_LM90=m
 CONFIG_SENSORS_PWM_FAN=m
 CONFIG_SENSORS_RASPBERRYPI_HWMON=m
 CONFIG_SENSORS_SL28CPLD=m
+CONFIG_SENSORS_SHT4x=m
 CONFIG_SENSORS_AMC6821=m
 CONFIG_SENSORS_INA2XX=m
 CONFIG_SENSORS_INA3221=m
@@ -955,6 +957,8 @@ CONFIG_VIDEO_IMX412=m
 CONFIG_VIDEO_OV5640=m
 CONFIG_VIDEO_OV5645=m
 CONFIG_VIDEO_S5KJN1=m
+CONFIG_AUXDISPLAY=y
+CONFIG_SEG_LED_GPIO=m
 CONFIG_DRM=m
 CONFIG_DRM_I2C_NXP_TDA998X=m
 CONFIG_DRM_HDLCD=m
@@ -1332,6 +1336,7 @@ CONFIG_LEDS_GPIO=y
 CONFIG_LEDS_PWM=y
 CONFIG_LEDS_SYSCON=y
 CONFIG_LEDS_QCOM_FLASH=m
+CONFIG_LEDS_PWM_MULTICOLOR=m
 CONFIG_LEDS_QCOM_LPG=m
 CONFIG_LEDS_TRIGGER_TIMER=y
 CONFIG_LEDS_TRIGGER_DISK=y
Signature · 1 line
2.54.0
maintainer Applied
#6 lore raw

Re: (subset) [PATCH v6 0/3] arm64: dts/bindings: Add support for BeagleBadge

In reply to Judith Mendez

Hi Judith Mendez,

Quoted 10 lines · Judith Mendez

arm64: dts/bindings: Add support for BeagleBadge

Hi,

BeagleBoard.org BeagleBadge[1] is a compact, affordable open source hardware [2] single board computer based on the Texas Instruments AM62L3 SoC designed for IoT and embedded applications. Add base support for the same.

[...]

I have applied the following to branch ti-k3-dts-next on [1]. Thank you!

[1/3] dt-bindings: arm: ti: Add am62l3-beaglebadge

      commit: e2393ed6275732036d8f7c2b05de1319c5c691d6
[2/3] arm64: dts: ti: Add k3-am62l3-beaglebadge
      commit: 0c78b72362f4bd90f8a46ea7be385fe05137e06d

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Vignesh