staging: rtl8723bs: remove comparisons to boolean literals
PATCH v2 1/1 staging: rtl8723bs: remove comparisons to boolean literals
Remove comparisons to true and false as they are error prone. Use the idiomatic C forms instead
v2: Fix inverted logic for ht_option checks
--- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-)
drivers/staging/rtl8723bs/core/rtw_wlan_util.c +8 -9
@@ -236,7 +236,7 @@ void Restore_DM_Func_Flag(struct adapter *padapter)void Switch_DM_Func (struct adapter *padapter,u32 mode,u8 enable) { -if (enable == true) +if (enable)rtw_hal_set_hwreg (padapter,HW_VAR_DM_FUNC_SET , (u8 *)(&mode));else rtw_hal_set_hwreg (padapter,HW_VAR_DM_FUNC_CLR , (u8 *)(&mode));
@@ -340,7 +340,6 @@ void set_channel_bwmode(struct adapter *padapter, unsigned char channel, unsigne center_ch =rtw_get_center_ch (channel, bwmode, channel_offset); -/* set Channel */ if (mutex_lock_interruptible (&(adapter_to_dvobj (padapter)->setch_mutex)))return ;
@@ -847,7 +846,7 @@ static void bwmode_update_check(struct adapter *padapter, struct ndis_80211_var_if (!pIE)return ; -if (phtpriv->ht_option == false) +if (phtpriv->ht_option)return ;if (pIE->length >sizeof (struct HT_info_element ))
@@ -892,7 +891,7 @@ static void bwmode_update_check(struct adapter *padapter, struct ndis_80211_var_ pmlmeinfo->bwmode_updated = false; } -if (true == pmlmeinfo->bwmode_updated) { +if (pmlmeinfo->bwmode_updated) {struct sta_info *psta;struct wlan_bssid_ex *cur_network = &(pmlmeinfo->network);struct sta_priv *pstapriv = &padapter->stapriv;
@@ -931,7 +930,7 @@ void HT_caps_handler(struct adapter *padapter, struct ndis_80211_var_ie *pIE)if (!pIE)return ; -if (phtpriv->ht_option == false) +if (phtpriv->ht_option)return ; pmlmeinfo->HT_caps_enable =1 ;
@@ -994,7 +993,7 @@ void HT_info_handler(struct adapter *padapter, struct ndis_80211_var_ie *pIE)if (!pIE)return ; -if (phtpriv->ht_option == false) +if (phtpriv->ht_option)return ;if (pIE->length >sizeof (struct HT_info_element ))
@@ -1689,7 +1688,7 @@ void adaptive_early_32k(struct mlme_ext_priv *pmlmeext, u8 *pframe, uint len) pmlmeext->bcn_delay_cnt[delay_ms]++;/* pmlmeext->bcn_delay_ratio[delay_ms] = (pmlmeext->bcn_delay_cnt[delay_ms] * 100) /pmlmeext->bcn_cnt; */ /* dump for adaptive_early_32k */ -if (pmlmeext->bcn_cnt >100 && (pmlmeext->adaptive_tsf_done == true)) { +if (pmlmeext->bcn_cnt >100 && (pmlmeext->adaptive_tsf_done)) {u8 ratio_20_delay, ratio_80_delay;u8 DrvBcnEarly, DrvBcnTimeOut;
@@ -1737,7 +1736,7 @@ void rtw_alloc_macid(struct adapter *padapter, struct sta_info *psta)spin_lock_bh (&pdvobj->lock);for (i =0 ; i <NUM_STA ; i++) { -if (pdvobj->macid[i] == false) { +if (pdvobj->macid[i]) { pdvobj->macid[i] = true;break ; }
@@ -1762,7 +1761,7 @@ void rtw_release_macid(struct adapter *padapter, struct sta_info *psta)spin_lock_bh (&pdvobj->lock);if (psta->mac_id <NUM_STA && psta->mac_id !=1 ) { -if (pdvobj->macid[psta->mac_id] == true) { +if (pdvobj->macid[psta->mac_id]) { pdvobj->macid[psta->mac_id] = false; psta->mac_id =NUM_STA ; }
Signature · 1 line
2.54.0
drivers/staging/rtl8723bs/core/rtw_wlan_util.c static void bwmode_update_check(struct adapter *padapter, struct ndis_80211_var_ · line 850
Quoted 3 lines · William Elder
drivers/staging/rtl8723bs/core/rtw_wlan_util.c +1
-1-if (phtpriv->ht_option == false) +if (phtpriv->ht_option)return ;
Still same buggy code, V2 didn't change anything.
Please work on it properly and wait a day to send a new revision, not right away.
Also, send your replies using Reply All.
Regards,
Ahmet Sezgin Duran
Quoted 2 lines
Still same buggy code, V2 didn't change anything.
Please work on it properly and wait a day to send a new revision, not
right away.
Quoted 1 line
Also, send your replies using
Reply All.
Apologies, I fixed the code, I'll wait until tomorrow to send the new revision.
Best,
William Elder
Quoted 16 lines · Ahmet Sezgin Duran
drivers/staging/rtl8723bs/core/rtw_wlan_util.c static void bwmode_update_check(struct adapter *padapter, struct ndis_80211_var_ · line 850
Quoted 3 lines · William Elder
drivers/staging/rtl8723bs/core/rtw_wlan_util.c +1
-1-if (phtpriv->ht_option == false) +if (phtpriv->ht_option)return ;Still same buggy code, V2 didn't change anything.
Please work on it properly and wait a day to send a new revision, not right away.
Also, send your replies using
Reply All.Regards,
Ahmet Sezgin Duran
Quoted 3 lines · William Elder
Remove comparisons to true and false as they are error prone. Use the idiomatic C forms instead
v2: Fix inverted logic forht_optionchecks
Nope. Still buggy.
Please wait a day between resends.
There are other issues with this patch. It needs to be split up. v2 rules etc.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
regards,
dan carpenter