Skip to contentSkip to conversation

media: qcom: camss: Rename unused macro parameter

PATCH Superseded Hungyu Lin 3 participants 3 messages Jun 3 – Jun 4

Subsystems (4)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Hungyu Lin

author
#0 lore raw

PATCH 1/1 media: qcom: camss: Rename unused macro parameter

The ISPIF_VFE_m_RDI_INTF_n_PACK_CFG_0_CID_c_PLAIN() macro declares a parameter named 'c' but uses 'cid' in the macro body instead.

Rename the parameter to match the identifier used in the macro body and silence the checkpatch warning:

WARNING: Argument 'c' is not used in function-like macro

No functional change intended.

---
 drivers/media/platform/qcom/camss/camss-ispif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/qcom/camss/camss-ispif.c +1 -1
index aaf3caa42d33..8b0753e606c1 100644
@@ -83,7 +83,7 @@
 					(0x270 + 0x200 * (m) + 0x4 * (n))
 #define ISPIF_VFE_m_RDI_INTF_n_PACK_CFG_1(m, n)	\
 					(0x27c + 0x200 * (m) + 0x4 * (n))
-#define ISPIF_VFE_m_RDI_INTF_n_PACK_CFG_0_CID_c_PLAIN(c)	\
+#define ISPIF_VFE_m_RDI_INTF_n_PACK_CFG_0_CID_c_PLAIN(cid)	\
 					(1 << ((cid % 8) * 4))
 #define ISPIF_VFE_m_PIX_INTF_n_STATUS(m, n)	\
 					(0x2c0 + 0x200 * (m) + 0x4 * (n))
Signature · 1 line
2.34.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 21 lines · Hungyu Lin

The ISPIF_VFE_m_RDI_INTF_n_PACK_CFG_0_CID_c_PLAIN() macro declares a parameter named 'c' but uses 'cid' in the macro body instead.

Rename the parameter to match the identifier used in the macro body and silence the checkpatch warning:

WARNING: Argument 'c' is not used in function-like macro

No functional change intended.

---
  drivers/media/platform/qcom/camss/camss-ispif.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/qcom/camss/camss-ispif.c +0 -0
index aaf3caa42d33..8b0753e606c1 100644

drivers/media/platform/qcom/camss/camss-ispif.c line 89

Quoted 8 lines
drivers/media/platform/qcom/camss/camss-ispif.c +1 -1
@@ -83,7 +83,7 @@
  					(0x270 + 0x200 * (m) + 0x4 * (n))
  #define ISPIF_VFE_m_RDI_INTF_n_PACK_CFG_1(m, n)	\
  					(0x27c + 0x200 * (m) + 0x4 * (n))
-#define ISPIF_VFE_m_RDI_INTF_n_PACK_CFG_0_CID_c_PLAIN(c)	\
+#define ISPIF_VFE_m_RDI_INTF_n_PACK_CFG_0_CID_c_PLAIN(cid)	\
  					(1 << ((cid % 8) * 4))
  #define ISPIF_VFE_m_PIX_INTF_n_STATUS(m, n)	\
  					(0x2c0 + 0x200 * (m) + 0x4 * (n))

Nasty

---
bod

reviewer Reviewed-by on v1 1/1
#2 lore raw
In reply to Hungyu Lin
Quoted 4 lines · Hungyu Lin

The ISPIF_VFE_m_RDI_INTF_n_PACK_CFG_0_CID_c_PLAIN() macro declares a parameter named 'c' but uses 'cid' in the macro body instead.

Quoted 8 lines

Rename the parameter to match the identifier used in the macro body and silence the checkpatch warning:

WARNING: Argument 'c' is not used in function-like macro

No functional change intended.

Signature · 2 lines
Best wishes,
Vladimir