Skip to contentSkip to conversation

can: virtio: Fix comment in UAPI header

PATCH New Nathan Chancellor 1 participant 1 message Jun 4

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 can: virtio: Fix comment in UAPI header

When compile testing the UAPI headers with clang, there is an warning turned error for using a C++ style ('//') comment, which is explicitly forbidden for UAPI headers.

In file included from <built-in>:1:
./usr/include/linux/virtio_can.h:29:35: error: // comments are not allowed in this language [-Werror,-Wcomment]
29 | #define VIRTIO_CAN_MAX_DLEN 64 // this is like CANFD_MAX_DLEN
| ^
1 error generated.

Switch to a standard C style comment.

Fixes 2b6b4bb7d96f ("can: virtio: Add virtio CAN driver")
---
 include/uapi/linux/virtio_can.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/linux/virtio_can.h +1 -1
index 08d7e3e78776..e054d5099241 100644
@@ -26,7 +26,7 @@
 #define VIRTIO_CAN_FLAGS_FD             0x4000
 #define VIRTIO_CAN_FLAGS_RTR            0x2000
 
-#define VIRTIO_CAN_MAX_DLEN    64 // this is like CANFD_MAX_DLEN
+#define VIRTIO_CAN_MAX_DLEN    64 /* this is like CANFD_MAX_DLEN */
 
 struct virtio_can_config {
 #define VIRTIO_CAN_S_CTRL_BUSOFF (1u << 0) /* Controller BusOff */

---
base-commit: 7a85231f762aa97b945878abb9a26683486836c6
change-id: 20260604-virtio_can-fix-uapi-comment-bcafa08b4b8a

Best regards,

Signature · 2 lines
Cheers,
Nathan