Skip to contentSkip to conversation

ALSA: hda/realtek: Enable micmute LED on HP EliteBook 6 G1a

PATCH Superseded Denis Batishchev 3 participants 6 messages Jun 4 – Jun 12 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: hda/realtek: Enable micmute LED on HP EliteBook 6 G1a

The HP EliteBook 6 G1a (SSID 103c:8e0d) uses a Realtek ALC236 codec. Without a quirk no fixup is selected and the mic-mute LED stays off. It needs the same ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk as the already-supported 14" variant (SSID 103c:8dfb), so add it.

Note: I don't know how to fix sound-mute LED though.

---
 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)
sound/hda/codecs/realtek/alc269.c +1 -0
index 78a865709..8eebf9159 100644
@@ -7274,6 +7274,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8df1, "HP EliteBook 630 G12", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8df7, "HP Z66 G6", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8dfb, "HP EliteBook 6 G1a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+	SND_PCI_QUIRK(0x103c, 0x8e0d, "HP EliteBook 6 G1a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
 	SND_PCI_QUIRK(0x103c, 0x8dfc, "HP EliteBook 645 G12", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8dfd, "HP EliteBook 6 G1a 16", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
 	SND_PCI_QUIRK(0x103c, 0x8dfe, "HP EliteBook 665 G12", ALC236_FIXUP_HP_GPIO_LED),
Signature · 1 line
2.53.0
#1 lore raw
Quoted 7 lines · Denis Batishchev

The HP EliteBook 6 G1a (SSID 103c:8e0d) uses a Realtek ALC236 codec. Without a quirk no fixup is selected and the mic-mute LED stays off. It needs the same ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk as the already-supported 14" variant (SSID 103c:8dfb), so add it.

Note: I don't know how to fix sound-mute LED though.

What does this mean? Is this patch confirmed to work or not?

Quoted 11 lines
---
 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)
sound/hda/codecs/realtek/alc269.c +0 -0
index 78a865709..8eebf9159 100644

sound/hda/codecs/realtek/alc269.c static const struct hda_quirk alc269_fixup_tbl[] = { · line 7280

Quoted 7 lines
sound/hda/codecs/realtek/alc269.c +1 -0
@@ -7274,6 +7274,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8df1, "HP EliteBook 630 G12", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8df7, "HP Z66 G6", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8dfb, "HP EliteBook 6 G1a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+	SND_PCI_QUIRK(0x103c, 0x8e0d, "HP EliteBook 6 G1a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
 	SND_PCI_QUIRK(0x103c, 0x8dfc, "HP EliteBook 645 G12", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8dfd, "HP EliteBook 6 G1a 16", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
 	SND_PCI_QUIRK(0x103c, 0x8dfe, "HP EliteBook 665 G12", ALC236_FIXUP_HP_GPIO_LED),

The table is sorted in PCI SSID order. Please try to put the entry at the right position.

thanks,

Takashi

A message that is not in the archive (sent off-list or not yet received): CA+W-NrXBVkm6bvTT8+Ri=1y11A0zBK7fFVmb5m_nKHjTu9O51g@mail.gmail.com

#3 lore raw
Quoted 3 lines · Denis Batishchev

This patch fixes the mic-mute led at HP Elitebook 6 g1a.

Ah, so you mean there is another LED for the audio-mute and it's not covered by this patch? Please make the description a bit more clearer.

thanks,

Takashi

Quoted 51 lines · On Thu, Jun 4, 2026, 17:23 Takashi Iwai <[email protected]> wrote:
    On Thu, 04 Jun 2026 15:15:18 +0200,
    Denis Batishchev wrote:
    >
    > The HP EliteBook 6 G1a (SSID 103c:8e0d) uses a Realtek ALC236 codec.
    > Without a quirk no fixup is selected and the mic-mute LED stays off.
    > It needs the same ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk as the
    > already-supported 14" variant (SSID 103c:8dfb), so add it.
    >
    > Note: I don't know how to fix sound-mute LED though.
   
    What does this mean?  Is this patch confirmed to work or not?
   
    > Signed-off-by: Denis Batishchev <[email protected]>
    > Cc: <[email protected]>
    > ---
    >  sound/hda/codecs/realtek/alc269.c | 1 +
    >  1 file changed, 1 insertion(+)
    >
    > diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/
    realtek/alc269.c
    > index 78a865709..8eebf9159 100644
    > --- a/sound/hda/codecs/realtek/alc269.c
    > +++ b/sound/hda/codecs/realtek/alc269.c
    > @@ -7274,6 +7274,7 @@ static const struct hda_quirk alc269_fixup_tbl[] =
    {
    >       SND_PCI_QUIRK(0x103c, 0x8df1, "HP EliteBook 630 G12",
    ALC236_FIXUP_HP_GPIO_LED),
    >       SND_PCI_QUIRK(0x103c, 0x8df7, "HP Z66 G6",
    ALC236_FIXUP_HP_GPIO_LED),
    >       SND_PCI_QUIRK(0x103c, 0x8dfb, "HP EliteBook 6 G1a 14",
    ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
    > +     SND_PCI_QUIRK(0x103c, 0x8e0d, "HP EliteBook 6 G1a 14",
    ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
    >       SND_PCI_QUIRK(0x103c, 0x8dfc, "HP EliteBook 645 G12",
    ALC236_FIXUP_HP_GPIO_LED),
    >       SND_PCI_QUIRK(0x103c, 0x8dfd, "HP EliteBook 6 G1a 16",
    ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
    >       SND_PCI_QUIRK(0x103c, 0x8dfe, "HP EliteBook 665 G12",
    ALC236_FIXUP_HP_GPIO_LED),
   
    The table is sorted in PCI SSID order.  Please try to put the entry at
    the right position.

    thanks,
   
    Takashi

-- Денис

#4 lore raw

PATCH v2 1/1 ALSA: hda/realtek: Enable micmute LED on HP EliteBook 6 G1a

In reply to Denis Batishchev

The HP EliteBook 6 G1a (SSID 103c:8e0d) uses a Realtek ALC236 codec. Without a quirk no fixup is selected and the mic-mute LED stays off. It needs the same ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk as the already-supported 14" variant (SSID 103c:8dfb), so add it.

---
v2: reword commit message as was required by Takashi Iwai

 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)
sound/hda/codecs/realtek/alc269.c +1 -0
index 78a865709635..8eebf91595d3 100644
@@ -7274,6 +7274,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8df1, "HP EliteBook 630 G12", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8df7, "HP Z66 G6", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8dfb, "HP EliteBook 6 G1a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+	SND_PCI_QUIRK(0x103c, 0x8e0d, "HP EliteBook 6 G1a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
 	SND_PCI_QUIRK(0x103c, 0x8dfc, "HP EliteBook 645 G12", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8dfd, "HP EliteBook 6 G1a 16", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
 	SND_PCI_QUIRK(0x103c, 0x8dfe, "HP EliteBook 665 G12", ALC236_FIXUP_HP_GPIO_LED),
Signature · 1 line
2.53.0
#5 lore raw

Hi Denis,

Quoted 4 lines · Denis Batishchev

The HP EliteBook 6 G1a (SSID 103c:8e0d) uses a Realtek ALC236 codec. Without a quirk no fixup is selected and the mic-mute LED stays off. It needs the same ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk as the already-supported 14" variant (SSID 103c:8dfb), so add it.

What is your exact variant of this hardware? Also please refrain from sending V2 in response to V1: it makes patches harder to track.

Quoted 14 lines

---
v2: reword commit message as was required by Takashi Iwai

 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)
sound/hda/codecs/realtek/alc269.c +0 -0
index 78a865709635..8eebf91595d3 100644

sound/hda/codecs/realtek/alc269.c static const struct hda_quirk alc269_fixup_tbl[] = { · line 7277

Quoted 4 lines
sound/hda/codecs/realtek/alc269.c +1 -0
@@ -7274,6 +7274,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8df1, "HP EliteBook 630 G12", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8df7, "HP Z66 G6", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8dfb, "HP EliteBook 6 G1a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+	SND_PCI_QUIRK(0x103c, 0x8e0d, "HP EliteBook 6 G1a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),

The description string of the quirk seems copy-pasted. Are you sure you have the 14" variant?

Thanks,
Geraldo Nascimento

Quoted 7 lines
sound/hda/codecs/realtek/alc269.c +0 -0
 	SND_PCI_QUIRK(0x103c, 0x8dfc, "HP EliteBook 645 G12", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8dfd, "HP EliteBook 6 G1a 16", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
 	SND_PCI_QUIRK(0x103c, 0x8dfe, "HP EliteBook 665 G12", ALC236_FIXUP_HP_GPIO_LED),
Signature · 1 line
2.53.0
#6 lore raw

Hi Geraldo,

Sorry about wrong email threading. That's first time I'm sending patch to kernel.

My laptop's SKUs is AD3Q9ET#UUG.
It's HP Elitebook G1A 14" too but with a bit different audio chip as I understand. And quirk is indeed copy-pasted but with different device id.
I can change quirk description string to reflect my laptop version.

Best regards,
Denis B.

Quoted 43 lines · Geraldo Nascimento

Hi Denis,

Quoted 4 lines · Denis Batishchev

The HP EliteBook 6 G1a (SSID 103c:8e0d) uses a Realtek ALC236 codec. Without a quirk no fixup is selected and the mic-mute LED stays off. It needs the same ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk as the already-supported 14" variant (SSID 103c:8dfb), so add it.

What is your exact variant of this hardware? Also please refrain from sending V2 in response to V1: it makes patches harder to track.

Quoted 14 lines

---
v2: reword commit message as was required by Takashi Iwai

 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)
sound/hda/codecs/realtek/alc269.c +0 -0
index 78a865709635..8eebf91595d3 100644

sound/hda/codecs/realtek/alc269.c static const struct hda_quirk alc269_fixup_tbl[] = { · line 7277

Quoted 4 lines
sound/hda/codecs/realtek/alc269.c +1 -0
@@ -7274,6 +7274,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8df1, "HP EliteBook 630 G12", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8df7, "HP Z66 G6", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8dfb, "HP EliteBook 6 G1a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+	SND_PCI_QUIRK(0x103c, 0x8e0d, "HP EliteBook 6 G1a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),

The description string of the quirk seems copy-pasted. Are you sure you have the 14" variant?

Thanks,
Geraldo Nascimento

Quoted 7 lines
sound/hda/codecs/realtek/alc269.c +0 -0
 	SND_PCI_QUIRK(0x103c, 0x8dfc, "HP EliteBook 645 G12", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8dfd, "HP EliteBook 6 G1a 16", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
 	SND_PCI_QUIRK(0x103c, 0x8dfe, "HP EliteBook 665 G12", ALC236_FIXUP_HP_GPIO_LED),
Signature · 1 line
2.53.0