drm/amdgpu: Disable ras_check_bad_page_status on VFs
Subsystems (2)
PATCH 1/1 drm/amdgpu: Disable ras_check_bad_page_status on VFs
Host driver determines the bad_page_status, not VF. VFs do not have access to the EEPROM, and eeprom_init is skipped. However, check_bad_page_status is called outside of the eeprom_init sequence without any is_vf checks.
Add a return false in __is_ras_eeprom_supported for VFs, and use that guard in amdgpu_ras_check_bad_page_status to prevent incorrect access to un-initialized eeprom_control object.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c +4 -1
@@ -159,6 +159,9 @@static bool __is_ras_eeprom_supported (struct amdgpu_device *adev) { +if (amdgpu_sriov_vf (adev)) +return false; +switch (amdgpu_ip_version (adev,MP1_HWIP ,0 )) {case IP_VERSION (11 ,0 ,2 ):/* VEGA20 and ARCTURUS */ case IP_VERSION (11 ,0 ,7 ):/* Sienna cichlid */
@@ -1973,7 +1976,7 @@ void amdgpu_ras_check_bad_page_status(struct amdgpu_device *adev)struct amdgpu_ras *ras =amdgpu_ras_get_context (adev);struct amdgpu_ras_eeprom_control *control = ras ? &ras->eeprom_control :NULL ; -if (!control || amdgpu_bad_page_threshold ==0 ) +if (!__is_ras_eeprom_supported (adev) || !control || amdgpu_bad_page_threshold ==0 )return ;if (control->ras_num_bad_pages > ras->bad_page_cnt_threshold) {
Signature · 1 line
2.34.1
AMD General
Regards,
Hawking
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Victor Skvortsov
Sent: Thursday, June 4, 2026 10:15 PM
To: [email protected]; Zhou1, Tao <[email protected]>; Chan, Hing Pong <[email protected]>
Cc: Skvortsov, Victor <[email protected]>
Subject: [PATCH] drm/amdgpu: Disable ras_check_bad_page_status on VFs
Host driver determines the bad_page_status, not VF.
VFs do not have access to the EEPROM, and eeprom_init is skipped. However, check_bad_page_status is called outside of the eeprom_init sequence without any is_vf checks.
Add a return false in __is_ras_eeprom_supported for VFs, and use that guard in amdgpu_ras_check_bad_page_status to prevent incorrect access to un-initialized eeprom_control object.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c +3 -0
@@ -159,6 +159,9 @@static bool __is_ras_eeprom_supported (struct amdgpu_device *adev) { +if (amdgpu_sriov_vf (adev)) +return false; +switch (amdgpu_ip_version (adev,MP1_HWIP ,0 )) {case IP_VERSION (11 ,0 ,2 ):/* VEGA20 and ARCTURUS */ case IP_VERSION(11, 0, 7): /* Sienna cichlid */ @@ -1973,7 +1976,7 @@ void amdgpu_ras_check_bad_page_status(struct amdgpu_device *adev) struct amdgpu_ras *ras = amdgpu_ras_get_context(adev);
struct amdgpu_ras_eeprom_control *control = ras ? &ras->eeprom_control : NULL;
- if (!control || amdgpu_bad_page_threshold == 0)
+ if (!__is_ras_eeprom_supported(adev) || !control ||
+amdgpu_bad_page_threshold == 0)
return;
if (control->ras_num_bad_pages > ras->bad_page_cnt_threshold) {--
2.34.1