bnge: fix context mem iteration
Vikas Gupta
maintainerPATCH 1/1 bnge: fix context mem iteration
The firmware advertises context memory (backing store) types through a linked list, with BNGE_CTX_INV serving as the end-of-list sentinel.
However, the driver incorrectly assumes that the list is strictly ordered and prematurely terminates traversal when it encounters an unrecognized type (>=BNGE_CTX_V2_MAX). As a result, any valid context types that appear later in the chain are silently skipped, leading to incomplete memory configuration and eventual driver load failure.
Fix this by traversing the entire list until the BNGE_CTX_INV sentinel is reached, while safely ignoring only those context types that fall outside the supported range.
--- drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)
drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c +10 -4
@@ -277,7 +277,7 @@ int bnge_hwrm_func_backing_store_qcaps(struct bnge_dev *bd)struct hwrm_func_backing_store_qcaps_v2_output *resp;struct hwrm_func_backing_store_qcaps_v2_input *req;struct bnge_ctx_mem_info *ctx; -u16 type; +u16 type, next_type;int rc;if (bd->ctx)
@@ -294,8 +294,8 @@ int bnge_hwrm_func_backing_store_qcaps(struct bnge_dev *bd) resp =bnge_hwrm_req_hold (bd, req); -for (type =0 ; type <BNGE_CTX_V2_MAX ; ) { -struct bnge_ctx_mem_type *ctxm = &ctx->ctx_arr[type]; +for (type =0 ; type <BNGE_CTX_INV ; type = next_type) { +struct bnge_ctx_mem_type *ctxm;u8 init_val, init_off, i;__le32 *p;u32 flags;
@@ -304,8 +304,14 @@ int bnge_hwrm_func_backing_store_qcaps(struct bnge_dev *bd) rc =bnge_hwrm_req_send (bd, req);if (rc) goto ctx_done; + + next_type =le16_to_cpu (resp->next_valid_type); +if (type >=BNGE_CTX_V2_MAX ) +continue ; + + ctxm = &ctx->ctx_arr[type]; flags =le32_to_cpu (resp->flags); - type =le16_to_cpu (resp->next_valid_type); +if (!(flags &FUNC_BACKING_STORE_QCAPS_V2_RESP_FLAGS_TYPE_VALID ))continue ;
Signature · 1 line
2.47.1
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 11 lines · On Thu, 4 Jun 2026 22:07:09 +0530 you wrote:
The firmware advertises context memory (backing store) types through a linked list, with
BNGE_CTX_INVserving as the end-of-list sentinel.
However, the driver incorrectly assumes that the list is strictly ordered and prematurely terminates traversal when it encounters an unrecognized type (>=BNGE_CTX_V2_MAX). As a result, any valid context types that appear later in the chain are silently skipped, leading to incomplete memory configuration and eventual driver load failure.[...]
Here is the summary with links:
- [net] bnge: fix context mem iteration
https://git.kernel.org/netdev/net/c/3847d94783c0
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html