Skip to contentSkip to conversation

cpu: imx8_cpu: Add iMX8MP UltraLite Part cpu type

PATCH RESEND In review Ye Li 2 participants 3 messages Jun 5 Arm i.MX and Layerscape

lore
Share & tools
lore

Ye Li

author
#0 lore raw

PATCH RESEND 1/2 cpu: imx8_cpu: Add iMX8MP UltraLite Part cpu type

iMX8MP UltraLite part is missed in the cpu type print

---
 drivers/cpu/imx8_cpu.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/cpu/imx8_cpu.c +2 -0
index 3473712a423..f93477c993b 100644
@@ -69,6 +69,8 @@ static const char *get_imx_type_str(u32 imxtype)
 		return "8MP Lite[4]";	/* Quad-core Lite version of the imx8mp */
 	case MXC_CPU_IMX8MP6:
 		return "8MP[6]";	/* Quad-core version of the imx8mp, NPU fused */
+	case MXC_CPU_IMX8MPUL:
+		return "8MP UltraLite"; /* Quad-core UltraLite version of the imx8mp */
 	case MXC_CPU_IMX8MQ:
 		return "8MQ";	/* Quad-core version of the imx8mq */
 	case MXC_CPU_IMX8MQL:
Signature · 1 line
2.50.1
author
#1 lore raw

PATCH RESEND 2/2 cpu: imx8_cpu: fix the mpidr check

From: Peng Fan <[email protected]>

The mpidr's type is u32, however dev_read_addr returns a value with type fdt_addr_t(phys_addr_t) which is 64bit long. So the check never fail.

This patch we still keep mpidr as u32 type, because i.MX8 only has max two cluster, the higher 32bit will always be 0. Use a variable addr to do the check, if check pass, assign the lower 32 bit to plat->mpidr.

---
 drivers/cpu/imx8_cpu.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/cpu/imx8_cpu.c +5 -2
index f93477c993b..d26de8cb5da 100644
@@ -376,6 +376,7 @@ static int imx_cpu_probe(struct udevice *dev)
 {
 	struct cpu_imx_plat *plat = dev_get_plat(dev);
 	u32 cpurev;
+	fdt_addr_t addr;
 
 	set_core_data(dev);
 	cpurev = get_cpu_rev();
@@ -383,12 +384,14 @@ static int imx_cpu_probe(struct udevice *dev)
 	get_imx_rev_str(plat, cpurev & 0xFFF);
 	plat->type = get_imx_type_str((cpurev & 0x1FF000) >> 12);
 	plat->freq_mhz = imx_get_cpu_rate(dev) / 1000000;
-	plat->mpidr = dev_read_addr(dev);
-	if (plat->mpidr == FDT_ADDR_T_NONE) {
+	addr = dev_read_addr(dev);
+	if (addr == FDT_ADDR_T_NONE) {
 		printf("%s: Failed to get CPU reg property\n", __func__);
 		return -EINVAL;
 	}
 
+	plat->mpidr = (u32)addr;
+
 	return 0;
 }
 
Signature · 1 line
2.50.1