arm64: errata: Workaround NVIDIA Olympus device store/load ordering erratum
Subsystems (2)
PATCH v2 1/1 arm64: errata: Workaround NVIDIA Olympus device store/load ordering erratum
On systems with NVIDIA Olympus cores, a Device-nGnR* load can be observed by a peripheral before an older, non-overlapping Device-nGnR* store to the same peripheral. This breaks the program-order guarantee that software expects for Device-nGnR* accesses and can leave a peripheral in an incorrect state, as a load is observed before an earlier store takes effect.
The erratum can occur only when all of the following apply:
- A PE executes a Device-nGnR* store followed by a younger Device-nGnR* load.
- The store is not a store-release.
- The accesses target the same peripheral and do not overlap in bytes.
- There is at most one intervening Device-nGnR* store in program order, and there are no intervening Device-nGnR* loads.
- There is no DSB, and no DMB that orders loads, between the store and the load.
- Specific micro-architectural and timing conditions occur.
Two ways to restore ordering: insert a barrier (any DSB, or a DMB that orders loads) between the store and the load, or make the store a store-release. A load-acquire on the load side would not help, because acquire semantics do not prevent a load from being observed ahead of an older store; only the store side (release or a barrier) closes the window.
Promote the raw MMIO store helpers (__raw_writeb/w/l/q) from plain str* to stlr* (Store-Release), which removes the "store is not a store-release" condition for every device write the kernel issues. Because writel() and writel_relaxed() are both built on __raw_writel() in asm-generic/io.h, patching the raw variants covers both the non-relaxed and relaxed APIs without touching the higher layers. Note that writel()'s own barrier sits before the store, so it does not order the store against a subsequent readl(); the store-release promotion is what provides that ordering.
Like ARM64_ERRATUM_832075 on the load side, the change is gated on a new ARM64_WORKAROUND_DEVICE_STORE_RELEASE capability and only activated on parts that match MIDR_NVIDIA_OLYMPUS, so unaffected CPUs continue to use the plain str* sequence.
Note: stlr* only supports base-register addressing, so the raw accessors can no longer use the offset addressing introduced by commit d044d6ba6f02 ("arm64: io: permit offset addressing"). The str* and stlr* alternates share a single inline-asm operand and the sequence is selected at boot, so the operand form is fixed at compile time; unaffected CPUs keep using str* but also revert to base-register addressing. This keeps the store side as simple as the existing load-side patching (load-acquire) and avoids adding complexity to the device write path; retaining offset addressing only for str* would otherwise require a runtime branch on every write.
---
Changes since v1:
Update commit text based on feedback from Vladimir Murzin
Documentation/arch/arm64/silicon-errata.rst | 2 ++ arch/arm64/Kconfig | 23 ++++++++++++++++++++ arch/arm64/include/asm/io.h | 24 ++++++++++++++------- arch/arm64/kernel/cpu_errata.c | 8 +++++++ arch/arm64/tools/cpucaps | 1 + 5 files changed, 50 insertions(+), 8 deletions(-)
Documentation/arch/arm64/silicon-errata.rst +2 -0
@@ -256,6 +256,8 @@ stable kernels. +----------------+-----------------+-----------------+-----------------------------+ | NVIDIA | Carmel Core | N/A | NVIDIA_CARMEL_CNP_ERRATUM | +----------------+-----------------+-----------------+-----------------------------+ +| NVIDIA | Olympus core | T410-OLY-1027 | NVIDIA_OLYMPUS_1027_ERRATUM | ++----------------+-----------------+-----------------+-----------------------------+ | NVIDIA | T241 GICv3/4.x | T241-FABRIC-4 | N/A | +----------------+-----------------+-----------------+-----------------------------+ | NVIDIA | T241 MPAM | T241-MPAM-1 | N/A |
arch/arm64/Kconfig +23 -0
@@ -564,6 +564,29 @@ config ARM64_ERRATUM_832075 If unsure, say Y. +config NVIDIA_OLYMPUS_1027_ERRATUM + bool "NVIDIA Olympus: device store/load ordering erratum" + default y + help + This option adds an alternative code sequence to work around an + NVIDIA Olympus core erratum where a Device-nGnR* store can be + observed by a peripheral after a younger Device-nGnR* load to the + same peripheral. This breaks the program order that drivers rely + on for MMIO and can leave a device in an incorrect state. + + The workaround promotes the raw MMIO store helpers + (__raw_writeb/w/l/q) to Store-Release (STLR), which restores the + required ordering. Because writel() and writel_relaxed() are built + on __raw_writel(), both are covered without changes to the higher + layers. + + The fix is applied through the alternatives framework, so enabling + this option does not by itself activate the workaround: it is + patched in only when an affected CPU is detected, and is a no-op on + unaffected CPUs. + + If unsure, say Y. + config ARM64_ERRATUM_834220 bool "Cortex-A57: 834220: Stage 2 translation fault might be incorrectly reported in presence of a Stage 1 fault (rare)" depends on KVM
arch/arm64/include/asm/io.h +16 -8
@@ -25,29 +25,37 @@#define __raw_writeb __raw_writeb static __always_inline void __raw_writeb(u8 val, volatile void __iomem *addr) { -volatile u8 __iomem *ptr = addr; - asmvolatile ("strb %w0, %1" : :"rZ" (val),"Qo" (*ptr)); + asm volatile(ALTERNATIVE("strb %w0, [%1]", + "stlrb %w0, [%1]", + ARM64_WORKAROUND_DEVICE_STORE_RELEASE) + : : "rZ" (val), "r" (addr)); }#define __raw_writew __raw_writew static __always_inline void __raw_writew(u16 val, volatile void __iomem *addr) { -volatile u16 __iomem *ptr = addr; - asmvolatile ("strh %w0, %1" : :"rZ" (val),"Qo" (*ptr)); + asm volatile(ALTERNATIVE("strh %w0, [%1]", + "stlrh %w0, [%1]", + ARM64_WORKAROUND_DEVICE_STORE_RELEASE) + : : "rZ" (val), "r" (addr)); }#define __raw_writel __raw_writel static __always_inline void __raw_writel(u32 val, volatile void __iomem *addr) { -volatile u32 __iomem *ptr = addr; - asmvolatile ("str %w0, %1" : :"rZ" (val),"Qo" (*ptr)); + asm volatile(ALTERNATIVE("str %w0, [%1]", + "stlr %w0, [%1]", + ARM64_WORKAROUND_DEVICE_STORE_RELEASE) + : : "rZ" (val), "r" (addr)); }#define __raw_writeq __raw_writeq static __always_inline void __raw_writeq(u64 val, volatile void __iomem *addr) { -volatile u64 __iomem *ptr = addr; - asmvolatile ("str %x0, %1" : :"rZ" (val),"Qo" (*ptr)); + asm volatile(ALTERNATIVE("str %x0, [%1]", + "stlr %x0, [%1]", + ARM64_WORKAROUND_DEVICE_STORE_RELEASE) + : : "rZ" (val), "r" (addr)); }#define __raw_readb __raw_readb
arch/arm64/kernel/cpu_errata.c +8 -0
@@ -809,6 +809,14 @@ const struct arm64_cpu_capabilities arm64_errata[] = { ERRATA_MIDR_ALL_VERSIONS(MIDR_NVIDIA_CARMEL), },#endif +#ifdef CONFIG_NVIDIA_OLYMPUS_1027_ERRATUM + { + /* NVIDIA Olympus core */ + .desc = "NVIDIA Olympus device load/store ordering erratum", + .capability = ARM64_WORKAROUND_DEVICE_STORE_RELEASE, + ERRATA_MIDR_ALL_VERSIONS(MIDR_NVIDIA_OLYMPUS), + }, +#endif #ifdef CONFIG_ARM64_WORKAROUND_TRBE_OVERWRITE_FILL_MODE { /*
arch/arm64/tools/cpucaps +1 -0
@@ -120,6 +120,7 @@ WORKAROUND_CAVIUM_TX2_219_PRFM WORKAROUND_CAVIUM_TX2_219_TVM WORKAROUND_CLEAN_CACHE WORKAROUND_DEVICE_LOAD_ACQUIRE +WORKAROUND_DEVICE_STORE_RELEASE WORKAROUND_NVIDIA_CARMEL_CNP WORKAROUND_PMUV3_IMPDEF_TRAPS WORKAROUND_QCOM_FALKOR_E1003
Signature · 1 line
2.43.0
Will Deacon
maintainer[+Jason G]
Quoted 19 lines · Shanker Donthineni
On systems with NVIDIA Olympus cores, a Device-nGnR* load can be observed by a peripheral before an older, non-overlapping Device-nGnR* store to the same peripheral. This breaks the program-order guarantee that software expects for Device-nGnR* accesses and can leave a peripheral in an incorrect state, as a load is observed before an earlier store takes effect.
The erratum can occur only when all of the following apply:
- A PE executes a Device-nGnR* store followed by a younger Device-nGnR* load.
- The store is not a store-release.
- The accesses target the same peripheral and do not overlap in bytes.
- There is at most one intervening Device-nGnR* store in program order, and there are no intervening Device-nGnR* loads.
- There is no DSB, and no DMB that orders loads, between the store and the load.
- Specific micro-architectural and timing conditions occur.
Quoted 6 lines
Two ways to restore ordering: insert a barrier (any DSB, or a DMB that orders loads) between the store and the load, or make the store a store-release. A load-acquire on the load side would not help, because acquire semantics do not prevent a load from being observed ahead of an older store; only the store side (release or a barrier) closes the window.
I think you can drop the paragraph above. A store-release isn't enough to order against a later load in the architecture either, so we're clearly in micro-architecture territory and I don't think you need to describe mechanisms that don't work here.
Quoted 9 lines
Promote the raw MMIO store helpers (__raw_writeb/w/l/q) from plain str* to stlr* (Store-Release), which removes the "store is not a store-release" condition for every device write the kernel issues. Because
writel()andwritel_relaxed()are both built on__raw_writel()inasm-generic/io.h, patching the raw variants covers both the non-relaxed and relaxed APIs without touching the higher layers. Note that writel()'s own barrier sits before the store, so it does not order the store against a subsequentreadl(); the store-release promotion is what provides that ordering.
Sashiko points out that you're missing __const_memcpy_toio_aligned32().
Quoted 5 lines
Like
ARM64_ERRATUM_832075on the load side, the change is gated on a newARM64_WORKAROUND_DEVICE_STORE_RELEASEcapability and only activated on parts that matchMIDR_NVIDIA_OLYMPUS, so unaffected CPUs continue to use the plain str* sequence.
Quoted 10 lines
Note: stlr* only supports base-register addressing, so the raw accessors can no longer use the offset addressing introduced by commit
d044d6ba6f02("arm64: io: permit offset addressing"). The str* and stlr* alternates share a single inline-asm operand and the sequence is selected at boot, so the operand form is fixed at compile time; unaffected CPUs keep using str* but also revert to base-register addressing. This keeps the store side as simple as the existing load-side patching (load-acquire) and avoids adding complexity to the device write path; retaining offset addressing only for str* would otherwise require a runtime branch on every write.
I seem to remember Jason caring about that, possibly because some CPUs are very picky about write-combining?
Will
Quoted 11 lines · Will Deacon
Quoted 10 lines
Note: stlr* only supports base-register addressing, so the raw accessors can no longer use the offset addressing introduced by commit
d044d6ba6f02("arm64: io: permit offset addressing"). The str* and stlr* alternates share a single inline-asm operand and the sequence is selected at boot, so the operand form is fixed at compile time; unaffected CPUs keep using str* but also revert to base-register addressing. This keeps the store side as simple as the existing load-side patching (load-acquire) and avoids adding complexity to the device write path; retaining offset addressing only for str* would otherwise require a runtime branch on every write.
Quoted 2 lines
I seem to remember Jason caring about that, possibly because some CPUs are very picky about write-combining?
I think it was more a fall out of the work there, after looking at the assembly this minor edit to the constraint made a nice codegen impact. It is certainly a shame to loose it for this bug.
If we care about write combining we can't have a branch anyhow, but that is most important for the specific memcpy operations (which will need a branch)
Jason
Hi Will,
Quoted 31 lines · Will Deacon
External email: Use caution opening links or attachments
[+Jason G]
Quoted 19 lines · Shanker Donthineni
On systems with NVIDIA Olympus cores, a Device-nGnR* load can be observed by a peripheral before an older, non-overlapping Device-nGnR* store to the same peripheral. This breaks the program-order guarantee that software expects for Device-nGnR* accesses and can leave a peripheral in an incorrect state, as a load is observed before an earlier store takes effect.
The erratum can occur only when all of the following apply:
- A PE executes a Device-nGnR* store followed by a younger Device-nGnR* load.
- The store is not a store-release.
- The accesses target the same peripheral and do not overlap in bytes.
- There is at most one intervening Device-nGnR* store in program order, and there are no intervening Device-nGnR* loads.
- There is no DSB, and no DMB that orders loads, between the store and the load.
- Specific micro-architectural and timing conditions occur.Quoted 6 lines
Two ways to restore ordering: insert a barrier (any DSB, or a DMB that orders loads) between the store and the load, or make the store a store-release. A load-acquire on the load side would not help, because acquire semantics do not prevent a load from being observed ahead of an older store; only the store side (release or a barrier) closes the window.
Quoted 4 lines
I think you can drop the paragraph above. A store-release isn't enough to order against a later load in the architecture either, so we're clearly in micro-architecture territory and I don't think you need to describe mechanisms that don't work here.
Thanks, Will. I’ll drop paragraph and avoid describing store-release as an architectural ordering mechanism here.
Quoted 10 lines
Quoted 9 lines
Promote the raw MMIO store helpers (__raw_writeb/w/l/q) from plain str* to stlr* (Store-Release), which removes the "store is not a store-release" condition for every device write the kernel issues. Because
writel()andwritel_relaxed()are both built on__raw_writel()inasm-generic/io.h, patching the raw variants covers both the non-relaxed and relaxed APIs without touching the higher layers. Note that writel()'s own barrier sits before the store, so it does not order the store against a subsequentreadl(); the store-release promotion is what provides that ordering.Sashiko points out that you're missing
__const_memcpy_toio_aligned32().
I’ll also cover __const_memcpy_toio_aligned32(); it currently emits plain STRs directly and can bypass the raw write helper workaround. I’ll audit the aligned64 path at the same time.
Quoted 15 lines
Quoted 5 lines
Like
ARM64_ERRATUM_832075on the load side, the change is gated on a newARM64_WORKAROUND_DEVICE_STORE_RELEASEcapability and only activated on parts that matchMIDR_NVIDIA_OLYMPUS, so unaffected CPUs continue to use the plain str* sequence.Quoted 10 lines
Note: stlr* only supports base-register addressing, so the raw accessors can no longer use the offset addressing introduced by commit
d044d6ba6f02("arm64: io: permit offset addressing"). The str* and stlr* alternates share a single inline-asm operand and the sequence is selected at boot, so the operand form is fixed at compile time; unaffected CPUs keep using str* but also revert to base-register addressing. This keeps the store side as simple as the existing load-side patching (load-acquire) and avoids adding complexity to the device write path; retaining offset addressing only for str* would otherwise require a runtime branch on every write.
Quoted 2 lines
I seem to remember Jason caring about that, possibly because some CPUs are very picky about write-combining?
For the offset-addressing concern, I’ll rework the raw accessors so unaffected CPUs keep the existing offset-addressed STR sequence, and only CPUs with ARM64_WORKAROUND_DEVICE_STORE_RELEASE take the base-register STLR path.
I’ll post a v3 using the patched branch from alternative_has_cap_unlikely(), and include the memcpy_toio() aligned-helper coverage as shown below.
arch/arm64/include/asm/io.h +0 -0
@@ -22,10 +22,46 @@
/*
* Generic IO read/write. These perform native-endian accesses.
*/
+static __always_inline bool arm64_needs_device_store_release(void)
+{
+ return alternative_has_cap_unlikely(
+ ARM64_WORKAROUND_DEVICE_STORE_RELEASE);
+}
+
+static __always_inline void __raw_writeb_stlr(u8 val,
+ volatile void __iomem *addr)
+{
+ asm volatile("stlrb %w0, [%1]" : : "rZ" (val), "r" (addr));
+}
+
+static __always_inline void __raw_writew_stlr(u16 val,
+ volatile void __iomem *addr)
+{
+ asm volatile("stlrh %w0, [%1]" : : "rZ" (val), "r" (addr));
+}
+
+static __always_inline void __raw_writel_stlr(u32 val,
+ volatile void __iomem *addr)
+{
+ asm volatile("stlr %w0, [%1]" : : "rZ" (val), "r" (addr));
+}
+
+static __always_inline void __raw_writeq_stlr(u64 val,
+ volatile void __iomem *addr)
+{
+ asm volatile("stlr %x0, [%1]" : : "rZ" (val), "r" (addr));
+}
+
#define __raw_writeb __raw_writeb
static __always_inline void __raw_writeb(u8 val, volatile void __iomem *addr)
{
volatile u8 __iomem *ptr = addr;
+
+ if (arm64_needs_device_store_release()) {
+ __raw_writeb_stlr(val, addr);
+ return;
+ }
+
asm volatile("strb %w0, %1" : : "rZ" (val), "Qo" (*ptr));
}
@@ -33,6 +69,12 @@ static __always_inline void __raw_writeb(u8 val, volatile void __iomem *addr) static __always_inline void __raw_writew(u16 val, volatile void __iomem *addr)
{
volatile u16 __iomem *ptr = addr;
+
+ if (arm64_needs_device_store_release()) {
+ __raw_writew_stlr(val, addr);
+ return;
+ }
+
asm volatile("strh %w0, %1" : : "rZ" (val), "Qo" (*ptr));
}
@@ -40,6 +82,12 @@ static __always_inline void __raw_writew(u16 val, volatile void __iomem *addr) static __always_inline void __raw_writel(u32 val, volatile void __iomem *addr)
{
volatile u32 __iomem *ptr = addr;
+
+ if (arm64_needs_device_store_release()) {
+ __raw_writel_stlr(val, addr);
+ return;
+ }
+
asm volatile("str %w0, %1" : : "rZ" (val), "Qo" (*ptr));
}
@@ -47,6 +95,12 @@ static __always_inline void __raw_writel(u32 val, volatile void __iomem *addr) static __always_inline void __raw_writeq(u64 val, volatile void __iomem *addr)
{
volatile u64 __iomem *ptr = addr;
+
+ if (arm64_needs_device_store_release()) {
+ __raw_writeq_stlr(val, addr);
+ return;
+ }
+
asm volatile("str %x0, %1" : : "rZ" (val), "Qo" (*ptr));
}
@@ -147,6 +201,12 @@ static __always_inline void __const_memcpy_toio_aligned32(volatile u32 __iomem *to, const u32 *from,
size_t count)
{
+ if (arm64_needs_device_store_release()) {
+ while (count--)
+ __raw_writel_stlr(*from++, to++);
+ return;
+ }
+
switch (count) {
case 8:
asm volatile("str %w0, [%8, #4 * 0]\n"
@@ -204,6 +264,12 @@ static __always_inline void __const_memcpy_toio_aligned64(volatile u64 __iomem *to, const u64 *from,
size_t count)
{
+ if (arm64_needs_device_store_release()) {
+ while (count--)
+ __raw_writeq_stlr(*from++, to++);
+ return;
+ }
+
switch (count) {
case 8:
asm volatile("str %x0, [%8, #8 * 0]\n"
I'll post v3 patch with jump instruction patch.
arch/arm64/include/asm/io.h +0 -0
@@ -22,10 +22,46 @@
/*
* Generic IO read/write. These perform native-endian accesses.
*/
+static __always_inline bool arm64_needs_device_store_release(void)
+{
+ return alternative_has_cap_unlikely(
+ ARM64_WORKAROUND_DEVICE_STORE_RELEASE);
+}
+
+static __always_inline void __raw_writeb_stlr(u8 val,
+ volatile void __iomem *addr)
+{
+ asm volatile("stlrb %w0, [%1]" : : "rZ" (val), "r" (addr));
+}
+
+static __always_inline void __raw_writew_stlr(u16 val,
+ volatile void __iomem *addr)
+{
+ asm volatile("stlrh %w0, [%1]" : : "rZ" (val), "r" (addr));
+}
+
+static __always_inline void __raw_writel_stlr(u32 val,
+ volatile void __iomem *addr)
+{
+ asm volatile("stlr %w0, [%1]" : : "rZ" (val), "r" (addr));
+}
+
+static __always_inline void __raw_writeq_stlr(u64 val,
+ volatile void __iomem *addr)
+{
+ asm volatile("stlr %x0, [%1]" : : "rZ" (val), "r" (addr));
+}
+
#define __raw_writeb __raw_writeb
static __always_inline void __raw_writeb(u8 val, volatile void __iomem *addr)
{
volatile u8 __iomem *ptr = addr;
+
+ if (arm64_needs_device_store_release()) {
+ __raw_writeb_stlr(val, addr);
+ return;
+ }
+
asm volatile("strb %w0, %1" : : "rZ" (val), "Qo" (*ptr));
}
@@ -33,6 +69,12 @@ static __always_inline void __raw_writeb(u8 val, volatile void __iomem *addr) static __always_inline void __raw_writew(u16 val, volatile void __iomem *addr)
{
volatile u16 __iomem *ptr = addr;
+
+ if (arm64_needs_device_store_release()) {
+ __raw_writew_stlr(val, addr);
+ return;
+ }
+
asm volatile("strh %w0, %1" : : "rZ" (val), "Qo" (*ptr));
}
@@ -40,6 +82,12 @@ static __always_inline void __raw_writew(u16 val, volatile void __iomem *addr) static __always_inline void __raw_writel(u32 val, volatile void __iomem *addr)
{
volatile u32 __iomem *ptr = addr;
+
+ if (arm64_needs_device_store_release()) {
+ __raw_writel_stlr(val, addr);
+ return;
+ }
+
asm volatile("str %w0, %1" : : "rZ" (val), "Qo" (*ptr));
}
@@ -47,6 +95,12 @@ static __always_inline void __raw_writel(u32 val, volatile void __iomem *addr) static __always_inline void __raw_writeq(u64 val, volatile void __iomem *addr)
{
volatile u64 __iomem *ptr = addr;
+
+ if (arm64_needs_device_store_release()) {
+ __raw_writeq_stlr(val, addr);
+ return;
+ }
+
asm volatile("str %x0, %1" : : "rZ" (val), "Qo" (*ptr));
}
@@ -147,6 +201,12 @@ static __always_inline void __const_memcpy_toio_aligned32(volatile u32 __iomem *to, const u32 *from,
size_t count)
{
+ if (arm64_needs_device_store_release()) {
+ while (count--)
+ __raw_writel_stlr(*from++, to++);
+ return;
+ }
+
switch (count) {
case 8:
asm volatile("str %w0, [%8, #4 * 0]\n"
@@ -204,6 +264,12 @@ static __always_inline void __const_memcpy_toio_aligned64(volatile u64 __iomem *to, const u64 *from,
size_t count)
{
+ if (arm64_needs_device_store_release()) {
+ while (count--)
+ __raw_writeq_stlr(*from++, to++);
+ return;
+ }
+
switch (count) {
case 8:
asm volatile("str %x0, [%8, #8 * 0]\n"
-Shanker
Hi Will,
Quoted 31 lines · Will Deacon
External email: Use caution opening links or attachments
[+Jason G]
Quoted 19 lines · Shanker Donthineni
On systems with NVIDIA Olympus cores, a Device-nGnR* load can be observed by a peripheral before an older, non-overlapping Device-nGnR* store to the same peripheral. This breaks the program-order guarantee that software expects for Device-nGnR* accesses and can leave a peripheral in an incorrect state, as a load is observed before an earlier store takes effect.
The erratum can occur only when all of the following apply:
- A PE executes a Device-nGnR* store followed by a younger Device-nGnR* load.
- The store is not a store-release.
- The accesses target the same peripheral and do not overlap in bytes.
- There is at most one intervening Device-nGnR* store in program order, and there are no intervening Device-nGnR* loads.
- There is no DSB, and no DMB that orders loads, between the store and the load.
- Specific micro-architectural and timing conditions occur.Quoted 6 lines
Two ways to restore ordering: insert a barrier (any DSB, or a DMB that orders loads) between the store and the load, or make the store a store-release. A load-acquire on the load side would not help, because acquire semantics do not prevent a load from being observed ahead of an older store; only the store side (release or a barrier) closes the window.
Quoted 14 lines
I think you can drop the paragraph above. A store-release isn't enough to order against a later load in the architecture either, so we're clearly in micro-architecture territory and I don't think you need to describe mechanisms that don't work here.
Quoted 9 lines
Promote the raw MMIO store helpers (__raw_writeb/w/l/q) from plain str* to stlr* (Store-Release), which removes the "store is not a store-release" condition for every device write the kernel issues. Because
writel()andwritel_relaxed()are both built on__raw_writel()inasm-generic/io.h, patching the raw variants covers both the non-relaxed and relaxed APIs without touching the higher layers. Note that writel()'s own barrier sits before the store, so it does not order the store against a subsequentreadl(); the store-release promotion is what provides that ordering.
Based on the existing code comments and after reviewing this path again, __const_memcpy_toio_aligned32() and __const_memcpy_toio_aligned64() appear to be intended for WC regions. Since the erratum is scoped to Device-nGnR* accesses, and WC mappings are Normal-NC on arm64, I don’t think the STLR workaround should apply to these helpers by default.
Applying it there would also break the contiguous STR grouping that this path relies on for write combining.
-Shanker
Quoted 5 lines · Shanker Donthineni
Based on the existing code comments and after reviewing this path again,
__const_memcpy_toio_aligned32()and__const_memcpy_toio_aligned64()appear to be intended for WC regions. Since the erratum is scoped to Device-nGnR* accesses, and WC mappings are Normal-NC on arm64, I don’t think the STLR workaround should apply to these helpers by default.
Hmm, unfortunately I think the APIs mix together IO and WC both as __iomem things. However I recall when I was looking a this everyone was using it for WC.
Jason