FAILED: patch "[PATCH] usb: musb: omap2430: Fix use-after-free in omap2430_probe()" failed to apply to 6.6-stable tree
[email protected]
maintainerThe patch below does not apply to the 6.6-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y
git checkout FETCH_HEAD
git cherry-pick -x e194ce048f5a6c549b3a23a8c568c6470f40f772
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2026060438-hedging-paycheck-ec7a@gregkh' --subject-prefix 'PATCH 6.6.y' HEAD^..
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From e194ce048f5a6c549b3a23a8c568c6470f40f772 Mon Sep 17 00:00:00 2001
From: Wentao Liang <[email protected]>
Date: Thu, 9 Apr 2026 10:11:04 +0000
Subject: [PATCH] usb: musb: omap2430: Fix use-after-free in omap2430_probe()
In omap2430_probe(), of_node_put(np) is called prematurely before the last access to np, leading to a use-after-free if the node's reference count drops to zero. Move the of_node_put() calls after the last use of np in both the success and error paths.
drivers/usb/musb/omap2430.c +2 -1
@@ -337,7 +337,6 @@ static int omap2430_probe(struct platform_device *pdev) }else {device_set_of_node_from_dev (&musb->dev, &pdev->dev); } -of_node_put (np); glue->dev = &pdev->dev; glue->musb = musb;
@@ -455,6 +454,7 @@ static int omap2430_probe(struct platform_device *pdev)dev_err (&pdev->dev,"failed to register musb device\n" ); goto err_disable_rpm; } +of_node_put (np);return 0 ;
@@ -464,6 +464,7 @@ static int omap2430_probe(struct platform_device *pdev)if (!IS_ERR (glue->control_otghs))put_device (glue->control_otghs); err_put_musb: +of_node_put (np);platform_device_put (musb);return ret;
Sasha Levin
maintainerPATCH 1/1 usb: musb: omap2430: Fix use-after-free in omap2430_probe()
From: Wentao Liang <[email protected]>
[ Upstream commit e194ce048f5a6c549b3a23a8c568c6470f40f772 ]
In omap2430_probe(), of_node_put(np) is called prematurely before the last access to np, leading to a use-after-free if the node's reference count drops to zero. Move the of_node_put() calls after the last use of np in both the success and error paths.
--- drivers/usb/musb/omap2430.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/musb/omap2430.c +2 -1
@@ -340,7 +340,6 @@ static int omap2430_probe(struct platform_device *pdev) }else {device_set_of_node_from_dev (&musb->dev, &pdev->dev); } -of_node_put (np); glue->dev = &pdev->dev; glue->musb = musb;
@@ -458,6 +457,7 @@ static int omap2430_probe(struct platform_device *pdev)dev_err (&pdev->dev,"failed to register musb device\n" ); goto err3; } +of_node_put (np);return 0 ;
@@ -467,6 +467,7 @@ static int omap2430_probe(struct platform_device *pdev)if (!IS_ERR (glue->control_otghs))put_device (glue->control_otghs); err2: +of_node_put (np);platform_device_put (musb); err0:
Signature · 1 line
2.53.0