Skip to contentSkip to conversation

RDMA/rxe: Fix use-after-free of netdev in smc_ib_port_event_work

PATCH In review Jordan Walters 3 participants 3 messages Jun 3 – Jun 5

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RDMA/rxe: Fix use-after-free of netdev in smc_ib_port_event_work

rxe_net_del() drops its reference to the underlying net_device via dev_put() but does not clear the netdev pointer from the ib_device. This leaves a dangling pointer that the async smc_ib_port_event_work worker can dereference after the net_device has been freed, causing a use-after-free in __ethtool_get_link_ksettings().

An unprivileged user can trigger this via user namespaces by creating a dummy interface, binding it to rdma_rxe, and immediately destroying the namespace before the worker fires.

Clear the netdev pointer via ib_device_set_netdev() before releasing the reference. Downstream callers such as ib_get_eth_speed() already handle a NULL netdev safely.

Note: this is a distinct issue from the socket TOCTOU race fixed by Zhu Yanjun in [1]. That patch addresses a race on the pernet socket pointers (rxe_sk4/sk6) leading to a NULL deref in kernel_sock_shutdown(). This patch fixes a dangling netdev pointer leading to a UAF in __ethtool_get_link_ksettings via smc_ib_port_event_work.

---
 drivers/infiniband/sw/rxe/rxe_net.c | 1 +
 1 file changed, 1 insertion(+)
drivers/infiniband/sw/rxe/rxe_net.c +1 -0
index 50a2cb5405e2..a8f91d6e3b17 100644
@@ -663,6 +663,7 @@ void rxe_net_del(struct ib_device *dev)
 	if (sk)
 		rxe_sock_put(sk, rxe_ns_pernet_set_sk6, net);
 
+	ib_device_set_netdev(dev, NULL, 1);
 	dev_put(ndev);
 }
 
Signature · 1 line
2.49.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 15 lines · Jordan Walters

rxe_net_del() drops its reference to the underlying net_device via dev_put() but does not clear the netdev pointer from the ib_device. This leaves a dangling pointer that the async smc_ib_port_event_work worker can dereference after the net_device has been freed, causing a use-after-free in __ethtool_get_link_ksettings().

An unprivileged user can trigger this via user namespaces by creating a dummy interface, binding it to rdma_rxe, and immediately destroying the namespace before the worker fires.

Clear the netdev pointer via ib_device_set_netdev() before releasing the reference. Downstream callers such as ib_get_eth_speed() already handle a NULL netdev safely.

Quoted 8 lines

Note: this is a distinct issue from the socket TOCTOU race fixed by Zhu Yanjun in [1]. That patch addresses a race on the pernet socket pointers (rxe_sk4/sk6) leading to a NULL deref in kernel_sock_shutdown(). This patch fixes a dangling netdev pointer leading to a UAF in __ethtool_get_link_ksettings via smc_ib_port_event_work.

Thanks a lot. I am fine with this commit.
Although Sashiko complains about this commit, it seems that all the problems have already existed.

Zhu Yanjun

Quoted 18 lines
---
  drivers/infiniband/sw/rxe/rxe_net.c | 1 +
  1 file changed, 1 insertion(+)
drivers/infiniband/sw/rxe/rxe_net.c +1 -0
index 50a2cb5405e2..a8f91d6e3b17 100644
@@ -663,6 +663,7 @@ void rxe_net_del(struct ib_device *dev)
  	if (sk)
  		rxe_sock_put(sk, rxe_ns_pernet_set_sk6, net);
 
+	ib_device_set_netdev(dev, NULL, 1);
  	dev_put(ndev);
  }
 
maintainer
#2 lore raw
In reply to Jordan Walters

drivers/infiniband/sw/rxe/rxe_net.c void rxe_net_del(struct ib_device *dev) · line 667

Quoted 6 lines · Jordan Walters
drivers/infiniband/sw/rxe/rxe_net.c +1 -0
@@ -663,6 +663,7 @@ void rxe_net_del(struct ib_device *dev)
 	if (sk)
 		rxe_sock_put(sk, rxe_ns_pernet_set_sk6, net);
 
+	ib_device_set_netdev(dev, NULL, 1);
 	dev_put(ndev);

None of how rxe is handling the netdev seems to be correct at all.

The affiliated netdev of an IB device cannot be unrefed until the ib device itself is destroyed, the above is just more racy wrongness even if it makes the splat go away.

rxe_net_del() needs to be deleted, not patched.

I'm getting very fed up with all this RXE garbage, it has got a lot worse lately with all these attempts to "improve" it and I don't want to be looking at this endless stream of bugs reports.

and zhu don't send me any more AI written emails.

Jason