Skip to contentSkip to conversation

ata: pata_legacy: remove documentation for removed module parameters

PATCH Applied Ethan Nelson-Moore 5 participants 7 messages Jun 7 – Sep 10

Subsystems (2)
Stable branch Documentation
lore
Share & tools
lore

Ethan Nelson-Moore

author
#0 lore raw

PATCH 1/1 ata: pata_legacy: remove documentation for removed module parameters

Commit 3c4d783f6922 ("ata: pata_legacy: remove VLB support") removed several module parameters from the pata_legacy driver, but neglected to remove their documentation. Remove it.

Fixes 3c4d783f6922 ("ata: pata_legacy: remove VLB support")
Cc [email protected] # 7.0+
Signed-off-by Ethan Nelson-Moore <[email protected]>
---
 .../admin-guide/kernel-parameters.txt         | 37 -------------------
 1 file changed, 37 deletions(-)
Documentation/admin-guide/kernel-parameters.txt +0 -37
index 97007f4f69d4..47bccc148a54 100644
@@ -4935,18 +4935,6 @@ Kernel parameters
 			Set to non-zero if a chip is present that snoops speed
 			changes.  Disabled by default.
 
-	pata_legacy.ht6560a=	[HW,LIBATA]
-			Format: <int>
-			Set to 1, 2, or 3 for HT 6560A on the primary channel,
-			the secondary channel, or both channels respectively.
-			Disabled by default.
-
-	pata_legacy.ht6560b=	[HW,LIBATA]
-			Format: <int>
-			Set to 1, 2, or 3 for HT 6560B on the primary channel,
-			the secondary channel, or both channels respectively.
-			Disabled by default.
-
 	pata_legacy.iordy_mask=	[HW,LIBATA]
 			Format: <int>
 			IORDY enable mask.  Set individual bits to allow IORDY

@@ -4959,18 +4947,6 @@ Kernel parameters
 			with the sequence.  By default IORDY is allowed across
 			all channels.
 
-	pata_legacy.opti82c46x=	[HW,LIBATA]
-			Format: <int>
-			Set to 1, 2, or 3 for Opti 82c611A on the primary
-			channel, the secondary channel, or both channels
-			respectively.  Disabled by default.
-
-	pata_legacy.opti82c611a=	[HW,LIBATA]
-			Format: <int>
-			Set to 1, 2, or 3 for Opti 82c465MV on the primary
-			channel, the secondary channel, or both channels
-			respectively.  Disabled by default.
-
 	pata_legacy.pio_mask=	[HW,LIBATA]
 			Format: <int>
 			PIO mode mask for autospeed devices.  Set individual

@@ -4994,19 +4970,6 @@ Kernel parameters
 			the first port in the list above (0x1f0), and so on.
 			By default all supported ports are probed.
 
-	pata_legacy.qdi=	[HW,LIBATA]
-			Format: <int>
-			Set to non-zero to probe QDI controllers.  By default
-			set to 1 if CONFIG_PATA_QDI_MODULE, 0 otherwise.
-
-	pata_legacy.winbond=	[HW,LIBATA]
-			Format: <int>
-			Set to non-zero to probe Winbond controllers.  Use
-			the standard I/O port (0x130) if 1, otherwise the
-			value given is the I/O port to use (typically 0x1b0).
-			By default set to 1 if CONFIG_PATA_WINBOND_VLB_MODULE,
-			0 otherwise.
-
 	pata_platform.pio_mask=	[HW,LIBATA]
 			Format: <int>
 			Supported PIO mode mask.  Set individual bits to allow
Signature · 1 line
2.43.0
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Ethan Nelson-Moore

Commit 3c4d783f6922 ("ata: pata_legacy: remove VLB support") removed several module parameters from the pata_legacy driver, but neglected to remove their documentation. Remove it.

Fixes 3c4d783f6922 ("ata: pata_legacy: remove VLB support")
Cc [email protected] # 7.0+
Signed-off-by Ethan Nelson-Moore <[email protected]>
Reviewed-by Randy Dunlap <[email protected]>

Thanks.

Quoted 66 lines
---
 .../admin-guide/kernel-parameters.txt         | 37 -------------------
 1 file changed, 37 deletions(-)
Documentation/admin-guide/kernel-parameters.txt +0 -37
index 97007f4f69d4..47bccc148a54 100644
@@ -4935,18 +4935,6 @@ Kernel parameters
 			Set to non-zero if a chip is present that snoops speed
 			changes.  Disabled by default.
 
-	pata_legacy.ht6560a=	[HW,LIBATA]
-			Format: <int>
-			Set to 1, 2, or 3 for HT 6560A on the primary channel,
-			the secondary channel, or both channels respectively.
-			Disabled by default.
-
-	pata_legacy.ht6560b=	[HW,LIBATA]
-			Format: <int>
-			Set to 1, 2, or 3 for HT 6560B on the primary channel,
-			the secondary channel, or both channels respectively.
-			Disabled by default.
-
 	pata_legacy.iordy_mask=	[HW,LIBATA]
 			Format: <int>
 			IORDY enable mask.  Set individual bits to allow IORDY

@@ -4959,18 +4947,6 @@ Kernel parameters
 			with the sequence.  By default IORDY is allowed across
 			all channels.
 
-	pata_legacy.opti82c46x=	[HW,LIBATA]
-			Format: <int>
-			Set to 1, 2, or 3 for Opti 82c611A on the primary
-			channel, the secondary channel, or both channels
-			respectively.  Disabled by default.
-
-	pata_legacy.opti82c611a=	[HW,LIBATA]
-			Format: <int>
-			Set to 1, 2, or 3 for Opti 82c465MV on the primary
-			channel, the secondary channel, or both channels
-			respectively.  Disabled by default.
-
 	pata_legacy.pio_mask=	[HW,LIBATA]
 			Format: <int>
 			PIO mode mask for autospeed devices.  Set individual

@@ -4994,19 +4970,6 @@ Kernel parameters
 			the first port in the list above (0x1f0), and so on.
 			By default all supported ports are probed.
 
-	pata_legacy.qdi=	[HW,LIBATA]
-			Format: <int>
-			Set to non-zero to probe QDI controllers.  By default
-			set to 1 if CONFIG_PATA_QDI_MODULE, 0 otherwise.
-
-	pata_legacy.winbond=	[HW,LIBATA]
-			Format: <int>
-			Set to non-zero to probe Winbond controllers.  Use
-			the standard I/O port (0x130) if 1, otherwise the
-			value given is the I/O port to use (typically 0x1b0).
-			By default set to 1 if CONFIG_PATA_WINBOND_VLB_MODULE,
-			0 otherwise.
-
 	pata_platform.pio_mask=	[HW,LIBATA]
 			Format: <int>
 			Supported PIO mode mask.  Set individual bits to allow
Signature · 1 line
~Randy
Reviewed-by on v1 1/1
#2 lore raw
In reply to Ethan Nelson-Moore
Quoted 7 lines · Ethan Nelson-Moore

Commit 3c4d783f6922 ("ata: pata_legacy: remove VLB support") removed several module parameters from the pata_legacy driver, but neglected to remove their documentation. Remove it.

Fixes 3c4d783f6922 ("ata: pata_legacy: remove VLB support")
Cc [email protected] # 7.0+
Signed-off-by Ethan Nelson-Moore <[email protected]>
Reviewed-by Damien Le Moal <[email protected]>
Signature · 2 lines
Damien Le Moal
Western Digital Research
Reviewed-by on v1 1/1
#3 lore raw
In reply to Ethan Nelson-Moore
Quoted 3 lines · Ethan Nelson-Moore

Commit 3c4d783f6922 ("ata: pata_legacy: remove VLB support") removed several module parameters from the pata_legacy driver, but neglected to remove their documentation. Remove it.

Checked against current mainline. That commit removed exactly these six module parameters, and this patch still applies.

Reviewed-by Karl Mehltretter <[email protected]>

Thanks,
Karl

Acked-by on v1 1/1
#4 lore raw
In reply to Ethan Nelson-Moore
Quoted 7 lines · Ethan Nelson-Moore

Commit 3c4d783f6922 ("ata: pata_legacy: remove VLB support") removed several module parameters from the pata_legacy driver, but neglected to remove their documentation. Remove it.

Fixes 3c4d783f6922 ("ata: pata_legacy: remove VLB support")
Cc [email protected] # 7.0+
Signed-off-by Ethan Nelson-Moore <[email protected]>
Acked-by Niklas Cassel <[email protected]>

This patch was sent to [email protected] and linux-ide was not even added as CC, so I assume you want this to go via Jonathan's tree.

Kind regards,
Niklas

author
#5 lore raw

Hi, Niklas,

Quoted 2 lines · Niklas Cassel

This patch was sent to [email protected] and linux-ide was not even added as CC, so I assume you want this to go via Jonathan's tree.

I don't think that was intentional - the script I wrote to integrate get_maintainer.pl with git send-email had some bugs causing it to exclude entries. I have since fixed them. Feel free to merge it via the IDE tree.

Ethan

Applied
#6 lore raw
In reply to Ethan Nelson-Moore
Quoted 5 lines · Ethan Nelson-Moore

Commit 3c4d783f6922 ("ata: pata_legacy: remove VLB support") removed several module parameters from the pata_legacy driver, but neglected to remove their documentation. Remove it.

Applied to libata/linux.git (for-7.3-fixes), thanks!

[1/1] ata: pata_legacy: remove documentation for removed module parameters

      https://git.kernel.org/libata/linux/c/a19d4f9b

Kind regards,
Niklas