Skip to contentSkip to conversation

drm: panel-orientation-quirks: Add HUION Kamvas Studio 16

PATCH New Tyron Govender 2 participants 2 messages Jun 7

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: panel-orientation-quirks: Add HUION Kamvas Studio 16

---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/gpu/drm/drm_panel_orientation_quirks.c +9 -0
index 3a218fb59..85203b140 100644
@@ -364,6 +364,15 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G1617-01")
 		},
 		.driver_data = (void *)&lcd1080x1920_rightside_up,
+	}, {	/*
+	 * HUION Kamvas Studio 16
+	 * DMI has "Kavmas" spelling error, matched intentionally here
+	 */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "HUION"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Kavmas Studio 16"),
+		},
+		.driver_data = (void *)&lcd2560x1440_bottom_up,
 	}, {	/* I.T.Works TW891 */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
Signature · 1 line
2.54.0
#1 lore raw
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Undeclared identifier `lcd2560x1440_bottom_up` causing a build failure. --

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Undeclared identifier lcd2560x1440_bottom_up causing a build failure. --

commit 532668bae9bf64a960a61fb91c8692d35f08f8e0
Author: Tyron Govender <[email protected]>

drm: panel-orientation-quirks: Add HUION Kamvas Studio 16

This commit adds a panel orientation quirk for the HUION Kamvas Studio 16. It intentionally matches a spelling error in the DMI product name and maps it to a bottom-up orientation for its 2560x1440 display.

Quoted 4 lines
drivers/gpu/drm/drm_panel_orientation_quirks.c +0 -0
index 3a218fb592cef..85203b1400095 100644

[ ... ]

drivers/gpu/drm/drm_panel_orientation_quirks.c static const struct dmi_system_id orientation_data[] = { · line 375

Quoted 13 lines
drivers/gpu/drm/drm_panel_orientation_quirks.c +9 -0
@@ -364,6 +364,15 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G1617-01")
 		},
 		.driver_data = (void *)&lcd1080x1920_rightside_up,
+	}, {	/*
+	 * HUION Kamvas Studio 16
+	 * DMI has "Kavmas" spelling error, matched intentionally here
+	 */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "HUION"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Kavmas Studio 16"),
+		},
+		.driver_data = (void *)&lcd2560x1440_bottom_up,

[Severity: Low]
Does this cause a build failure? The patch references lcd2560x1440_bottom_up here, but it appears the struct was never defined or declared.

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1