Skip to contentSkip to conversation

Add ipq5210 USB phy support

PATCH Applied Varadarajan Narayanan 3 participants 6 messages Jun 8 – Jun 11

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v2 cover Add ipq5210 USB phy support

The ipq5210 SoC has both USB2.0 and USB3.0 controllers. The USB3.0 can connect to either of USB2.0 or USB3.0 phy and operate in the respective mode.

v2: Use ipq6018 and ipq9574 as fallback compatibles for qusb2 and qmp
phys respectively instead of introducing ipq5210 as a new compatible.

Dropped driver changes as moved to fallback compatible.

Separate the controller and phy patches

v1: https://lore.kernel.org/linux-arm-msm/[email protected]/

Varadarajan Narayanan (2):
dt-bindings: phy: qcom,qusb2: Document IPQ5210 compatible
dt-bindings: phy: qcom,qmp-usb: Add ipq5210 USB3 PHY

 .../bindings/phy/qcom,qusb2-phy.yaml          |  4 ++
 .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml   | 46 +++++++++++--------
 2 files changed, 30 insertions(+), 20 deletions(-)
Signature · 1 line
2.34.1
#1 lore raw

PATCH v2 1/2 dt-bindings: phy: qcom,qusb2: Document IPQ5210 compatible

Document the QUSB2 PHY compatible for the IPQ5210 SoC. The IPQ5210 PHY is compatible with the IPQ6018 QUSB2 PHY, so allow it to use qcom,ipq6018-qusb2-phy as the fallback compatible.

---
 Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml +4 -0
index 39851ba9de43..449c2a7e5fec 100644
@@ -30,6 +30,10 @@ properties:
               - qcom,sdm660-qusb2-phy
               - qcom,sm4250-qusb2-phy
               - qcom,sm6115-qusb2-phy
+      - items:
+          - enum:
+              - qcom,ipq5210-qusb2-phy
+          - const: qcom,ipq6018-qusb2-phy
       - items:
           - enum:
               - qcom,sc7180-qusb2-phy
Signature · 1 line
2.34.1
Reviewed-by on v2 1/2
#2 lore raw

Re: [PATCH v2 1/2] dt-bindings: phy: qcom,qusb2: Document IPQ5210 compatible

Quoted 8 lines · Varadarajan Narayanan

Document the QUSB2 PHY compatible for the IPQ5210 SoC. The IPQ5210 PHY is compatible with the IPQ6018 QUSB2 PHY, so allow it to use qcom,ipq6018-qusb2-phy as the fallback compatible.

---
 Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml | 4 ++++
 1 file changed, 4 insertions(+)

Best regards,
Krzysztof

#3 lore raw

PATCH v2 2/2 dt-bindings: phy: qcom,qmp-usb: Add ipq5210 USB3 PHY

In reply to Varadarajan Narayanan

Add dt-bindings for the USB3 QMP PHY found on the Qualcomm IPQ5210 SoC. The IPQ5210 PHY is compatible with the IPQ9574 PHY, so add it as a fallback- compatible entry using a oneOf construct rather than a plain enum entry.

---
 .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml   | 46 +++++++++++--------
 1 file changed, 26 insertions(+), 20 deletions(-)
Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml +26 -20
index 623c2f8c7d22..01342823e57f 100644
@@ -15,26 +15,32 @@ description:
 
 properties:
   compatible:
-    enum:
-      - qcom,glymur-qmp-usb3-uni-phy
-      - qcom,ipq5424-qmp-usb3-phy
-      - qcom,ipq6018-qmp-usb3-phy
-      - qcom,ipq8074-qmp-usb3-phy
-      - qcom,ipq9574-qmp-usb3-phy
-      - qcom,msm8996-qmp-usb3-phy
-      - qcom,qcs8300-qmp-usb3-uni-phy
-      - qcom,qdu1000-qmp-usb3-uni-phy
-      - qcom,sa8775p-qmp-usb3-uni-phy
-      - qcom,sc8180x-qmp-usb3-uni-phy
-      - qcom,sc8280xp-qmp-usb3-uni-phy
-      - qcom,sdm845-qmp-usb3-uni-phy
-      - qcom,sdx55-qmp-usb3-uni-phy
-      - qcom,sdx65-qmp-usb3-uni-phy
-      - qcom,sdx75-qmp-usb3-uni-phy
-      - qcom,sm8150-qmp-usb3-uni-phy
-      - qcom,sm8250-qmp-usb3-uni-phy
-      - qcom,sm8350-qmp-usb3-uni-phy
-      - qcom,x1e80100-qmp-usb3-uni-phy
+    oneOf:
+      - items:
+          - enum:
+              - qcom,glymur-qmp-usb3-uni-phy
+              - qcom,ipq5424-qmp-usb3-phy
+              - qcom,ipq6018-qmp-usb3-phy
+              - qcom,ipq8074-qmp-usb3-phy
+              - qcom,ipq9574-qmp-usb3-phy
+              - qcom,msm8996-qmp-usb3-phy
+              - qcom,qcs8300-qmp-usb3-uni-phy
+              - qcom,qdu1000-qmp-usb3-uni-phy
+              - qcom,sa8775p-qmp-usb3-uni-phy
+              - qcom,sc8180x-qmp-usb3-uni-phy
+              - qcom,sc8280xp-qmp-usb3-uni-phy
+              - qcom,sdm845-qmp-usb3-uni-phy
+              - qcom,sdx55-qmp-usb3-uni-phy
+              - qcom,sdx65-qmp-usb3-uni-phy
+              - qcom,sdx75-qmp-usb3-uni-phy
+              - qcom,sm8150-qmp-usb3-uni-phy
+              - qcom,sm8250-qmp-usb3-uni-phy
+              - qcom,sm8350-qmp-usb3-uni-phy
+              - qcom,x1e80100-qmp-usb3-uni-phy
+      - items:
+          - enum:
+              - qcom,ipq5210-qmp-usb3-phy
+          - const: qcom,ipq9574-qmp-usb3-phy
 
   reg:
     maxItems: 1
Signature · 1 line
2.34.1
Reviewed-by on v2 2/2
#4 lore raw

Re: [PATCH v2 2/2] dt-bindings: phy: qcom,qmp-usb: Add ipq5210 USB3 PHY

Quoted 8 lines · Varadarajan Narayanan

Add dt-bindings for the USB3 QMP PHY found on the Qualcomm IPQ5210 SoC. The IPQ5210 PHY is compatible with the IPQ9574 PHY, so add it as a fallback- compatible entry using a oneOf construct rather than a plain enum entry.

---
 .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml   | 46 +++++++++++--------
 1 file changed, 26 insertions(+), 20 deletions(-)

Best regards,
Krzysztof

maintainer Applied
#5 lore raw
In reply to Varadarajan Narayanan
Quoted 8 lines · Varadarajan Narayanan

The ipq5210 SoC has both USB2.0 and USB3.0 controllers. The USB3.0 can connect to either of USB2.0 or USB3.0 phy and operate in the respective mode.

v2: Use ipq6018 and ipq9574 as fallback compatibles for qusb2 and qmp
phys respectively instead of introducing ipq5210 as a new compatible.

[...]

Applied, thanks!

[1/2] dt-bindings: phy: qcom,qusb2: Document IPQ5210 compatible

      commit: a9a9bae2174bbad63fc73a0d445b7437f63b2498
[2/2] dt-bindings: phy: qcom,qmp-usb: Add ipq5210 USB3 PHY
      commit: 609878c1b684ea3f77ab72237511eb9bec927102

Best regards,

Signature · 1 line
~Vinod