drivers/net/ethernet/emulex/benet: Use strscpy() to copy strings into arrays
Subsystems (3)
PATCH 1/1 drivers/net/ethernet/emulex/benet: Use strscpy() to copy strings into arrays
From: David Laight <[email protected]>
Replacing strcpy() with strscpy() ensures that overflow of the target buffer cannot happen.
---
This is one of a group of patches that remove potentially unbounded strcpy() calls.
They are mostly replaced by strscpy() or, when strlen() has just been called, with memcpy() (usually including the '\0').
Calls with copy string literals into arrays are left unchanged. They are safe and easily detected as such.
The changes were made by getting the compiler to detect the calls and then fixing the code by hand.
Note that all the changes are only compile tested.
Some Makefiles were changed to allow files to contain strcpy(). As well as 'difficult to fix' files, this included 'show' functions as they really need to use sysfs_emit() or seq_printf().
All the patches are being sent individually to avoid very long cc lists. Apologies for the terse commit messages and likely unexpected tags. (There are about 100 patches in total.)
drivers/net/ethernet/emulex/benet/be_cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/emulex/benet/be_cmds.c +1 -1
@@ -2508,7 +2508,7 @@ int lancer_cmd_read_object(struct be_adapter *adapter, struct be_dma_mem *cmd, req->desired_read_len =cpu_to_le32 (data_size); req->read_offset =cpu_to_le32 (data_offset); -strcpy (req->object_name, obj_name); +strscpy (req->object_name, obj_name); req->descriptor_count =cpu_to_le32 (1 ); req->buf_len =cpu_to_le32 (data_size); req->addr_low =cpu_to_le32 ((cmd->dma &0xFFFFFFFF ));
Signature · 1 line
2.39.5
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Mon, 8 Jun 2026 10:54:59 +0100 you wrote:
From: David Laight <[email protected]>
Replacing
strcpy()withstrscpy()ensures that overflow of the target buffer cannot happen.Signed-off-by David Laight <[email protected]>[...]
Here is the summary with links:
- [net-next] drivers/net/ethernet/emulex/benet: Use strscpy() to copy strings into arrays
https://git.kernel.org/netdev/net-next/c/9f9fdd88e9f6
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html