Skip to contentSkip to conversation

ARM: actions: Drop OF node references after mapping

PATCH New Yuho Choi 1 participant 1 message Jun 8

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/actions semi architecture
lore
Share & tools
lore

Yuho Choi

author
#0 lore raw

PATCH 1/1 ARM: actions: Drop OF node references after mapping

of_find_compatible_node() returns a device node with its reference count incremented. of_iomap() uses the node to map the register range, but does not consume that reference.

Drop the node references after mapping the timer, SPS and SCU registers in s500_smp_prepare_cpus().

Fixes 172067e0bc87 ("ARM: owl: Implement CPU enable-method for S500")
Fixes b6a0e18ca690 ("ARM: owl: smp: Implement SPS power-gating for CPU2 and CPU3")
Signed-off-by Yuho Choi <[email protected]>
---
 arch/arm/mach-actions/platsmp.c | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/mach-actions/platsmp.c +3 -0
index 7b208e96fbb6..a0d0c1621bd0 100644
@@ -105,6 +105,7 @@ static void __init s500_smp_prepare_cpus(unsigned int max_cpus)
 	}
 
 	timer_base_addr = of_iomap(node, 0);
+	of_node_put(node);
 	if (!timer_base_addr) {
 		pr_err("%s: could not map timer registers\n", __func__);
 		return;

@@ -117,6 +118,7 @@ static void __init s500_smp_prepare_cpus(unsigned int max_cpus)
 	}
 
 	sps_base_addr = of_iomap(node, 0);
+	of_node_put(node);
 	if (!sps_base_addr) {
 		pr_err("%s: could not map sps registers\n", __func__);
 		return;

@@ -130,6 +132,7 @@ static void __init s500_smp_prepare_cpus(unsigned int max_cpus)
 		}
 
 		scu_base_addr = of_iomap(node, 0);
+		of_node_put(node);
 		if (!scu_base_addr) {
 			pr_err("%s: could not map scu registers\n", __func__);
 			return;
Signature · 1 line
2.43.0