Skip to contentSkip to conversation

perf build: Respect V=1 for Python extension builds

PATCH Applied Jens Remus 3 participants 3 messages Jun 8 – Jun 10 perf events

lore
Share & tools
lore

Jens Remus

author
#0 lore raw

PATCH v2 1/1 perf build: Respect V=1 for Python extension builds

Make util/setup.py respect the verbose build flag (V=1) by conditionally passing --quiet only when not in verbose mode.

This eases debugging of Python extension compilation issues and aligns with the existing perf build system behavior.

---

Notes (jremus):
This patch applies on top of the perf-tools-next tree:

git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git master

Changes in v2:
- Rebase on perf-tools-next tree. (Ian)
- Use descriptive variable name python_setup_quiet. (Ian)

 tools/perf/Makefile.perf | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
tools/perf/Makefile.perf +6 -2
index 76b35ac19acb..137fc4386625 100644
@@ -401,6 +401,10 @@ export PYTHON_EXTBUILD_LIB PYTHON_EXTBUILD_TMP
 
 python-clean := $(call QUIET_CLEAN, python) $(RM) -r $(PYTHON_EXTBUILD) $(OUTPUT)python/perf*.so
 
+ifneq ($(quiet),)
+python_setup_quiet=--quiet
+endif
+
 # Use the detected configuration
 -include $(OUTPUT).config-detected
 
@@ -752,7 +756,7 @@ $(OUTPUT)python/perf$(PYTHON_EXTENSION_SUFFIX): util/python.c util/setup.py $(PE
 	$(QUIET_GEN)LDSHARED="$(CC) -pthread -shared" \
         CFLAGS='$(CFLAGS)' LDFLAGS='$(LDFLAGS) $(LIBS_PY)' \
 	  $(PYTHON_WORD) util/setup.py \
-	  --quiet build_ext; \
+	  $(python_setup_quiet) build_ext; \
 	cp $(PYTHON_EXTBUILD_LIB)perf*.so $(OUTPUT)python/
 
 python_perf_target:
@@ -1158,7 +1162,7 @@ install-bin: install-tools install-tests
 install: install-bin try-install-man
 
 install-python_ext:
-	$(PYTHON_WORD) util/setup.py --quiet install --root='/$(DESTDIR_SQ)'
+	$(PYTHON_WORD) util/setup.py $(python_setup_quiet) install --root='/$(DESTDIR_SQ)'
 
 # 'make install-doc' should call 'make -C Documentation install'
 $(INSTALL_DOC_TARGETS):
Signature · 1 line
2.53.0
reviewer Reviewed-by on v2 1/1
#1 lore raw
Quoted 9 lines · Jens Remus

Make util/setup.py respect the verbose build flag (V=1) by conditionally passing --quiet only when not in verbose mode.

This eases debugging of Python extension compilation issues and aligns with the existing perf build system behavior.

Thanks!
Ian

Quoted 50 lines

---

Notes (jremus):
This patch applies on top of the perf-tools-next tree:

git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git master

Changes in v2:
- Rebase on perf-tools-next tree. (Ian)
- Use descriptive variable name python_setup_quiet. (Ian)

 tools/perf/Makefile.perf | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
tools/perf/Makefile.perf +6 -3
index 76b35ac19acb..137fc4386625 100644
@@ -401,6 +401,10 @@ export PYTHON_EXTBUILD_LIB PYTHON_EXTBUILD_TMP
 
 python-clean := $(call QUIET_CLEAN, python) $(RM) -r $(PYTHON_EXTBUILD) $(OUTPUT)python/perf*.so
 
+ifneq ($(quiet),)
+python_setup_quiet=--quiet
+endif
+
 # Use the detected configuration
 -include $(OUTPUT).config-detected
 
@@ -752,7 +756,7 @@ $(OUTPUT)python/perf$(PYTHON_EXTENSION_SUFFIX): util/python.c util/setup.py $(PE
        $(QUIET_GEN)LDSHARED="$(CC) -pthread -shared" \
         CFLAGS='$(CFLAGS)' LDFLAGS='$(LDFLAGS) $(LIBS_PY)' \
          $(PYTHON_WORD) util/setup.py \
-         --quiet build_ext; \
+         $(python_setup_quiet) build_ext; \
        cp $(PYTHON_EXTBUILD_LIB)perf*.so $(OUTPUT)python/
 
 python_perf_target:
@@ -1158,7 +1162,7 @@ install-bin: install-tools install-tests
 install: install-bin try-install-man
 
 install-python_ext:
-       $(PYTHON_WORD) util/setup.py --quiet install --root='/$(DESTDIR_SQ)'
+       $(PYTHON_WORD) util/setup.py $(python_setup_quiet) install --root='/$(DESTDIR_SQ)'
 
 # 'make install-doc' should call 'make -C Documentation install'
 $(INSTALL_DOC_TARGETS):
--

2.53.0

maintainer Applied
#2 lore raw
Quoted 5 lines · Ian Rogers
Quoted 4 lines · Jens Remus

Make util/setup.py respect the verbose build flag (V=1) by conditionally passing --quiet only when not in verbose mode.

Quoted 7 lines
Quoted 5 lines

This eases debugging of Python extension compilation issues and aligns with the existing perf build system behavior.

Thanks, applied to perf-tools-next, for v7.2.

- Arnaldo