Skip to contentSkip to conversation

staging: sm750fb: make g_fbmode array const

PATCH In review Brock Haftner 2 participants 3 messages Jun 9 – Jun 10

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: sm750fb: make g_fbmode array const

The g_fbmode array is a static array of constant strings, but the pointer array itself is not marked as const. Fix the checkpatch.pl warning by adding the const modifier to the array declaration.

---
 drivers/staging/sm750fb/sm750.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm750fb/sm750.c +1 -1
index 89c811e0806c..8f533f3b1b42 100644
@@ -21,7 +21,7 @@
 static int g_hwcursor = 1;
 static int g_noaccel __ro_after_init;
 static int g_nomtrr __ro_after_init;
-static const char *g_fbmode[] = {NULL, NULL};
+static const char * const g_fbmode[] = {NULL, NULL};
 static const char *g_def_fbmode = "1024x768-32@60";
 static char *g_settings;
 static int g_dualview __ro_after_init;
Signature · 1 line
2.54.0
#1 lore raw
Quoted 14 lines · Brock Haftner

The g_fbmode array is a static array of constant strings, but the pointer array itself is not marked as const. Fix the checkpatch.pl warning by adding the const modifier to the array declaration.

---
  drivers/staging/sm750fb/sm750.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm750fb/sm750.c +0 -0
index 89c811e0806c..8f533f3b1b42 100644

drivers/staging/sm750fb/sm750.c line 27

Quoted 8 lines
drivers/staging/sm750fb/sm750.c +1 -1
@@ -21,7 +21,7 @@
  static int g_hwcursor = 1;
  static int g_noaccel __ro_after_init;
  static int g_nomtrr __ro_after_init;
-static const char *g_fbmode[] = {NULL, NULL};
+static const char * const g_fbmode[] = {NULL, NULL};
  static const char *g_def_fbmode = "1024x768-32@60";
  static char *g_settings;
  static int g_dualview __ro_after_init;

Did you compile this patch while enabling sm750fb driver in the config?

Regards,
Ahmet Sezgin Duran

#2 lore raw
Quoted 1 line · Ahmet Sezgin Duran

Did you compile this patch while enabling sm750fb driver in the config?

No, I did not. I apologize for the mistake.
I ran make drivers/staging/sm750fb/ prior to submitting, however I failed to realize the driver was not enabled in my .config.

Cheers,
Brock