staging: sm750fb: make g_fbmode array const
PATCH 1/1 staging: sm750fb: make g_fbmode array const
The g_fbmode array is a static array of constant strings, but the pointer array itself is not marked as const. Fix the checkpatch.pl warning by adding the const modifier to the array declaration.
--- drivers/staging/sm750fb/sm750.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm750fb/sm750.c +1 -1
@@ -21,7 +21,7 @@static int g_hwcursor =1 ;static int g_noaccel__ro_after_init ;static int g_nomtrr__ro_after_init ; -static const char *g_fbmode[] = {NULL ,NULL }; +static const char *const g_fbmode[] = {NULL ,NULL };static const char *g_def_fbmode ="1024x768-32@60" ;static char *g_settings;static int g_dualview__ro_after_init ;
Signature · 1 line
2.54.0
Quoted 14 lines · Brock Haftner
The
g_fbmodearray is a static array of constant strings, but the pointer array itself is not marked as const. Fix the checkpatch.pl warning by adding the const modifier to the array declaration.Signed-off-by Brock Haftner <[email protected]>--- drivers/staging/sm750fb/sm750.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/sm750fb/sm750.c +0
-0
drivers/staging/sm750fb/sm750.c line 27
Quoted 8 lines
drivers/staging/sm750fb/sm750.c +1
-1@@ -21,7 +21,7 @@static int g_hwcursor =1 ;static int g_noaccel__ro_after_init ;static int g_nomtrr__ro_after_init ; -static const char *g_fbmode[] = {NULL ,NULL }; +static const char *const g_fbmode[] = {NULL ,NULL };static const char *g_def_fbmode ="1024x768-32@60" ;static char *g_settings;static int g_dualview__ro_after_init ;
Did you compile this patch while enabling sm750fb driver in the config?
Regards,
Ahmet Sezgin Duran
Quoted 1 line · Ahmet Sezgin Duran
Did you compile this patch while enabling sm750fb driver in the config?
No, I did not. I apologize for the mistake.
I ran make drivers/staging/sm750fb/ prior to submitting, however I failed to realize the driver was not enabled in my .config.
Cheers,
Brock