Skip to contentSkip to conversation

power: domain: scmi: Allow failure in getting power domain attribute

PATCH In review Ye Li 2 participants 2 messages Jun 9

lore
Share & tools
lore

Ye Li

author
#0 lore raw

PATCH 1/1 power: domain: scmi: Allow failure in getting power domain attribute

When one power domain fails to get attribute, continue getting attribute for remaining power domains, not return probe failure. So other power domains are still functional.
It is possible that one power domain is assigned to other agent or this power domain is disabled by HW fuse, so platform returns denied or other error.

---
 drivers/power/domain/scmi-power-domain.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
drivers/power/domain/scmi-power-domain.c +1 -7
index e8c0ba8878e..c87f484325e 100644
@@ -165,15 +165,9 @@ static int scmi_power_domain_probe(struct udevice *dev)
 	for (i = 0; i < priv->num_pwdoms; i++) {
 		ret = scmi_pwd_attrs(dev, i, &priv->prop[i].attributes,
 				     &priv->prop[i].name);
-		if (ret) {
+		if (ret)
 			dev_err(dev, "failed to get attributes pwd:%d (%d)\n",
 				i, ret);
-			for (i--; i >= 0; i--)
-				free(priv->prop[i].name);
-			free(priv->prop);
-
-			return ret;
-		}
 	}
 
 	return 0;
Signature · 1 line
2.50.1
Reviewed-by Peng Fan on v1 1/1
#1 lore raw
Quoted 11 lines

Subject: [PATCH] power: domain: scmi: Allow failure in getting power domain attribute

When one power domain fails to get attribute, continue getting attribute for remaining power domains, not return probe failure. So other power domains are still functional.
It is possible that one power domain is assigned to other agent or this power domain is disabled by HW fuse, so platform returns denied or other error.