gpio: zynq: fix runtime PM leak on remove
Subsystems (3)
PATCH 1/1 gpio: zynq: fix runtime PM leak on remove
pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error. zynq_gpio_remove() uses it to keep the controller active while removing the GPIO chip, but never drops the usage counter again.
Balance the get with pm_runtime_put_noidle() after disabling runtime PM.
--- drivers/gpio/gpio-zynq.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpio/gpio-zynq.c +1 -0
@@ -1014,6 +1014,7 @@ static void zynq_gpio_remove(struct platform_device *pdev)gpiochip_remove (&gpio->chip);device_set_wakeup_capable (&pdev->dev,0 );pm_runtime_disable (&pdev->dev); +pm_runtime_put_noidle (&pdev->dev); }static struct platform_driver zynq_gpio_driver = {
Signature · 1 line
2.51.0
Bartosz Golaszewski
AppliedQuoted 8 lines · Ruoyu Wang
pm_runtime_get_sync()increments the runtime PM usage counter even when it returns an error.zynq_gpio_remove()uses it to keep the controller active while removing the GPIO chip, but never drops the usage counter again.Balance the get with
pm_runtime_put_noidle()after disabling runtime PM.[...]
Applied, thanks!
[1/1] gpio: zynq: fix runtime PM leak on remove
https://git.kernel.org/brgl/c/6edb934de9bda3b7abcec856eaee6fc8b4278dd1
Best regards,
Signature · 1 line
Bartosz Golaszewski <[email protected]>
Quoted 8 lines
pm_runtime_get_sync()increments the runtime PM usage counter even when it returns an error.zynq_gpio_remove()uses it to keep the controller active while removing the GPIO chip, but never drops the usage counter again.Balance the get with
pm_runtime_put_noidle()after disabling runtime PM.Fixes 3242ba117e9b ("gpio: Add driver for Zynq GPIO controller")Signed-off-by Ruoyu Wang <[email protected]>
Thanks!
Quoted 16 lines
--- drivers/gpio/gpio-zynq.c | 1 + 1 file changed, 1 insertion(+)drivers/gpio/gpio-zynq.c +1
-0@@ -1014,6 +1014,7 @@ static void zynq_gpio_remove(struct platform_device *pdev)gpiochip_remove (&gpio->chip);device_set_wakeup_capable (&pdev->dev,0 );pm_runtime_disable (&pdev->dev); +pm_runtime_put_noidle (&pdev->dev); }static struct platform_driver zynq_gpio_driver = {