Skip to contentSkip to conversation

arm64: dts: rockchip: fix emmc reset polarity on px30-cobra

PATCH Applied Jakob Unterwurzacher 3 participants 4 messages Jun 9 – Jun 28

Subsystems (3)
Stable branch Device tree bindings Arm Rockchip
lore
Share & tools
lore

Jakob Unterwurzacher

author
#0 lore raw

PATCH v2 1/1 arm64: dts: rockchip: fix emmc reset polarity on px30-cobra

From: Jakob Unterwurzacher <[email protected]>

Technically, the reset signal is active low - it's called RST_n after all.

But it is ignored completely unless RST_n_FUNCTION=1 (byte 162 in extcsd) is set in the emmc. It is 0 per default.

For emmcs that have RST_n_FUNCTION=1 we failed like this:

	[    3.074480] mmc1: Failed to initialize a non-removable card

With this change they work normally.

Cc [email protected]
Fixes bb510ddc9d3e ("arm64: dts: rockchip: add px30-cobra base dtsi and board variants")
Signed-off-by Jakob Unterwurzacher <[email protected]>

---
v2: Add correct "From: " line

 arch/arm64/boot/dts/rockchip/px30-cobra.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/px30-cobra.dtsi +1 -1
index b7e669d8ba4d..90751b04f95c 100644
@@ -35,7 +35,7 @@ emmc_pwrseq: emmc-pwrseq {
 		compatible = "mmc-pwrseq-emmc";
 		pinctrl-0 = <&emmc_reset>;
 		pinctrl-names = "default";
-		reset-gpios = <&gpio1 RK_PB3 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&gpio1 RK_PB3 GPIO_ACTIVE_LOW>;
 	};
 
 	gpio-leds {
Signature · 1 line
2.47.3
Reviewed-by on v2 1/1
#1 lore raw

Hi Jakob,

Quoted 9 lines · Jakob Unterwurzacher

From: Jakob Unterwurzacher <[email protected]>

Technically, the reset signal is active low - it's called RST_n after all.

But it is ignored completely unless RST_n_FUNCTION=1 (byte 162 in extcsd) is set in the emmc. It is 0 per default.

For emmcs that have RST_n_FUNCTION=1 we failed like this:

Quoted 7 lines
	[    3.074480] mmc1: Failed to initialize a non-removable card

With this change they work normally.

Cc [email protected]
Fixes bb510ddc9d3e ("arm64: dts: rockchip: add px30-cobra base dtsi and board variants")
Signed-off-by Jakob Unterwurzacher <[email protected]>

Please try to not forget to add tags (Reviewed-by, Acked-by, Tested-by, ...) given in earlier versions of a newer version of the patch (except if substantial changes were made, which isn't the case here).

Reviewed-by Quentin Schulz <[email protected]>

Thanks!
Quentin

Tested-by on v2 1/1
#2 lore raw
In reply to Jakob Unterwurzacher

Hi Jakob,

Quoted 7 lines · Jakob Unterwurzacher

From: Jakob Unterwurzacher <[email protected]>

Technically, the reset signal is active low - it's called RST_n after all.

But it is ignored completely unless RST_n_FUNCTION=1 (byte 162 in extcsd) is set in the emmc. It is 0 per default.

Quoted 8 lines

For emmcs that have RST_n_FUNCTION=1 we failed like this:

	[    3.074480] mmc1: Failed to initialize a non-removable card

With this change they work normally.

Cc [email protected]
Fixes bb510ddc9d3e ("arm64: dts: rockchip: add px30-cobra base dtsi and board variants")
Tested-by Quentin Schulz <[email protected]>

Thanks!
Quentin

maintainer Applied
#3 lore raw
In reply to Jakob Unterwurzacher
Quoted 8 lines · Jakob Unterwurzacher

Technically, the reset signal is active low - it's called RST_n after all.

But it is ignored completely unless RST_n_FUNCTION=1 (byte 162 in extcsd) is set in the emmc. It is 0 per default.

For emmcs that have RST_n_FUNCTION=1 we failed like this:

[...]

Applied, thanks!

[1/1] arm64: dts: rockchip: fix emmc reset polarity on px30-cobra

      commit: 85babf47515e2adf266dcc3be9804e31f752083e

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>