Skip to contentSkip to conversation

iomap: pass the correct len to fserror_report_io in __iomap_write_begin

PATCH Applied Christoph Hellwig 3 participants 3 messages Jun 10

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iomap: pass the correct len to fserror_report_io in __iomap_write_begin

len is size of the (larger) write request, plen is the range for which the read failed here.

Fixes a9d573ee88af ("iomap: report file I/O errors to the VFS")
---
 fs/iomap/buffered-io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/iomap/buffered-io.c +1 -1
index d7b648421a70..bcf4559e9aa7 100644
@@ -850,7 +850,7 @@ static int __iomap_write_begin(const struct iomap_iter *iter,
 			if (status < 0)
 				fserror_report_io(iter->inode,
 						  FSERR_BUFFERED_READ, pos,
-						  len, status, GFP_NOFS);
+						  plen, status, GFP_NOFS);
 			if (status)
 				return status;
 		}
Signature · 1 line
2.53.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Christoph Hellwig

len is size of the (larger) write request, plen is the range for which the read failed here.

Fixes a9d573ee88af ("iomap: report file I/O errors to the VFS")

Sorry about screwing that up.

--D

Quoted 21 lines
---
 fs/iomap/buffered-io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/iomap/buffered-io.c +1 -1
index d7b648421a70..bcf4559e9aa7 100644
@@ -850,7 +850,7 @@ static int __iomap_write_begin(const struct iomap_iter *iter,
 			if (status < 0)
 				fserror_report_io(iter->inode,
 						  FSERR_BUFFERED_READ, pos,
-						  len, status, GFP_NOFS);
+						  plen, status, GFP_NOFS);
 			if (status)
 				return status;
 		}
Signature · 1 line
2.53.0
maintainer Applied
#2 lore raw
In reply to Christoph Hellwig
Quoted 2 lines · Christoph Hellwig

len is size of the (larger) write request, plen is the range for which the read failed here.

Applied to the vfs-7.2.misc branch of the vfs/vfs.git tree. Patches in the vfs-7.2.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-7.2.misc

[1/1] iomap: pass the correct len to fserror_report_io in __iomap_write_begin

      https://git.kernel.org/vfs/vfs/c/de654d66ff30