Skip to contentSkip to conversation

Remove deprecated Power8E and 8NVL CPUs

PATCH In review Aditya Gupta 3 participants 13 messages Jun 10 – Jun 12

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Remove deprecated Power8E and 8NVL CPUs

Overview
========

Power8E and Power8NVL were deprecated since QEMU 10.1, with commit 264a604e7163 ("target/ppc: Deprecate Power8E and Power8NVL")

Hence, remove usage (chip and core types) of Power8E and 8NVL from PowerNV, PSeries as well as testcases.

NOTE: PRE-REQUISITE: Requires following "Testcase improvements for PowerNV" to be merged first:

https://lore.kernel.org/qemu-devel/[email protected]/T/#t

Aditya Gupta (4):
ppc/pnv: Replace Power8E with Power11 for 'none' machine test ppc/pnv: Remove Power8E and Power8NVL pnv chips ppc/pnv: Remove Power8E and Power8NVL spapr cores ppc/pnv: Remove Power8E and Power8NVL CPUs

 docs/about/deprecated.rst       |  9 -----
 docs/system/ppc/powernv.rst     |  2 +-
 docs/system/ppc/pseries.rst     |  2 +-
 hw/ppc/pnv.c                    | 62 ---------------------------------
 hw/ppc/pnv_core.c               |  2 --
 hw/ppc/spapr_cpu_core.c         |  2 --
 include/hw/ppc/pnv.h            |  8 -----
 target/ppc/cpu-models.c         |  6 ----
 target/ppc/cpu-models.h         |  4 ---
 target/ppc/cpu_init.c           |  6 ----
 target/ppc/kvm.c                |  4 +--
 tests/qtest/machine-none-test.c |  2 +-
 tests/qtest/pnv-xscom.h         |  9 -----
 13 files changed, 4 insertions(+), 114 deletions(-)

base-commit: de5d8bfd6105d3dd3ae668df9762df244a6d1506

Signature · 1 line
2.54.0
#1 lore raw

PATCH 1/4 ppc/pnv: Replace Power8E with Power11 for 'none' machine test

Power8E and Power8NVL were deprecated since QEMU 10.1, with commit 264a604e7163 ("target/ppc: Deprecate Power8E and Power8NVL")

As Power8E chip is removed in future commits, remove the use of Power8E chip for use with the none machine test, and replace with Power11 for ppc64 test coverage for the test

---
 tests/qtest/machine-none-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/qtest/machine-none-test.c +1 -1
index bafd7d660ec7..3205df190f35 100644
@@ -38,7 +38,7 @@ static struct arch2cpu cpus_map[] = {
     { "mips64el", "I6500" },
     { "or1k", "or1200" },
     { "ppc", "604" },
-    { "ppc64", "power8e_v2.1" },
+    { "ppc64", "power11_v2.0" },
     { "s390x", "qemu" },
     { "sh4", "sh7750r" },
     { "sh4eb", "sh7751r" },
Signature · 1 line
2.54.0
#2 lore raw

Re: [PATCH 1/4] ppc/pnv: Replace Power8E with Power11 for 'none' machine test

Quoted 6 lines · Aditya Gupta via Devel

Power8E and Power8NVL were deprecated since QEMU 10.1, with commit 264a604e7163 ("target/ppc: Deprecate Power8E and Power8NVL")

As Power8E chip is removed in future commits, remove the use of Power8E chip for use with the none machine test, and replace with Power11 for ppc64 test coverage for the test

yes It's better to be in sync with the default pnv and spapr cpus. power8e was hardly never used even in 2016.

C.

Quoted 19 lines
---
  tests/qtest/machine-none-test.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
tests/qtest/machine-none-test.c +1 -1
index bafd7d660ec7..3205df190f35 100644
@@ -38,7 +38,7 @@ static struct arch2cpu cpus_map[] = {
      { "mips64el", "I6500" },
      { "or1k", "or1200" },
      { "ppc", "604" },
-    { "ppc64", "power8e_v2.1" },
+    { "ppc64", "power11_v2.0" },
      { "s390x", "qemu" },
      { "sh4", "sh7750r" },
      { "sh4eb", "sh7751r" },
#3 lore raw

PATCH 2/4 ppc/pnv: Remove Power8E and Power8NVL pnv chips

In reply to Aditya Gupta

Power8E and Power8NVL were deprecated since QEMU 10.1, with commit 264a604e7163 ("target/ppc: Deprecate Power8E and Power8NVL")

Accordingly, remove usage of 8E and 8NVL chips from powernv, as it's old and unmaintained now.

---
 docs/system/ppc/powernv.rst |  2 +-
 hw/ppc/pnv.c                | 62 -------------------------------------
 hw/ppc/pnv_core.c           |  2 --
 include/hw/ppc/pnv.h        |  8 -----
 tests/qtest/pnv-xscom.h     |  9 ------
 5 files changed, 1 insertion(+), 82 deletions(-)
docs/system/ppc/powernv.rst +1 -1
index 5154794cc8cd..1de696b588a8 100644
@@ -15,7 +15,7 @@ beyond the scope of what QEMU addresses today.
 Supported devices
 -----------------
 
- * Multi processor support for POWER8, POWER8NVL, POWER9, Power10 and Power11.
+ * Multi processor support for POWER8, POWER9, Power10 and Power11.
  * XSCOM, serial communication sideband bus to configure chiplets.
  * Simple LPC Controller.
  * Processor Service Interface (PSI) Controller.
hw/ppc/pnv.c +0 -62

92 lines not on this page · raw message

hw/ppc/pnv_core.c +0 -2
index 8939515c2c34..61dc8211e32f 100644
@@ -515,9 +515,7 @@ static const TypeInfo pnv_core_infos[] = {
         .class_init = pnv_core_class_init,
         .abstract       = true,
     },
-    DEFINE_PNV_CORE_TYPE(power8, "power8e_v2.1"),
     DEFINE_PNV_CORE_TYPE(power8, "power8_v2.0"),
-    DEFINE_PNV_CORE_TYPE(power8, "power8nvl_v1.0"),
     DEFINE_PNV_CORE_TYPE(power9, "power9_v2.2"),
     DEFINE_PNV_CORE_TYPE(power10, "power10_v2.0"),
     DEFINE_PNV_CORE_TYPE(power11, "power11_v2.0"),
include/hw/ppc/pnv.h +0 -8
index f8234fb3cd31..60e902d9c5bb 100644
@@ -39,18 +39,10 @@ typedef struct Pnv10Chip Pnv11Chip;
 #define PNV_CHIP_TYPE_SUFFIX "-" TYPE_PNV_CHIP
 #define PNV_CHIP_TYPE_NAME(cpu_model) cpu_model PNV_CHIP_TYPE_SUFFIX
 
-#define TYPE_PNV_CHIP_POWER8E PNV_CHIP_TYPE_NAME("power8e_v2.1")
-DECLARE_INSTANCE_CHECKER(PnvChip, PNV_CHIP_POWER8E,
-                         TYPE_PNV_CHIP_POWER8E)
-
 #define TYPE_PNV_CHIP_POWER8 PNV_CHIP_TYPE_NAME("power8_v2.0")
 DECLARE_INSTANCE_CHECKER(PnvChip, PNV_CHIP_POWER8,
                          TYPE_PNV_CHIP_POWER8)
 
-#define TYPE_PNV_CHIP_POWER8NVL PNV_CHIP_TYPE_NAME("power8nvl_v1.0")
-DECLARE_INSTANCE_CHECKER(PnvChip, PNV_CHIP_POWER8NVL,
-                         TYPE_PNV_CHIP_POWER8NVL)
-
 #define TYPE_PNV_CHIP_POWER9 PNV_CHIP_TYPE_NAME("power9_v2.2")
 DECLARE_INSTANCE_CHECKER(PnvChip, PNV_CHIP_POWER9,
                          TYPE_PNV_CHIP_POWER9)
tests/qtest/pnv-xscom.h +0 -9
index 5aa1701ea768..ddd6e1953ce4 100644
@@ -12,9 +12,7 @@
 #define SMT                     4 /* some tests will break if less than 4 */
 
 typedef enum PnvChipType {
-    PNV_CHIP_POWER8E,     /* AKA Murano (default) */
     PNV_CHIP_POWER8,      /* AKA Venice */
-    PNV_CHIP_POWER8NVL,   /* AKA Naples */
     PNV_CHIP_POWER9,      /* AKA Nimbus */
     PNV_CHIP_POWER10,
 } PnvChipType;
@@ -36,13 +34,6 @@ static const PnvChip pnv_chips[] = {
         .cfam_id    = 0x220ea04980000000ull,
         .first_core = 0x1,
         .num_i2c    = 0,
-    }, {
-        .chip_type  = PNV_CHIP_POWER8NVL,
-        .cpu_model  = "POWER8NVL",
-        .xscom_base = 0x0003fc0000000000ull,
-        .cfam_id    = 0x120d304980000000ull,
-        .first_core = 0x1,
-        .num_i2c    = 0,
     },
     {
         .chip_type  = PNV_CHIP_POWER9,
Signature · 1 line
2.54.0
Reviewed-by on v1 2/4
#4 lore raw

Re: [PATCH 2/4] ppc/pnv: Remove Power8E and Power8NVL pnv chips

Quoted 6 lines · Aditya Gupta

Power8E and Power8NVL were deprecated since QEMU 10.1, with commit 264a604e7163 ("target/ppc: Deprecate Power8E and Power8NVL")

Accordingly, remove usage of 8E and 8NVL chips from powernv, as it's old and unmaintained now.

Quoted 8 lines
---
  docs/system/ppc/powernv.rst |  2 +-
  hw/ppc/pnv.c                | 62 -------------------------------------
  hw/ppc/pnv_core.c           |  2 --
  include/hw/ppc/pnv.h        |  8 -----
  tests/qtest/pnv-xscom.h     |  9 ------
  5 files changed, 1 insertion(+), 82 deletions(-)
#5 lore raw

PATCH 3/4 ppc/pnv: Remove Power8E and Power8NVL spapr cores

In reply to Aditya Gupta

Power8E and Power8NVL were deprecated since QEMU 10.1, with commit 264a604e7163 ("target/ppc: Deprecate Power8E and Power8NVL")

Remove the corresponding 8E and 8NVL CPU cores from spapr/pseries

---
 docs/system/ppc/pseries.rst | 2 +-
 hw/ppc/spapr_cpu_core.c     | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)
docs/system/ppc/pseries.rst +1 -1
index bbc51aa7fcdb..1477028bc5ea 100644
@@ -16,7 +16,7 @@ Supported devices
 
  * Multi processor support for many Power processors generations:
    - POWER7, POWER7+
-   - POWER8, POWER8NVL
+   - POWER8
    - POWER9
    - Power10
    - Power11
hw/ppc/spapr_cpu_core.c +0 -2
index 41e37103c043..9a9351991c95 100644
@@ -408,8 +408,6 @@ static const TypeInfo spapr_cpu_core_type_infos[] = {
     DEFINE_SPAPR_CPU_CORE_TYPE("power7_v2.3"),
     DEFINE_SPAPR_CPU_CORE_TYPE("power7p_v2.1"),
     DEFINE_SPAPR_CPU_CORE_TYPE("power8_v2.0"),
-    DEFINE_SPAPR_CPU_CORE_TYPE("power8e_v2.1"),
-    DEFINE_SPAPR_CPU_CORE_TYPE("power8nvl_v1.0"),
     DEFINE_SPAPR_CPU_CORE_TYPE("power9_v2.0"),
     DEFINE_SPAPR_CPU_CORE_TYPE("power9_v2.2"),
     DEFINE_SPAPR_CPU_CORE_TYPE("power10_v2.0"),
Signature · 1 line
2.54.0
#6 lore raw

Re: [PATCH 3/4] ppc/pnv: Remove Power8E and Power8NVL spapr cores

Quoted 10 lines · Aditya Gupta

Power8E and Power8NVL were deprecated since QEMU 10.1, with commit 264a604e7163 ("target/ppc: Deprecate Power8E and Power8NVL")

Remove the corresponding 8E and 8NVL CPU cores from spapr/pseries

---
  docs/system/ppc/pseries.rst | 2 +-
  hw/ppc/spapr_cpu_core.c     | 2 --
  2 files changed, 1 insertion(+), 3 deletions(-)

Squash with following?

#7 lore raw

Re: [PATCH 3/4] ppc/pnv: Remove Power8E and Power8NVL spapr cores

Quoted 6 lines · Philippe Mathieu-Daudé
Quoted 5 lines · Aditya Gupta

Power8E and Power8NVL were deprecated since QEMU 10.1, with commit 264a604e7163 ("target/ppc: Deprecate Power8E and Power8NVL")

Remove the corresponding 8E and 8NVL CPU cores from spapr/pseries

Quoted 8 lines
Quoted 5 lines

---
  docs/system/ppc/pseries.rst | 2 +-
  hw/ppc/spapr_cpu_core.c     | 2 --

  2 files changed, 1 insertion(+), 3 deletions(-)

Squash with following?

Sure, you mean squash into patch #4, the target/ppc change ?

Thanks for reviewing !

- Aditya G

#8 lore raw

Re: [PATCH 3/4] ppc/pnv: Remove Power8E and Power8NVL spapr cores

Quoted 14 lines · Aditya Gupta
Quoted 12 lines · Philippe Mathieu-Daudé
Quoted 10 lines · Aditya Gupta

Power8E and Power8NVL were deprecated since QEMU 10.1, with commit 264a604e7163 ("target/ppc: Deprecate Power8E and Power8NVL")

Remove the corresponding 8E and 8NVL CPU cores from spapr/pseries

---
  docs/system/ppc/pseries.rst | 2 +-
  hw/ppc/spapr_cpu_core.c     | 2 --

  2 files changed, 1 insertion(+), 3 deletions(-)
Quoted 3 lines
Quoted 2 lines

Squash with following?

Sure, you mean squash into patch #4, the target/ppc change ?

Yes.

Quoted 1 line

Thanks for reviewing !

;)

#9 lore raw

PATCH 4/4 ppc/pnv: Remove Power8E and Power8NVL CPUs

In reply to Aditya Gupta

Power8E and Power8NVL were deprecated since QEMU 10.1, with commit 264a604e7163 ("target/ppc: Deprecate Power8E and Power8NVL")

With no use of 8E and 8NVL, in powernv chips or spapr cores, remove the CPU definitions for the cores

---
 docs/about/deprecated.rst | 9 ---------
 target/ppc/cpu-models.c   | 6 ------
 target/ppc/cpu-models.h   | 4 ----
 target/ppc/cpu_init.c     | 6 ------
 target/ppc/kvm.c          | 4 +---
 5 files changed, 1 insertion(+), 28 deletions(-)
docs/about/deprecated.rst +0 -9
index 97750f5edc91..3930ef08ed4b 100644
@@ -215,15 +215,6 @@ embedded 405 for power management (OCC) and other internal tasks, it
 is theoretically possible to use QEMU to model them. Let's keep the
 CPU implementation for a while before removing all support.
 
-Power8E and Power8NVL CPUs and corresponding Pnv chips (since 10.1)
-'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
-
-The Power8E and Power8NVL variants of Power8 are not really useful anymore
-in qemu, and are old and unmaintained now.
-
-The CPUs as well as corresponding Power8NVL and Power8E PnvChips will also
-be considered deprecated.
-
 System emulator machines
 ------------------------
 
target/ppc/cpu-models.c +0 -6
index 26b6debcfc96..aa13654e83e8 100644
@@ -734,12 +734,8 @@
                 "POWER7 v2.3")
     POWERPC_DEF("power7p_v2.1",  CPU_POWERPC_POWER7P_v21,            POWER7,
                 "POWER7+ v2.1")
-    POWERPC_DEPRECATED_CPU("power8e_v2.1",  CPU_POWERPC_POWER8E_v21, POWER8,
-                "POWER8E v2.1", "CPU is unmaintained.")
     POWERPC_DEF("power8_v2.0",   CPU_POWERPC_POWER8_v20,             POWER8,
                 "POWER8 v2.0")
-    POWERPC_DEPRECATED_CPU("power8nvl_v1.0", CPU_POWERPC_POWER8NVL_v10, POWER8,
-                "POWER8NVL v1.0", "CPU is unmaintained.")
     POWERPC_DEF("power9_v2.0",   CPU_POWERPC_POWER9_DD20,            POWER9,
                 "POWER9 v2.0")
     POWERPC_DEF("power9_v2.2",   CPU_POWERPC_POWER9_DD22,            POWER9,
@@ -918,9 +914,7 @@ PowerPCCPUAlias ppc_cpu_aliases[] = {
     { "power7", "power7_v2.3" },
     { "power7+", "power7p_v2.1" },
     { "power7+_v2.1", "power7p_v2.1" },
-    { "power8e", "power8e_v2.1" },
     { "power8", "power8_v2.0" },
-    { "power8nvl", "power8nvl_v1.0" },
     { "power9", "power9_v2.2" },
     { "power10", "power10_v2.0" },
     { "power11", "power11_v2.0" },
target/ppc/cpu-models.h +0 -4
index a439eb37ee41..ef019cdb1f3c 100644
@@ -341,12 +341,8 @@ enum {
     CPU_POWERPC_POWER7_v23         = 0x003F0203,
     CPU_POWERPC_POWER7P_BASE       = 0x004A0000,
     CPU_POWERPC_POWER7P_v21        = 0x004A0201,
-    CPU_POWERPC_POWER8E_BASE       = 0x004B0000,
-    CPU_POWERPC_POWER8E_v21        = 0x004B0201,
     CPU_POWERPC_POWER8_BASE        = 0x004D0000,
     CPU_POWERPC_POWER8_v20         = 0x004D0200,
-    CPU_POWERPC_POWER8NVL_BASE     = 0x004C0000,
-    CPU_POWERPC_POWER8NVL_v10      = 0x004C0100,
     CPU_POWERPC_POWER9_BASE        = 0x004E0000,
     CPU_POWERPC_POWER9_DD1         = 0x004E1100,
     CPU_POWERPC_POWER9_DD20        = 0x004E1200,
target/ppc/cpu_init.c +0 -6
index d25f69f13ba5..87186ec32179 100644
@@ -6310,12 +6310,6 @@ static bool ppc_pvr_match_power8(PowerPCCPUClass *pcc, uint32_t pvr, bool best)
         if (base == CPU_POWERPC_POWER8_BASE) {
             return true;
         }
-        if (base == CPU_POWERPC_POWER8E_BASE) {
-            return true;
-        }
-        if (base == CPU_POWERPC_POWER8NVL_BASE) {
-            return true;
-        }
     }
     if (base != pcc_base) {
         return false;
target/ppc/kvm.c +1 -3
index b94c2997a07f..78a1c4a8393e 100644
@@ -2437,9 +2437,7 @@ static bool kvmppc_power8_host(void)
 #ifdef TARGET_PPC64
     {
         uint32_t base_pvr = CPU_POWERPC_POWER_SERVER_MASK & mfpvr();
-        ret = (base_pvr == CPU_POWERPC_POWER8E_BASE) ||
-              (base_pvr == CPU_POWERPC_POWER8NVL_BASE) ||
-              (base_pvr == CPU_POWERPC_POWER8_BASE);
+        ret = (base_pvr == CPU_POWERPC_POWER8_BASE);
     }
 #endif /* TARGET_PPC64 */
     return ret;
Signature · 1 line
2.54.0
Reviewed-by on v1 4/4
#10 lore raw

Re: [PATCH 4/4] ppc/pnv: Remove Power8E and Power8NVL CPUs

Quoted 6 lines · Aditya Gupta

Power8E and Power8NVL were deprecated since QEMU 10.1, with commit 264a604e7163 ("target/ppc: Deprecate Power8E and Power8NVL")

With no use of 8E and 8NVL, in powernv chips or spapr cores, remove the CPU definitions for the cores

Quoted 8 lines
---
  docs/about/deprecated.rst | 9 ---------
  target/ppc/cpu-models.c   | 6 ------
  target/ppc/cpu-models.h   | 4 ----
  target/ppc/cpu_init.c     | 6 ------
  target/ppc/kvm.c          | 4 +---
  5 files changed, 1 insertion(+), 28 deletions(-)
#11 lore raw

Re: [PATCH 4/4] ppc/pnv: Remove Power8E and Power8NVL CPUs

In reply to Aditya Gupta
Quoted 22 lines · Aditya Gupta via Devel

Power8E and Power8NVL were deprecated since QEMU 10.1, with commit 264a604e7163 ("target/ppc: Deprecate Power8E and Power8NVL")

With no use of 8E and 8NVL, in powernv chips or spapr cores, remove the CPU definitions for the cores

---
  docs/about/deprecated.rst | 9 ---------
  target/ppc/cpu-models.c   | 6 ------
  target/ppc/cpu-models.h   | 4 ----
  target/ppc/cpu_init.c     | 6 ------
  target/ppc/kvm.c          | 4 +---
  5 files changed, 1 insertion(+), 28 deletions(-)
docs/about/deprecated.rst +0 -0
index 97750f5edc91..3930ef08ed4b 100644
@@ -215,15 +215,6 @@ embedded 405 for power management (OCC) and other internal tasks, it
  is theoretically possible to use QEMU to model them. Let's keep the
  CPU implementation for a while before removing all support.

docs/about/deprecated.rst embedded 405 for power management (OCC) and other internal tasks, it · line 226

Quoted 10 lines
docs/about/deprecated.rst +0 -9
 
-Power8E and Power8NVL CPUs and corresponding Pnv chips (since 10.1)
-'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
-
-The Power8E and Power8NVL variants of Power8 are not really useful anymore
-in qemu, and are old and unmaintained now.
-
-The CPUs as well as corresponding Power8NVL and Power8E PnvChips will also
-be considered deprecated.
-

docs/about/removed-features.rst needs an update too.

C.

Quoted 79 lines
docs/about/deprecated.rst +0 -0
  System emulator machines
  ------------------------
 
target/ppc/cpu-models.c +0 -6
index 26b6debcfc96..aa13654e83e8 100644
@@ -734,12 +734,8 @@
                  "POWER7 v2.3")
      POWERPC_DEF("power7p_v2.1",  CPU_POWERPC_POWER7P_v21,            POWER7,
                  "POWER7+ v2.1")
-    POWERPC_DEPRECATED_CPU("power8e_v2.1",  CPU_POWERPC_POWER8E_v21, POWER8,
-                "POWER8E v2.1", "CPU is unmaintained.")
      POWERPC_DEF("power8_v2.0",   CPU_POWERPC_POWER8_v20,             POWER8,
                  "POWER8 v2.0")
-    POWERPC_DEPRECATED_CPU("power8nvl_v1.0", CPU_POWERPC_POWER8NVL_v10, POWER8,
-                "POWER8NVL v1.0", "CPU is unmaintained.")
      POWERPC_DEF("power9_v2.0",   CPU_POWERPC_POWER9_DD20,            POWER9,
                  "POWER9 v2.0")
      POWERPC_DEF("power9_v2.2",   CPU_POWERPC_POWER9_DD22,            POWER9,
@@ -918,9 +914,7 @@ PowerPCCPUAlias ppc_cpu_aliases[] = {
      { "power7", "power7_v2.3" },
      { "power7+", "power7p_v2.1" },
      { "power7+_v2.1", "power7p_v2.1" },
-    { "power8e", "power8e_v2.1" },
      { "power8", "power8_v2.0" },
-    { "power8nvl", "power8nvl_v1.0" },
      { "power9", "power9_v2.2" },
      { "power10", "power10_v2.0" },
      { "power11", "power11_v2.0" },
target/ppc/cpu-models.h +0 -4
index a439eb37ee41..ef019cdb1f3c 100644
@@ -341,12 +341,8 @@ enum {
      CPU_POWERPC_POWER7_v23         = 0x003F0203,
      CPU_POWERPC_POWER7P_BASE       = 0x004A0000,
      CPU_POWERPC_POWER7P_v21        = 0x004A0201,
-    CPU_POWERPC_POWER8E_BASE       = 0x004B0000,
-    CPU_POWERPC_POWER8E_v21        = 0x004B0201,
      CPU_POWERPC_POWER8_BASE        = 0x004D0000,
      CPU_POWERPC_POWER8_v20         = 0x004D0200,
-    CPU_POWERPC_POWER8NVL_BASE     = 0x004C0000,
-    CPU_POWERPC_POWER8NVL_v10      = 0x004C0100,
      CPU_POWERPC_POWER9_BASE        = 0x004E0000,
      CPU_POWERPC_POWER9_DD1         = 0x004E1100,
      CPU_POWERPC_POWER9_DD20        = 0x004E1200,
target/ppc/cpu_init.c +0 -6
index d25f69f13ba5..87186ec32179 100644
@@ -6310,12 +6310,6 @@ static bool ppc_pvr_match_power8(PowerPCCPUClass *pcc, uint32_t pvr, bool best)
          if (base == CPU_POWERPC_POWER8_BASE) {
              return true;
          }
-        if (base == CPU_POWERPC_POWER8E_BASE) {
-            return true;
-        }
-        if (base == CPU_POWERPC_POWER8NVL_BASE) {
-            return true;
-        }
      }
      if (base != pcc_base) {
          return false;
target/ppc/kvm.c +1 -3
index b94c2997a07f..78a1c4a8393e 100644
@@ -2437,9 +2437,7 @@ static bool kvmppc_power8_host(void)
  #ifdef TARGET_PPC64
      {
          uint32_t base_pvr = CPU_POWERPC_POWER_SERVER_MASK & mfpvr();
-        ret = (base_pvr == CPU_POWERPC_POWER8E_BASE) ||
-              (base_pvr == CPU_POWERPC_POWER8NVL_BASE) ||
-              (base_pvr == CPU_POWERPC_POWER8_BASE);
+        ret = (base_pvr == CPU_POWERPC_POWER8_BASE);
      }
  #endif /* TARGET_PPC64 */
      return ret;
#12 lore raw

Re: [PATCH 4/4] ppc/pnv: Remove Power8E and Power8NVL CPUs

Quoted 18 lines · Cédric Le Goater

On 6/10/26 11:08, Aditya Gupta via Devel wrote:
<...snip...>

Quoted 4 lines
docs/about/deprecated.rst +0 -0
@@ -215,15 +215,6 @@ embedded 405 for power management (OCC) and other internal tasks, it
  is theoretically possible to use QEMU to model them. Let's keep the

docs/about/deprecated.rst embedded 405 for power management (OCC) and other internal tasks, it · line 225

Quoted 10 lines
docs/about/deprecated.rst +0 -9
  CPU implementation for a while before removing all support.
-Power8E and Power8NVL CPUs and corresponding Pnv chips (since 10.1)
-'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
-
-The Power8E and Power8NVL variants of Power8 are not really useful anymore
-in qemu, and are old and unmaintained now.
-
-The CPUs as well as corresponding Power8NVL and Power8E PnvChips will also
-be considered deprecated.
-

docs/about/removed-features.rst needs an update too.

Sure cédric, will update it

Thanks,
- Aditya G

Quoted 2 lines

C.