Skip to contentSkip to conversation

drm/print: add drm_warn_ratelimited logging macro

PATCH Superseded Dawid Osuchowski 2 participants 3 messages Jun 10

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drm/print: add drm_warn_ratelimited logging macro

Add a drm_warn_ratelimited() macro to complement the existing drm_err_ratelimited(), providing rate-limited logging at warning level for drivers that need it.

---
 include/drm/drm_print.h | 3 +++
 1 file changed, 3 insertions(+)
include/drm/drm_print.h +3 -0
index 2adc5ac688e1..0805903c093b 100644
@@ -644,6 +644,9 @@ static inline struct device *__drm_to_dev(const struct drm_device *drm)
 #define drm_err_ratelimited(drm, fmt, ...)				\
 	__drm_printk((drm), err, _ratelimited, "*ERROR* " fmt, ##__VA_ARGS__)
 
+#define drm_warn_ratelimited(drm, fmt, ...)				\
+	__drm_printk((drm), warn, _ratelimited, fmt, ##__VA_ARGS__)
+
 
 #define drm_dbg_core(drm, fmt, ...)					\
 	drm_dev_dbg(__drm_to_dev(drm), DRM_UT_CORE, fmt, ##__VA_ARGS__)

base-commit: f2f4e6d45fecc6ead92bf5ea06a04a00c245904e

Signature · 1 line
2.43.0
#1 lore raw

PATCH 2/2 accel/ivpu: Use drm_warn_ratelimited macro

Fix ivpu_warn_ratelimited() to properly use WARN logging level instead of an ERROR.

---
 drivers/accel/ivpu/ivpu_drv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/accel/ivpu/ivpu_drv.h +1 -1
index 9eefbbb7ba11..d5f77cf84196 100644
@@ -90,7 +90,7 @@
 	drm_warn(&(vdev)->drm, "%s(): " fmt, __func__, ##__VA_ARGS__)
 
 #define ivpu_warn_ratelimited(vdev, fmt, ...) \
-	drm_err_ratelimited(&(vdev)->drm, "%s(): " fmt, __func__, ##__VA_ARGS__)
+	drm_warn_ratelimited(&(vdev)->drm, "%s(): " fmt, __func__, ##__VA_ARGS__)
 
 #define ivpu_info(vdev, fmt, ...) drm_info(&(vdev)->drm, fmt, ##__VA_ARGS__)
 
Signature · 1 line
2.43.0
maintainer Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] accel/ivpu: Use drm_warn_ratelimited macro

Quoted 13 lines · Dawid Osuchowski

Fix ivpu_warn_ratelimited() to properly use WARN logging level instead of an ERROR.

---
  drivers/accel/ivpu/ivpu_drv.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/accel/ivpu/ivpu_drv.h +0 -0
index 9eefbbb7ba11..d5f77cf84196 100644

drivers/accel/ivpu/ivpu_drv.h line 96

Quoted 8 lines
drivers/accel/ivpu/ivpu_drv.h +1 -1
@@ -90,7 +90,7 @@
  	drm_warn(&(vdev)->drm, "%s(): " fmt, __func__, ##__VA_ARGS__)
 
  #define ivpu_warn_ratelimited(vdev, fmt, ...) \
-	drm_err_ratelimited(&(vdev)->drm, "%s(): " fmt, __func__, ##__VA_ARGS__)
+	drm_warn_ratelimited(&(vdev)->drm, "%s(): " fmt, __func__, ##__VA_ARGS__)
 
  #define ivpu_info(vdev, fmt, ...) drm_info(&(vdev)->drm, fmt, ##__VA_ARGS__)