Skip to contentSkip to conversation

RDMA/bnxt_re: check debugfs parameter allocation

PATCH In review Ruoyu Wang 2 participants 2 messages Jun 6 – Jun 10

Subsystems (2)
lore
Share & tools
lore

Ruoyu Wang

author
#0 lore raw

PATCH 1/1 RDMA/bnxt_re: check debugfs parameter allocation

bnxt_re_debugfs_add_pdev() allocates per-file private data for the CC configuration debugfs entries. The loop that initializes those entries uses rdev->cc_config_params immediately, so allocation failure would lead to NULL pointer dereferences while setting up debugfs.

Debugfs is best-effort. If the CC configuration private data cannot be allocated, skip those entries and continue with the independent CQ coalescing debugfs setup.

---
 drivers/infiniband/hw/bnxt_re/debugfs.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/infiniband/hw/bnxt_re/debugfs.c +3 -0
index 5fed2cf66be30..b1d6a8b32cc48 100644
@@ -498,6 +498,8 @@ void bnxt_re_debugfs_add_pdev(struct bnxt_re_dev *rdev)
 	bnxt_re_debugfs_add_info(rdev);
 
 	rdev->cc_config_params = kzalloc_obj(*cc_params);
+	if (!rdev->cc_config_params)
+		goto init_cq_coal;
 
 	for (i = 0; i < BNXT_RE_CC_PARAM_GEN0; i++) {
 		struct bnxt_re_cc_param *tmp_params = &rdev->cc_config_params->gen0_parms[i];
@@ -510,6 +512,7 @@ void bnxt_re_debugfs_add_pdev(struct bnxt_re_dev *rdev)
 							 &bnxt_re_cc_config_ops);
 	}
 
+init_cq_coal:
 	bnxt_re_init_cq_coal_debugfs(rdev);
 }
 
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 5 lines · Ruoyu Wang

bnxt_re_debugfs_add_pdev() allocates per-file private data for the CC configuration debugfs entries. The loop that initializes those entries uses rdev->cc_config_params immediately, so allocation failure would lead to NULL pointer dereferences while setting up debugfs.

Quoted 8 lines

Debugfs is best-effort. If the CC configuration private data cannot be allocated, skip those entries and continue with the independent CQ coalescing debugfs setup.

---
 drivers/infiniband/hw/bnxt_re/debugfs.c | 3 +++
 1 file changed, 3 insertions(+)

Applied though

drivers/infiniband/hw/bnxt_re/debugfs.c void bnxt_re_debugfs_add_pdev(struct bnxt_re_dev *rdev) · line 502

Quoted 3 lines
drivers/infiniband/hw/bnxt_re/debugfs.c +2 -0
 	rdev->cc_config_params = kzalloc_obj(*cc_params);
+	if (!rdev->cc_config_params)
+		goto init_cq_coal;

I changed this to just return, there is no point in continuing to setup as the machine is probably dead if this fails.

Thanks,
Jason