Skip to contentSkip to conversation

leds: as3668: correct name of config option to match Makefile

PATCH In review Ethan Nelson-Moore 2 participants 2 messages Jun 10 – Jun 12

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 leds: as3668: correct name of config option to match Makefile

The Makefile for the AS3668 LED driver refers to CONFIG_LEDS_AS3668, whereas the config file defines CONFIG_LEDS_OSRAM_AMS_AS3668. This causes the driver to never be compiled. Correct the name in the Kconfig file to match the Makefile. Doing the opposite would also have worked, but the name in the Makefile better matches the format of other drivers' options.

Fixes c7dd343a3756 ("leds: as3668: Driver for the ams Osram 4-channel i2c LED driver")
---
 drivers/leds/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/leds/Kconfig +1 -1
index f4a0a3c8c870..5ac63cb59469 100644
@@ -107,7 +107,7 @@ config LEDS_ARIEL
 
 	  Say Y to if your machine is a Dell Wyse 3020 thin client.
 
-config LEDS_OSRAM_AMS_AS3668
+config LEDS_AS3668
 	tristate "LED support for Osram AMS AS3668"
 	depends on LEDS_CLASS
 	depends on I2C
Signature · 1 line
2.43.0
#1 lore raw
Quoted 31 lines · Ethan Nelson-Moore

The Makefile for the AS3668 LED driver refers to CONFIG_LEDS_AS3668, whereas the config file defines CONFIG_LEDS_OSRAM_AMS_AS3668. This causes the driver to never be compiled. Correct the name in the Kconfig file to match the Makefile. Doing the opposite would also have worked, but the name in the Makefile better matches the format of other drivers' options.

Fixes c7dd343a3756 ("leds: as3668: Driver for the ams Osram 4-channel i2c LED driver")
---
 drivers/leds/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/leds/Kconfig +1 -1
index f4a0a3c8c870..5ac63cb59469 100644
@@ -107,7 +107,7 @@ config LEDS_ARIEL
 
 	  Say Y to if your machine is a Dell Wyse 3020 thin client.
 
-config LEDS_OSRAM_AMS_AS3668
+config LEDS_AS3668
 	tristate "LED support for Osram AMS AS3668"
 	depends on LEDS_CLASS
 	depends on I2C
Signature · 1 line
2.43.0

Hi Ethan,

thank you for noticing that issue.

This was already fixed here:
https://lore.kernel.org/all/177815964265.1857555.230971455145782585.b4-ty@b4/

Best regards
Lukas