dt-bindings: interrupt-controller: ti,irq-crossbar: Convert to DT schema
Subsystems (2)
PATCH v2 1/1 dt-bindings: interrupt-controller: ti,irq-crossbar: Convert to DT schema
Convert TI irq-crossbar binding from text format to DT schema.
As part of conversion following changes are made:
- Add '#interrupt-cells' as a required property which was missing in text binding
- As irq-crossbar is interrupt-controller. Move binding from bindings/arm/omap to bindings/interrupt-controller
---
Changes in v2:
- Dropped property name change and driver updates.
- Link to v1: https://lore.kernel.org/r/[email protected]
--- .../devicetree/bindings/arm/omap/crossbar.txt | 55 ------------- .../interrupt-controller/ti,irq-crossbar.yaml | 96 ++++++++++++++++++++++ 2 files changed, 96 insertions(+), 55 deletions(-)
Documentation/devicetree/bindings/arm/omap/crossbar.txt deleted +0 -55
@@ -1,55 +0,0 @@ -Some socs have a large number of interrupts requests to service -the needs of its many peripherals and subsystems. All of the -interrupt lines from the subsystems are not needed at the same -time, so they have to be muxed to the irq-controller appropriately. -In such places a interrupt controllers are preceded by an CROSSBAR -that provides flexibility in muxing the device requests to the controller -inputs. - -Required properties: -- compatible : Should be "ti,irq-crossbar" -- reg: Base address and the size of the crossbar registers. -- interrupt-controller: indicates that this block is an interrupt controller. -- ti,max-irqs: Total number of irqs available at the parent interrupt controller. -- ti,max-crossbar-sources: Maximum number of crossbar sources that can be routed. -- ti,reg-size: Size of a individual register in bytes. Every individual - register is assumed to be of same size. Valid sizes are 1, 2, 4. -- ti,irqs-reserved: List of the reserved irq lines that are not muxed using - crossbar. These interrupt lines are reserved in the soc, - so crossbar bar driver should not consider them as free - lines. - -Optional properties: -- ti,irqs-skip: This is similar to "ti,irqs-reserved", but these are for - SOC-specific hard-wiring of those irqs which unexpectedly bypasses the - crossbar. These irqs have a crossbar register, but still cannot be used. - -- ti,irqs-safe-map: integer which maps to a safe configuration to use - when the interrupt controller irq is unused (when not provided, default is 0) - -Examples: - crossbar_mpu: crossbar@4a002a48 { - compatible = "ti,irq-crossbar"; - reg = <0x4a002a48 0x130>; - ti,max-irqs = <160>; - ti,max-crossbar-sources = <400>; - ti,reg-size = <2>; - ti,irqs-reserved = <0 1 2 3 5 6 131 132>; - ti,irqs-skip = <10 133 139 140>; - }; - -Consumer: -======== -See Documentation/devicetree/bindings/interrupt-controller/interrupts.txt and -Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml for -further details. - -An interrupt consumer on an SoC using crossbar will use: - interrupts = <GIC_SPI request_number interrupt_level> - -Example: - device_x@4a023000 { - /* Crossbar 8 used */ - interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>; - ... - };
Documentation/devicetree/bindings/interrupt-controller/ti,irq-crossbar.yaml new file +96 -0
96 lines not on this page · raw message
---
base-commit: eb3f4b7426cfd2b79d65b7d37155480b32259a11
change-id: 20260528-crossbar-2b9a641d2146
Best regards,
Signature · 1 line
Bhargav
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Incorrect property name referenced in the description of `ti,irqs-skip`. The description refers to…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect property name referenced in the description of ti,irqs-skip. The description refers to ti,crossbar-irqs-reserved instead of the actual property name ti,irqs-reserved. --
commit 19def91a21d8fc01d4494e60735ef7f90bf2fedd
Author: Bhargav Joshi <[email protected]>
dt-bindings: interrupt-controller: ti,irq-crossbar: Convert to DT schema
This commit converts the TI irq-crossbar binding from text format to DT schema. It also adds the missing '#interrupt-cells' property and moves the binding into the interrupt-controller directory.
Quoted 5 lines
Documentation/devicetree/bindings/interrupt-controller/ti,irq-crossbar.yaml new file +0
-0
[ ... ]
Documentation/devicetree/bindings/interrupt-controller/ti,irq-crossbar.yaml line 61
Quoted 11 lines
Documentation/devicetree/bindings/interrupt-controller/ti,irq-crossbar.yaml new file +11
-0+ ti,irqs-reserved: + $ref: /schemas/types.yaml#/definitions/uint32-array + description: + List of the reserved irq lines that are not muxed using crossbar. These + interrupt lines are reserved in the soc, so crossbar bar driver should not + consider them as free lines. + + ti,irqs-skip: + $ref: /schemas/types.yaml#/definitions/uint32-array + description: + Similar to "ti,crossbar-irqs-reserved", but these are for SOC-specific
[Severity: Low]
This isn't a bug, but there is a typo in the property name referenced here. The original text binding correctly referred to "ti,irqs-reserved", but it was mistakenly changed to "ti,crossbar-irqs-reserved" during the conversion. Should this reference the actual property name "ti,irqs-reserved"?
Quoted 2 lines
Documentation/devicetree/bindings/interrupt-controller/ti,irq-crossbar.yaml new file +2
-0+ hard-wiring of those irqs which unexpectedly bypasses the crossbar. These + irqs have a crossbar register, but still cannot be used.
[ ... ]
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1