Skip to contentSkip to conversation

mm: fix CONFIG_STACK_GROWSUP typo in tools/testing/vma/include/dup.h

PATCH Applied Ethan Nelson-Moore 4 participants 5 messages Jun 11 – Jun 26

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: fix CONFIG_STACK_GROWSUP typo in tools/testing/vma/include/dup.h

Commit 2b6a3f061f11 ("mm: declare VMA flags by bit") significantly refactored the header file include/linux/mm.h. In that step, it introduced a typo in an ifdef, referring to a non-existing config option STACK_GROWS_UP, whereas the actual config option is called STACK_GROWSUP.

Commit 40a4af52e047 ("mm: fix CONFIG_STACK_GROWSUP typo in mm.h") fixed this typo in the mm.h header file, but did not update the copy of the code in tools/testing/vma/include/dup.h. Update this copy as well.

Commit message adapted from the above-referenced fix to mm.h.

Fixes 2b6a3f061f11 ("mm: declare VMA flags by bit")
---
 tools/testing/vma/include/dup.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/vma/include/dup.h +1 -1
index 9e0dfd3a85b0..adbc3179085d 100644
@@ -243,7 +243,7 @@ enum {
 #define VM_NOHUGEPAGE	INIT_VM_FLAG(NOHUGEPAGE)
 #define VM_MERGEABLE	INIT_VM_FLAG(MERGEABLE)
 #define VM_STACK	INIT_VM_FLAG(STACK)
-#ifdef CONFIG_STACK_GROWS_UP
+#ifdef CONFIG_STACK_GROWSUP
 #define VM_STACK_EARLY	INIT_VM_FLAG(STACK_EARLY)
 #else
 #define VM_STACK_EARLY	VM_NONE
Signature · 1 line
2.43.0
#1 lore raw
Quoted 5 lines · Ethan Nelson-Moore

Commit 2b6a3f061f11 ("mm: declare VMA flags by bit") significantly refactored the header file include/linux/mm.h. In that step, it introduced a typo in an ifdef, referring to a non-existing config option STACK_GROWS_UP, whereas the actual config option is called STACK_GROWSUP.

Quoted 8 lines

Commit 40a4af52e047 ("mm: fix CONFIG_STACK_GROWSUP typo in mm.h") fixed this typo in the mm.h header file, but did not update the copy of the code in tools/testing/vma/include/dup.h. Update this copy as well.

Commit message adapted from the above-referenced fix to mm.h.

Fixes 2b6a3f061f11 ("mm: declare VMA flags by bit")

This is in tools/testing/vma. Why does this require a stable tag?

What is the resulting problem (in the test!) that we even care about the Fixes: tag?

If there is no user visible (test!) problem, then this is merely a cleanup, not a bugfix.

Change itself LGTM.

Quoted 18 lines
---
 tools/testing/vma/include/dup.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/vma/include/dup.h +1 -1
index 9e0dfd3a85b0..adbc3179085d 100644
@@ -243,7 +243,7 @@ enum {
 #define VM_NOHUGEPAGE	INIT_VM_FLAG(NOHUGEPAGE)
 #define VM_MERGEABLE	INIT_VM_FLAG(MERGEABLE)
 #define VM_STACK	INIT_VM_FLAG(STACK)
-#ifdef CONFIG_STACK_GROWS_UP
+#ifdef CONFIG_STACK_GROWSUP
 #define VM_STACK_EARLY	INIT_VM_FLAG(STACK_EARLY)
 #else
 #define VM_STACK_EARLY	VM_NONE
Signature · 3 lines
Cheers,

David
maintainer
#2 lore raw
Quoted 10 lines · David Hildenbrand (Arm)
Quoted 9 lines · Ethan Nelson-Moore

Commit 2b6a3f061f11 ("mm: declare VMA flags by bit") significantly refactored the header file include/linux/mm.h. In that step, it introduced a typo in an ifdef, referring to a non-existing config option STACK_GROWS_UP, whereas the actual config option is called STACK_GROWSUP.

Commit 40a4af52e047 ("mm: fix CONFIG_STACK_GROWSUP typo in mm.h") fixed this typo in the mm.h header file, but did not update the copy of the code in tools/testing/vma/include/dup.h. Update this copy as well.

Quoted 8 lines
Quoted 4 lines

Commit message adapted from the above-referenced fix to mm.h.

Fixes 2b6a3f061f11 ("mm: declare VMA flags by bit")

This is in tools/testing/vma. Why does this require a stable tag?

What is the resulting problem (in the test!) that we even care about the Fixes: tag?

Yeah I doubt very much that stable users are running VMA userland tests on parisc :))

Quoted 3 lines

If there is no user visible (test!) problem, then this is merely a cleanup, not a bugfix.

Yeah I think moreso this.

Quoted 8 lines

Change itself LGTM.

Quoted 5 lines
---
 tools/testing/vma/include/dup.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 19 lines
Quoted 13 lines
tools/testing/vma/include/dup.h +1 -1
index 9e0dfd3a85b0..adbc3179085d 100644
@@ -243,7 +243,7 @@ enum {
 #define VM_NOHUGEPAGE	INIT_VM_FLAG(NOHUGEPAGE)
 #define VM_MERGEABLE	INIT_VM_FLAG(MERGEABLE)
 #define VM_STACK	INIT_VM_FLAG(STACK)
-#ifdef CONFIG_STACK_GROWS_UP
+#ifdef CONFIG_STACK_GROWSUP
 #define VM_STACK_EARLY	INIT_VM_FLAG(STACK_EARLY)
 #else
 #define VM_STACK_EARLY	VM_NONE
Signature · 3 lines
Cheers,

David

Thanks, Lorenzo

maintainer Reviewed-by on v1 1/1
#3 lore raw
In reply to Ethan Nelson-Moore
Quoted 5 lines · Ethan Nelson-Moore

Commit 2b6a3f061f11 ("mm: declare VMA flags by bit") significantly refactored the header file include/linux/mm.h. In that step, it introduced a typo in an ifdef, referring to a non-existing config option STACK_GROWS_UP, whereas the actual config option is called STACK_GROWSUP.

Quoted 8 lines

Commit 40a4af52e047 ("mm: fix CONFIG_STACK_GROWSUP typo in mm.h") fixed this typo in the mm.h header file, but did not update the copy of the code in tools/testing/vma/include/dup.h. Update this copy as well.

Commit message adapted from the above-referenced fix to mm.h.

Fixes 2b6a3f061f11 ("mm: declare VMA flags by bit")

Actually since we don't set the config options like the kernel does in userland tests, this can't actually be something that you can get to happen :P

So drop both Fixes, and the Cc: stable please as per David (Andrew - can you make that change? Thanks!)

Quoted 1 line

Thanks for fixing this however! I typo'd this in the actual code but didn't update the VMA userland test code. Appreciate the cleanup! So, with the fixes, Cc: stable tags dropped:

Quoted 20 lines
---
 tools/testing/vma/include/dup.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/vma/include/dup.h +1 -1
index 9e0dfd3a85b0..adbc3179085d 100644
@@ -243,7 +243,7 @@ enum {
 #define VM_NOHUGEPAGE	INIT_VM_FLAG(NOHUGEPAGE)
 #define VM_MERGEABLE	INIT_VM_FLAG(MERGEABLE)
 #define VM_STACK	INIT_VM_FLAG(STACK)
-#ifdef CONFIG_STACK_GROWS_UP
+#ifdef CONFIG_STACK_GROWSUP
 #define VM_STACK_EARLY	INIT_VM_FLAG(STACK_EARLY)
 #else
 #define VM_STACK_EARLY	VM_NONE
Signature · 1 line
2.43.0

Cheers, Lorenzo

maintainer
#4 lore raw
Quoted 2 lines · On Fri, 26 Jun 2026 13:06:23 +0100 Lorenzo Stoakes <[email protected]> wrote:

So drop both Fixes, and the Cc: stable please as per David (Andrew - can you make that change? Thanks!)

Done, thanks.