Skip to contentSkip to conversation

build: use correct subst variable

PATCH In review Li Dongyang 2 participants 2 messages Jun 11

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 build: use correct subst variable

ifNotGNUmake was changed to ifnGNUmake but test/Makefile.in still uses
the old variable name.
make fullcheck fails on some platforms:
make[2]: Entering directory `/var/lib/jenkins/workspace/e2fsprogs-reviews/arch/x86_64/distro/el7/_topdir/BUILD/e2fsprogs-1.47.4/tests' Makefile:387: *** missing separator. Stop.
make[2]: Leaving directory `/var/lib/jenkins/workspace/e2fsprogs-reviews/arch/x86_64/distro/el7/_topdir/BUILD/e2fsprogs-1.47.4/tests' make[1]: *** [fullcheck-recursive] Error 1

Fixes b7d1ab3376 "Update configure/configure.ac/aclocal.m4 to use autoconf 2.72"
Change-Id Iec3cacfca7206bf785381664b7d7bded8c70113c
---
 tests/Makefile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/Makefile.in +1 -1
index 678cc3268c..8f7a072f45 100644
@@ -48,7 +48,7 @@ test_data.tmp: $(srcdir)/scripts/gen-test-data
 always_run:
 
 @ifGNUmake@TESTS=$(wildcard $(srcdir)/[a-z]_*)
-@ifNotGNUmake@TESTS != echo $(srcdir)/[a-z]_*
+@ifnGNUmake@TESTS != echo $(srcdir)/[a-z]_*
 
 SKIP_SLOW_TESTS=--skip-slow-tests
 
Signature · 1 line
2.52.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Li Dongyang

ifNotGNUmake was changed to ifnGNUmake but test/Makefile.in still uses
the old variable name.
make fullcheck fails on some platforms:
make[2]: Entering directory `/var/lib/jenkins/workspace/e2fsprogs-reviews/arch/x86_64/distro/el7/_topdir/BUILD/e2fsprogs-1.47.4/tests' Makefile:387: *** missing separator. Stop.
make[2]: Leaving directory `/var/lib/jenkins/workspace/e2fsprogs-reviews/arch/x86_64/distro/el7/_topdir/BUILD/e2fsprogs-1.47.4/tests' make[1]: *** [fullcheck-recursive] Error 1

Quoted 3 lines
Fixes b7d1ab3376 "Update configure/configure.ac/aclocal.m4 to use autoconf 2.72"
Change-Id Iec3cacfca7206bf785381664b7d7bded8c70113c
Reviewed-by Andreas Dilger <[email protected] <mailto:[email protected]>>
Quoted 11 lines

---
tests/Makefile.in | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
tests/Makefile.in +0 -0
index 678cc3268c..8f7a072f45 100644
@@ -48,7 +48,7 @@ test_data.tmp: $(srcdir)/scripts/gen-test-data

always_run:

Quoted 10 lines

@ifGNUmake@TESTS=$(wildcard $(srcdir)/[a-z]_*)
-@ifNotGNUmake@TESTS != echo $(srcdir)/[a-z]_*
+@ifnGNUmake@TESTS != echo $(srcdir)/[a-z]_*

SKIP_SLOW_TESTS=--skip-slow-tests

Signature · 1 line
2.52.0

Cheers, Andreas