Skip to contentSkip to conversation

migration-guide: Fix migration scripts

PATCH Applied [email protected] 3 participants 3 messages Jun 11 – Jun 29

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 migration-guide: Fix migration scripts

From: Vyacheslav Yurkov <[email protected]>

The names in the find command should be in quotes, otherwise the expansion is done before the find command executed.

---
 documentation/migration-guides/migration-5.3.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
documentation/migration-guides/migration-5.3.rst +3 -3
index 8746141cd..9e6a5769a 100644
@@ -83,16 +83,16 @@ How to make those adjustments without tedious manual editing
 The following sed command can be used to remove S = "${WORKDIR}/git
 across a whole layer::
 
-   sed -i "/^S = \"\${WORKDIR}\/git\"/d" `find . -name *.bb -o -name *.inc -o -name *.bbclass`
+   sed -i "/^S = \"\${WORKDIR}\/git\"/d" `find . -name '*.bb' -o -name '*.inc' -o -name '*.bbclass'`
 
 Then, the following command can tweak the remaining :term:`S` assignments to
 refer to :term:`UNPACKDIR` instead of :term:`WORKDIR`::
 
-   sed -i "s/^S = \"\${WORKDIR}\//S = \"\${UNPACKDIR}\//g" `find . -name *.bb -o -name *.inc -o -name *.bbclass`
+   sed -i "s/^S = \"\${WORKDIR}\//S = \"\${UNPACKDIR}\//g" `find . -name '*.bb' -o -name '*.inc' -o -name '*.bbclass'`
 
 The first change can introduce a lot of consecutive empty lines, so those can be removed with::
 
-   sed -i -z -E 's/([ \t\f\v\r]*\n){3,}/\n\n/g' `find . -name *.bb -o -name *.inc`
+   sed -i -z -E 's/([ \t\f\v\r]*\n){3,}/\n\n/g' `find . -name '*.bb' -o -name '*.inc'`
 
 
 BitBake Git fetcher ``tag`` parameter
Reviewed-by on v1 1/1
#1 lore raw

Hi Vyacheslav,

Quoted 7 lines · Vyacheslav Yurkov via lists.yoctoproject.org

[You don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

From: Vyacheslav Yurkov <[email protected]>

The names in the find command should be in quotes, otherwise the expansion is done before the find command executed.

@Antonin, it would be nice to backport this to Wrynose as well.

Thanks!
Quentin