KVM: s390: Initialize KVM_S390_GET_CMMA_BITS memory
Subsystems (4)
Christian Borntraeger
maintainerPATCH 2/2 KVM: s390: Initialize KVM_S390_GET_CMMA_BITS memory
kvm_s390_get_cmma_bits() allocates its output buffer with vmalloc(), which does not zero the returned pages:
values = vmalloc(args->count);
In the non-peek (migration) path, dat_get_cmma() reports a byte count spanning from the first to the last dirty page, but __dat_get_cmma_pte() writes values[gfn - start] only for pages whose CMMA dirty bit is set. The walk uses DAT_WALK_IGN_HOLES, so clean and unmapped pages that lie between two dirty pages within the reported span are visited but never store their byte. Those gaps (up to KVM_S390_MAX_BIT_DISTANCE pages each) stay uninitialized yet fall inside [0, count) and are copied out by copy_to_user(), disclosing stale kernel memory to user space.
Before the switch to the new gmap implementation the buffer was fully populated for every gfn in the span, so no uninitialized bytes were exposed; the dirty-only walk introduced the leak.
Use vzalloc() so the gaps read back as zero.
--- arch/s390/kvm/kvm-s390.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/s390/kvm/kvm-s390.c +1 -1
@@ -2247,7 +2247,7 @@ static int kvm_s390_get_cmma_bits(struct kvm *kvm,return 0 ; } - values =vmalloc (args->count); + values =vzalloc (args->count);if (!values)return -ENOMEM ;
Signature · 1 line
2.53.0
Quoted 18 lines · On Thu, 11 Jun 2026 12:50:36 +0200 Christian Borntraeger…
kvm_s390_get_cmma_bits()allocates its output buffer withvmalloc(), which does not zero the returned pages:values = vmalloc(args->count);In the non-peek (migration) path,
dat_get_cmma()reports a byte count spanning from the first to the last dirty page, but__dat_get_cmma_pte()writes values[gfn - start] only for pages whose CMMA dirty bit is set. The walk usesDAT_WALK_IGN_HOLES, so clean and unmapped pages that lie between two dirty pages within the reported span are visited but never store their byte. Those gaps (up toKVM_S390_MAX_BIT_DISTANCEpages each) stay uninitialized yet fall inside [0, count) and are copied out bycopy_to_user(), disclosing stale kernel memory to user space.Before the switch to the new gmap implementation the buffer was fully populated for every gfn in the span, so no uninitialized bytes were exposed; the dirty-only walk introduced the leak.
Quoted 5 lines
Use
vzalloc()so the gaps read back as zero.Fixes e38c884df921 ("KVM: s390: Switch to new gmap")Signed-off-by Christian Borntraeger <[email protected]>
Quoted 17 lines
--- arch/s390/kvm/kvm-s390.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/s390/kvm/kvm-s390.c +1
-1@@ -2247,7 +2247,7 @@ static int kvm_s390_get_cmma_bits(struct kvm *kvm,return 0 ; } - values =vmalloc (args->count); + values =vzalloc (args->count);if (!values)return -ENOMEM ;