Skip to contentSkip to conversation

arm64: static_call: include asm/insns.h

PATCH Applied Arnd Bergmann 2 participants 2 messages Jun 11 – Jun 19

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: static_call: include asm/insns.h

From: Arnd Bergmann <[email protected]>

I came a cross a missing declaration in a randconfig build:

arch/arm64/kernel/static_call.c:16:5: error: call to undeclared function 'aarch64_insn_adrp_get_offset'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]

   16 |                   aarch64_insn_adrp_get_offset(le32_to_cpup(tramp + 4)) +
      |                   ^

Include the header that contains this definition explicitly, rather than relying on it to come indirectly through another header.

Fixes 54ac9ff8f119 ("arm64: Use static call trampolines when kCFI is enabled")
---
 arch/arm64/kernel/static_call.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/kernel/static_call.c +1 -0
index 8b3a19e10871..c126edced022 100644
@@ -2,6 +2,7 @@
 #include <linux/static_call.h>
 #include <linux/memory.h>
 #include <asm/text-patching.h>
+#include <asm/insn.h>
 
 void arch_static_call_transform(void *site, void *tramp, void *func, bool tail)
 {
Signature · 1 line
2.39.5
maintainer Applied
#1 lore raw
Quoted 11 lines · Arnd Bergmann

I came a cross a missing declaration in a randconfig build:

arch/arm64/kernel/static_call.c:16:5: error: call to undeclared function 'aarch64_insn_adrp_get_offset'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]

   16 |                   aarch64_insn_adrp_get_offset(le32_to_cpup(tramp + 4)) +
      |                   ^

Include the header that contains this definition explicitly, rather than relying on it to come indirectly through another header.

[...]

Applied to arm64 (for-next/core), thanks!

[1/1] arm64: static_call: include asm/insns.h

      https://git.kernel.org/arm64/c/998d4d789d2d

Cheers,

Signature · 5 lines
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev