Skip to contentSkip to conversation

ffmpeg, x264: Add comment about circular dependency

PATCH New Joshua Watt 1 participant 1 message Jun 11

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ffmpeg, x264: Add comment about circular dependency

There is a circular dependency on x264 and ffmpeg that can be triggered if both enable the PACKAGECONFIG for the other. We don't have a way to solve this yet, but add a comment to indicate that this is the case so that users are not surprised when it occurs.

[YOCTO #16312]

---
 meta/recipes-multimedia/ffmpeg/ffmpeg_8.1.1.bb | 2 ++
 meta/recipes-multimedia/x264/x264_git.bb       | 2 ++
 2 files changed, 4 insertions(+)
meta/recipes-multimedia/ffmpeg/ffmpeg_8.1.1.bb +2 -0
index bfa35882ea..0aa8c6e8e1 100644
@@ -76,6 +76,8 @@ PACKAGECONFIG[v4l2] = "--enable-libv4l2,--disable-libv4l2,v4l-utils"
 PACKAGECONFIG[vaapi] = "--enable-vaapi,--disable-vaapi,libva"
 PACKAGECONFIG[vdpau] = "--enable-vdpau,--disable-vdpau,libvdpau"
 PACKAGECONFIG[vpx] = "--enable-libvpx,--disable-libvpx,libvpx"
+# Note: There is a circular dependency between ffmpeg and x264 that can be
+# triggered if both have PACKAGECONFIG enabled that depends on the other
 PACKAGECONFIG[x264] = "--enable-libx264,--disable-libx264,x264"
 PACKAGECONFIG[x265] = "--enable-libx265,--disable-libx265,x265"
 PACKAGECONFIG[xcb] = "--enable-libxcb,--disable-libxcb,libxcb"
meta/recipes-multimedia/x264/x264_git.bb +2 -0
index b3d1cfd695..f0278cae64 100644
@@ -29,6 +29,8 @@ PACKAGECONFIG ?= " \
     ffmpeg \
     ${@bb.utils.filter("DISTRO_FEATURES", "opencl", d)} \
 "
+# Note: There is a circular dependency between ffmpeg and x264 that can be
+# triggered if both have PACKAGECONFIG enabled that depends on the other
 PACKAGECONFIG[ffmpeg] = "--enable-lavf --enable-swscale,--disable-lavf --disable-swscale,ffmpeg"
 PACKAGECONFIG[opencl] = "--enable-opencl,--disable-opencl,"
 
Signature · 1 line
2.54.0