Skip to contentSkip to conversation

lib-test_firmware-allocate-the-configured-into_buf-size.patch removed from -mm tree

merged mm-nonmm-stable Andrew Morton 1 participant 1 message Jun 11

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: lib/test_firmware: allocate the configured into_buf size
has been removed from the -mm tree. Its filename was
lib-test_firmware-allocate-the-configured-into_buf-size.patch

This patch was dropped because it was merged into the mm-nonmm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Samuel Moelius <[email protected]>
Subject: lib/test_firmware: allocate the configured into_buf size
Date: Fri, 5 Jun 2026 00:30:37 +0000

The batched into_buf test path allocates TEST_FIRMWARE_BUF_SIZE bytes unconditionally, but then passes test_fw_config->buf_size to request_firmware_into_buf() or request_partial_firmware_into_buf().

Userspace can set config_buf_size above TEST_FIRMWARE_BUF_SIZE before triggering a batched request. If the firmware file is large enough, the firmware loader writes past the end of the 1 KiB test buffer.

Allocate the buffer with the same size that the test passes to the firmware API so config_buf_size remains the actual buffer size under test.

Assisted-by Codex:gpt-5.5-cyber-preview
Cc Kees Cook <[email protected]>
Cc Luis R. Rodriguez <[email protected]>
Cc Scott Branden <[email protected]>

---

 lib/test_firmware.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/test_firmware.c renamed from lib/test_firmware.c~lib-test_firmware-allocate-the-configured-into_buf-size +1 -1
@@ -867,7 +867,7 @@ static int test_fw_run_batch_request(voi
 	if (test_fw_config->into_buf) {
 		void *test_buf;
 
-		test_buf = kzalloc(TEST_FIRMWARE_BUF_SIZE, GFP_KERNEL);
+		test_buf = kzalloc(test_fw_config->buf_size, GFP_KERNEL);
 		if (!test_buf)
 			return -ENOMEM;
 

_

Patches currently in -mm which might be from [email protected] are

mm-page_frag-reject-invalid-cpus-in-page_frag_test.patch mm-gup_test-reject-wrapped-user-ranges.patch lib-interval_tree_test-validate-benchmark-parameters.patch fat-reject-bpb-volumes-whose-data-area-starts-beyond-total-sectors.patch