cxl: Add CXL type2 accelerator support for cxl_test
Dave Jiang
maintainerv5 cover cxl: Add CXL type2 accelerator support for cxl_test
See individual patches for changes from previous version. Fixed up sashiko reported issues.
The series is based on v7.1-rc7 with Dan's region devm-cxl_probe_mem() series [1] plus a 0-day fix [2] and Alejandro's type2 series v27 [3].
Series adds a 'type2_test' module parameter where it setup a mock type2 hierarchy with a mock type2 accelerator device directly under a root port that has an auto region setup.
It also includes a CXL fix that was encountered when running tests with the new code.
[
{
"memdevs":[
{
"memdev":"mem0",
"ram_size":536870912,
"ram_qos_class":42,
"host":"cxl_type2_accel.0",
"poison_injectable":false
}
]
},
{
"regions":[
{
"region":"region0",
"resource":70300293136384,
"size":536870912,
"type":"ram",
"interleave_ways":1,
"interleave_granularity":4096,
"decode_state":"commit"
}
] }
]
"root decoders":[
{
"decoder":"decoder0.0",
"resource":70300293136384,
"size":1073741824,
"interleave_ways":1,
"accelmem_capable":true,
"qos_class":42,
"nr_targets":1
},[1]: https://lore.kernel.org/linux-cxl/[email protected]/T/#t
[2]: https://git.kernel.org/pub/scm/linux/kernel/git/cxl/cxl.git/log/?h=for-7.3/cxl-type2-enabling
[3]: https://lore.kernel.org/linux-cxl/[email protected]/T/#t
Dave Jiang (6):
cxl/test: Add test for module parameters
cxl/test: Add type2 support for mock CFMWS0 cxl/test: Refactor platform device enumerations cxl/test: Add hierarchy enumeration support for type2 device cxl/test: Fixup hdm init for auto region to support type2 cxl/test: Add cxl_test accelerator driver
tools/testing/cxl/test/Kbuild | 2 + tools/testing/cxl/test/accel.c | 66 +++ tools/testing/cxl/test/cxl.c | 818 ++++++++++++++++++++++------- tools/testing/cxl/test/hmem_test.c | 3 +- tools/testing/cxl/test/mock.h | 2 + 5 files changed, 694 insertions(+), 197 deletions(-) create mode 100644 tools/testing/cxl/test/accel.c
base-commit: fb6e9f132f0b98c0cf99f8f08ec6ced52139d9b7
Signature · 1 line
2.54.0
Dave Jiang
maintainerPATCH v5 1/6 cxl/test: Add test for module parameters
Add a test for module paraters during module init to make sure that only one is activated.
---
v5:
- Add test for hmem_test module parameters. (sashiko)
--- tools/testing/cxl/test/cxl.c | 20 ++++++++++++++++++++ tools/testing/cxl/test/hmem_test.c | 3 ++- tools/testing/cxl/test/mock.h | 2 ++ 3 files changed, 24 insertions(+), 1 deletion(-)
tools/testing/cxl/test/cxl.c +20 -0
@@ -1814,11 +1814,31 @@ static struct attribute *cxl_acpi_attrs[] = { };ATTRIBUTE_GROUPS (cxl_acpi); +static bool __init have_multiple_modparms (void ) +{ +int count =0 ; + +if (interleave_arithmetic) + count++; +if (extended_linear_cache) + count++; +if (fail_autoassemble) + count++; +if (hmem_test) + count++; + +return count >1 ; +} +static __init int cxl_test_init (void ) {int rc, i;struct range mappable; +/* Enforce a single module param active at a time */ +if (have_multiple_modparms ()) +return -EINVAL ; +cxl_acpi_test ();cxl_core_test ();cxl_mem_test ();
tools/testing/cxl/test/hmem_test.c +2 -1
@@ -3,8 +3,9 @@#include <linux/moduleparam.h> #include <linux/workqueue.h> #include "../../../drivers/dax/bus.h" +#include "mock.h" -static bool hmem_test; +bool hmem_test;static void hmem_test_work (struct work_struct *work) {
tools/testing/cxl/test/mock.h +2 -0
@@ -5,6 +5,8 @@#include <linux/dax.h> #include <cxl.h> +extern bool hmem_test; +struct cxl_mock_ops {struct list_head list;bool (*is_mock_adev)(struct acpi_device *dev);
Signature · 1 line
2.54.0
[email protected]
AI reviewRe: [PATCH v5 1/6] cxl/test: Add test for module parameters
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
Pre-existing issues:
- [High] The statically allocated hmem_test_device.work work item is not flushed or cancelled when the cxl_test module unloads, leading to a potential use-after-free.
- [High] cxl_test_init() leaks the cxl_acpi platform device on the err_root error path, leading to a use-after-free.
--
commit 3d4ed8e7e71c954497e1a45802d1e8387b3fcfc0
Author: Dave Jiang <[email protected]>
cxl/test: Add test for module parameters
Add a test for module paraters during module init to make sure that only one is activated.
Quoted 1 line
Add a test for module paraters during module init to make sure that
[Severity: Low]
This isn't a bug, but there is a typo (paraters) in the commit message.
Quoted 4 lines
tools/testing/cxl/test/cxl.c +0
-0
[ ... ]
Quoted 12 lines
static
__initintcxl_test_init(void)
{tools/testing/cxl/test/cxl.c +4
-0int rc, i;struct range mappable; +/* Enforce a single module param active at a time */ +if (have_multiple_modparms ()) +return -EINVAL ; +cxl_acpi_test ();cxl_core_test ();cxl_mem_test ();
[ ... ]
tools/testing/cxl/test/cxl.c
Quoted 10 lines
tools/testing/cxl/test/cxl.c +0
-0rc =hmem_test_init ();if (rc) goto err_mem;return 0 ; err_mem:cxl_mem_exit (); err_root:platform_device_put (cxl_acpi);
[Severity: High]
This is a pre-existing issue, but does cxl_test_init() leak the cxl_acpi platform device on this err_root error path?
Since cxl_mock_platform_device_add() successfully added the device to the bus, should this use platform_device_unregister() instead of platform_device_put() for the already active device?
Dropping the initial allocation reference leaves the device active on the bus. The device's mock companion data (acpi0017_mock) is statically allocated in the module. When the module initialization fails and the module is unloaded, the backing memory is freed, leaving a dangling pointer on the active platform bus that can cause a kernel panic upon access.
Quoted 12 lines
tools/testing/cxl/test/hmem_test.c +2
-1@@ -3,8 +3,9 @@#include <linux/moduleparam.h> #include <linux/workqueue.h> #include "../../../drivers/dax/bus.h" +#include "mock.h" -static bool hmem_test; +bool hmem_test;
[ ... ]
Quoted 10 lines
static struct
hmem_platform_devicehmem_test_device= {tools/testing/cxl/test/hmem_test.c +0
-0.pdev = { .name = "hmem_platform", .id = 1, .dev = { .release = hmem_test_release, }, }, .work = __WORK_INITIALIZER(hmem_test_device.work, hmem_test_work), };
[ ... ]
tools/testing/cxl/test/hmem_test.c
Quoted 5 lines
void
hmem_test_exit(void)
{tools/testing/cxl/test/hmem_test.c +0
-0if (hmem_test)platform_device_unregister (&hmem_test_device.pdev); }
[Severity: High]
This isn't a bug introduced by this patch, but can this leak the hmem_test_device.work item when the cxl_test module unloads, leading to a potential use-after-free?
The hmem_test_device is statically allocated in the module. When the dax_hmem driver binds to this device, it queues hpdev->work on dax_hmem_wq.
On module unload, hmem_test_exit() unregisters the device but fails to call cancel_work_sync() or flush_work(). The device release callback zeroes out the structure while the work might still be queued. Since the module memory is then freed, the workqueue will access freed memory when it eventually processes the work item.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Re: [PATCH v5 1/6] cxl/test: Add test for module parameters
In reply to Dave JiangQuoted 2 lines · Dave Jiang
Add a test for module paraters during module init to make sure that only one is activated.
"paraters" -> "parameters".
Quoted 17 lines
Suggested-by Alison Schofield <[email protected]>Signed-off-by Dave Jiang <[email protected]>---
v5:
- Add test forhmem_testmodule parameters. (sashiko)--- tools/testing/cxl/test/cxl.c | 20 ++++++++++++++++++++ tools/testing/cxl/test/hmem_test.c | 3 ++- tools/testing/cxl/test/mock.h | 2 ++ 3 files changed, 24 insertions(+), 1 deletion(-)tools/testing/cxl/test/cxl.c +0
-0
tools/testing/cxl/test/cxl.c static struct attribute *cxl_acpi_attrs[] = { · line 1822
Quoted 9 lines
tools/testing/cxl/test/cxl.c +6
-0@@ -1814,11 +1814,31 @@ static struct attribute *cxl_acpi_attrs[] = { };ATTRIBUTE_GROUPS (cxl_acpi); +static bool __init have_multiple_modparms (void ) +{ +int count =0 ; + +if (interleave_arithmetic) + count++;
Should we make it a boolean ?
It should only work with 0 or 1 right ?
--Richard
Quoted 54 lines
tools/testing/cxl/test/cxl.c +14
-0+if (extended_linear_cache) + count++; +if (fail_autoassemble) + count++; +if (hmem_test) + count++; + +return count >1 ; +} +static __init int cxl_test_init (void ) {int rc, i;struct range mappable; +/* Enforce a single module param active at a time */ +if (have_multiple_modparms ()) +return -EINVAL ; +cxl_acpi_test ();cxl_core_test ();cxl_mem_test ();tools/testing/cxl/test/hmem_test.c +2
-1@@ -3,8 +3,9 @@#include <linux/moduleparam.h> #include <linux/workqueue.h> #include "../../../drivers/dax/bus.h" +#include "mock.h" -static bool hmem_test; +bool hmem_test;static void hmem_test_work (struct work_struct *work) {tools/testing/cxl/test/mock.h +2
-0@@ -5,6 +5,8 @@#include <linux/dax.h> #include <cxl.h> +extern bool hmem_test; +struct cxl_mock_ops {struct list_head list;bool (*is_mock_adev)(struct acpi_device *dev);Signature · 1 line
2.54.0
Dave Jiang
maintainerRe: [PATCH v5 1/6] cxl/test: Add test for module parameters
Quoted 5 lines · Richard Cheng
Quoted 2 lines · Dave Jiang
Add a test for module paraters during module init to make sure that only one is activated.
"paraters" -> "parameters".
ok
Quoted 21 lines
Quoted 21 lines
Suggested-by Alison Schofield <[email protected]>Signed-off-by Dave Jiang <[email protected]>---
v5:
- Add test forhmem_testmodule parameters. (sashiko)--- tools/testing/cxl/test/cxl.c | 20 ++++++++++++++++++++ tools/testing/cxl/test/hmem_test.c | 3 ++- tools/testing/cxl/test/mock.h | 2 ++ 3 files changed, 24 insertions(+), 1 deletion(-)tools/testing/cxl/test/cxl.c +0
-0@@ -1814,11 +1814,31 @@ static struct attribute *cxl_acpi_attrs[] = { };ATTRIBUTE_GROUPS (cxl_acpi);
Quoted 9 lines
tools/testing/cxl/test/cxl.c static struct attribute *cxl_acpi_attrs[] = { · line 1822
Quoted 6 lines
tools/testing/cxl/test/cxl.c +6
-0+static bool __init have_multiple_modparms (void ) +{ +int count =0 ; + +if (interleave_arithmetic) + count++;Should we make it a boolean ?
It should only work with 0 or 1 right ?
I don't follow. The intention is that if there are >1 parameters then it fails.
DJ
Quoted 57 lines
--Richard
Quoted 54 lines
tools/testing/cxl/test/cxl.c +14
-0+if (extended_linear_cache) + count++; +if (fail_autoassemble) + count++; +if (hmem_test) + count++; + +return count >1 ; +} +static __init int cxl_test_init (void ) {int rc, i;struct range mappable; +/* Enforce a single module param active at a time */ +if (have_multiple_modparms ()) +return -EINVAL ; +cxl_acpi_test ();cxl_core_test ();cxl_mem_test ();tools/testing/cxl/test/hmem_test.c +2
-1@@ -3,8 +3,9 @@#include <linux/moduleparam.h> #include <linux/workqueue.h> #include "../../../drivers/dax/bus.h" +#include "mock.h" -static bool hmem_test; +bool hmem_test;static void hmem_test_work (struct work_struct *work) {tools/testing/cxl/test/mock.h +2
-0@@ -5,6 +5,8 @@#include <linux/dax.h> #include <cxl.h> +extern bool hmem_test; +struct cxl_mock_ops {struct list_head list;bool (*is_mock_adev)(struct acpi_device *dev);Signature · 1 line
2.54.0
Dave Jiang
maintainerPATCH v5 2/6 cxl/test: Add type2 support for mock CFMWS0
In reply to Dave JiangAdd a module parameter 'type2_test' for triggering type2 test support in cxl_test. Setup the CFMWS0 configuration to be type2 when 'type2_test' is set.
--- tools/testing/cxl/test/cxl.c | 29 ++++++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-)
tools/testing/cxl/test/cxl.c +28 -1
@@ -17,6 +17,7 @@static int interleave_arithmetic;static bool extended_linear_cache;static bool fail_autoassemble; +static bool type2_test;#define FAKE_QTG_ID 42
@@ -384,6 +385,19 @@ static struct { }, }; +static struct acpi_cedt_cfmws type2_cfmws0 = { + .header = { + .type =ACPI_CEDT_TYPE_CFMWS , + .length =sizeof (mock_cedt.cfmws0), + }, + .interleave_ways =0 , + .granularity =4 , + .restrictions =ACPI_CEDT_CFMWS_RESTRICT_DEVMEM | +ACPI_CEDT_CFMWS_RESTRICT_VOLATILE , + .qtg_id =FAKE_QTG_ID , + .window_size =SZ_256M *4 , +}; +struct acpi_cedt_cfmws *mock_cfmws[] = { [0 ] = &mock_cedt.cfmws0.cfmws, [1 ] = &mock_cedt.cfmws1.cfmws,
@@ -472,6 +486,11 @@ static void cfmws_elc_update(struct acpi_cedt_cfmws *window, int index) window->window_size = mock_auto_region_size *2 ; } +static void update_type2_cfmws (void ) +{ +memcpy (&mock_cedt.cfmws0.cfmws, &type2_cfmws0,sizeof (type2_cfmws0)); +} +static int populate_cedt (void ) {struct cxl_mock_res *res;
@@ -493,10 +512,14 @@ static int populate_cedt(void) chbs->length = size; } +if (type2_test) +update_type2_cfmws (); +for (i = cfmws_start; i <= cfmws_end; i++) {struct acpi_cedt_cfmws *window = mock_cfmws[i]; -cfmws_elc_update (window, i); +if (i ==0 && !type2_test) +cfmws_elc_update (window, i); res =alloc_mock_res (window->window_size,SZ_256M );if (!res)return -ENOMEM ;
@@ -1826,6 +1849,8 @@ static bool __init have_multiple_modparms(void) count++;if (hmem_test) count++; +if (type2_test) + count++;return count >1 ; }
@@ -2050,6 +2075,8 @@ module_param(extended_linear_cache, bool, 0444);MODULE_PARM_DESC (extended_linear_cache,"Enable extended linear cache support" );module_param (fail_autoassemble, bool,0444 );MODULE_PARM_DESC (fail_autoassemble,"Simulate missing member of an auto-region" ); +module_param (type2_test, bool,0444 ); +MODULE_PARM_DESC (type2_test,"Enable type 2 support testing" );module_init (cxl_test_init);module_exit (cxl_test_exit);MODULE_LICENSE ("GPL v2" );
Signature · 1 line
2.54.0
[email protected]
AI reviewRe: [PATCH v5 2/6] cxl/test: Add type2 support for mock CFMWS0
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] alloc_mock_res() unconditionally dereferences res even if kzalloc() fails, and leaks res if gen_pool_alloc_algo() fails. --
commit e10eed6f5b8f0ab41fd5d070bd75f2b5f0d1bef4
Author: Dave Jiang <[email protected]>
cxl/test: Add type2 support for mock CFMWS0
This commit adds a type2_test module parameter for triggering type 2 test support in cxl_test. It also updates the CFMWS0 configuration to be type 2 when the parameter is set.
Quoted 4 lines
tools/testing/cxl/test/cxl.c +0
-0
[ ... ]
Quoted 4 lines
tools/testing/cxl/test/cxl.c +0
-0@@ -493,10 +512,14 @@ static int populate_cedt(void) chbs->length = size; }
tools/testing/cxl/test/cxl.c static int populate_cedt(void) · line 523
Quoted 10 lines
tools/testing/cxl/test/cxl.c +5
-1+if (type2_test) +update_type2_cfmws (); +for (i = cfmws_start; i <= cfmws_end; i++) {struct acpi_cedt_cfmws *window = mock_cfmws[i]; -cfmws_elc_update (window, i); +if (i ==0 && !type2_test) +cfmws_elc_update (window, i); res =alloc_mock_res (window->window_size,SZ_256M );
[Severity: High]
This is a pre-existing issue, but I noticed a potential problem in alloc_mock_res() which is called here.
Does alloc_mock_res() unconditionally dereference the allocation before checking for success? Looking at the function:
alloc_mock_res() {
struct cxl_mock_res *res = kzalloc(sizeof(*res), GFP_KERNEL);
...
INIT_LIST_HEAD(&res->list);
}If kzalloc() returns NULL, won't INIT_LIST_HEAD() cause an immediate NULL pointer dereference?
Additionally, if the subsequent memory pool allocation fails:
alloc_mock_res() {
...
phys = gen_pool_alloc_algo(cxl_mock_pool, size,
gen_pool_first_fit_align, &data);
if (!phys)
return NULL;
}Does this leak the memory allocated for res by returning NULL without calling kfree(res)?
Quoted 2 lines
tools/testing/cxl/test/cxl.c +0
-0if (!res)return -ENOMEM ;
[ ... ]
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
Dave Jiang
maintainerPATCH v5 3/6 cxl/test: Refactor platform device enumerations
In reply to Dave JiangSplit all the host bridges, rootports, upstream and downstream ports enumerations to separate helper functions. This should make adding type2 hierarchy easier later on.
--- tools/testing/cxl/test/cxl.c | 312 ++++++++++++++++++++++++----------- 1 file changed, 214 insertions(+), 98 deletions(-)
tools/testing/cxl/test/cxl.c +214 -98
@@ -1855,10 +1855,204 @@ static bool __init have_multiple_modparms(void)return count >1 ; } +static void host_bridges_remove (void ) +{ +int i; + +for (i =ARRAY_SIZE (cxl_host_bridge) -1 ; i >=0 ; i--) { +struct platform_device *pdev = cxl_host_bridge[i]; + +if (!pdev) +continue ; + +sysfs_remove_link (&pdev->dev.kobj,"physical_node" ); +platform_device_unregister (cxl_host_bridge[i]); + } +} + +static int host_bridges_populate (void ) +{ +int rc =0 ; + +for (int i =0 ; i <ARRAY_SIZE (cxl_host_bridge); i++) { +struct acpi_device *adev = &host_bridge[i]; +struct platform_device *pdev; + + pdev =platform_device_alloc ("cxl_host_bridge" , i); +if (!pdev) { + rc = -ENOMEM ; + goto err_bridge; + } + +mock_companion (adev, &pdev->dev); + rc =cxl_mock_platform_device_add (pdev, &cxl_host_bridge[i]); +if (rc) + goto err_bridge; + + mock_pci_bus[i].bridge = &pdev->dev; + rc =sysfs_create_link (&pdev->dev.kobj, &pdev->dev.kobj, +"physical_node" ); +if (rc) + goto err_bridge; + } + +return 0 ; + +err_bridge: +host_bridges_remove (); +return rc; +} + +static void cxl_rootports_remove (void ) +{ +for (int i =ARRAY_SIZE (cxl_root_port) -1 ; i >=0 ; i--) { +struct platform_device *pdev = cxl_root_port[i]; + +if (!pdev) +continue ; + +platform_device_unregister (pdev); + } +} + +static int cxl_rootports_populate (void ) +{ +int rc =0 ; + +for (int i =0 ; i <ARRAY_SIZE (cxl_root_port); i++) { +struct platform_device *bridge = + cxl_host_bridge[i %ARRAY_SIZE (cxl_host_bridge)]; +struct platform_device *pdev; + + pdev =platform_device_alloc ("cxl_root_port" , i); +if (!pdev) { + rc = -ENOMEM ; + goto err_port; + } + + pdev->dev.parent = &bridge->dev; + + rc =cxl_mock_platform_device_add (pdev, &cxl_root_port[i]); +if (rc) + goto err_port; + } + +return 0 ; + +err_port: +cxl_rootports_remove (); +return rc; +} + +static void cxl_usps_remove (void ) +{ +for (int i =ARRAY_SIZE (cxl_switch_uport) -1 ; i >=0 ; i--) { +struct platform_device *pdev = cxl_switch_uport[i]; + +if (!pdev) +continue ; + +platform_device_unregister (cxl_switch_uport[i]); + } +} + +static int cxl_usps_populate (void ) +{ +int rc =0 ; + +for (int i =0 ; i <ARRAY_SIZE (cxl_switch_uport); i++) { +struct platform_device *root_port = cxl_root_port[i]; +struct platform_device *pdev; + + pdev =platform_device_alloc ("cxl_switch_uport" , i); +if (!pdev) { + rc = -ENOMEM ; + goto err_uport; + } + + pdev->dev.parent = &root_port->dev; + + rc =cxl_mock_platform_device_add (pdev, &cxl_switch_uport[i]); +if (rc) + goto err_uport; + } + +return 0 ; + +err_uport: +cxl_usps_remove (); +return rc; +} + +static void cxl_dsps_remove (void ) +{ +for (int i =ARRAY_SIZE (cxl_switch_dport) -1 ; i >=0 ; i--) { +struct platform_device *pdev = cxl_switch_dport[i]; + +if (!pdev) +continue ; + +platform_device_unregister (cxl_switch_dport[i]); + } +} + + +static int cxl_dsps_populate (void ) +{ +int rc =0 ; + +for (int i =0 ; i <ARRAY_SIZE (cxl_switch_dport); i++) { +struct platform_device *uport = + cxl_switch_uport[i %ARRAY_SIZE (cxl_switch_uport)]; +struct platform_device *pdev; + + pdev =platform_device_alloc ("cxl_switch_dport" , i); +if (!pdev) { + rc = -ENOMEM ; + goto err_dport; + } + pdev->dev.parent = &uport->dev; + + rc =cxl_mock_platform_device_add (pdev, &cxl_switch_dport[i]); +if (rc) + goto err_dport; + } + +return 0 ; + +err_dport: +cxl_dsps_remove (); +return rc; +} + +static void cxl_switches_remove (void ) +{ +cxl_dsps_remove (); +cxl_usps_remove (); +} + +static int cxl_switches_populate (void ) +{ +int rc; + +BUILD_BUG_ON (ARRAY_SIZE (cxl_switch_uport) !=ARRAY_SIZE (cxl_root_port)); + rc =cxl_usps_populate (); +if (rc) +return rc; + + rc =cxl_dsps_populate (); +if (rc) { +cxl_usps_remove (); +return rc; + } + +return 0 ; +} +static __init int cxl_test_init (void ) { -int rc, i;struct range mappable; +int rc;/* Enforce a single module param active at a time */ if (have_multiple_modparms ())
@@ -1898,74 +2092,21 @@ static __init int cxl_test_init(void)if (rc) goto err_populate; -for (i =0 ; i <ARRAY_SIZE (cxl_host_bridge); i++) { -struct acpi_device *adev = &host_bridge[i]; -struct platform_device *pdev; + rc =host_bridges_populate (); +if (rc) + goto err_populate; - pdev =platform_device_alloc ("cxl_host_bridge" , i); -if (!pdev) - goto err_bridge; + rc =cxl_rootports_populate (); +if (rc) + goto err_host_bridges; -mock_companion (adev, &pdev->dev); - rc =cxl_mock_platform_device_add (pdev, &cxl_host_bridge[i]); -if (rc) - goto err_bridge; - - mock_pci_bus[i].bridge = &pdev->dev; - rc =sysfs_create_link (&pdev->dev.kobj, &pdev->dev.kobj, -"physical_node" ); -if (rc) - goto err_bridge; - } - -for (i =0 ; i <ARRAY_SIZE (cxl_root_port); i++) { -struct platform_device *bridge = - cxl_host_bridge[i %ARRAY_SIZE (cxl_host_bridge)]; -struct platform_device *pdev; - - pdev =platform_device_alloc ("cxl_root_port" , i); -if (!pdev) - goto err_port; - pdev->dev.parent = &bridge->dev; - - rc =cxl_mock_platform_device_add (pdev, &cxl_root_port[i]); -if (rc) - goto err_port; - } - -BUILD_BUG_ON (ARRAY_SIZE (cxl_switch_uport) !=ARRAY_SIZE (cxl_root_port)); -for (i =0 ; i <ARRAY_SIZE (cxl_switch_uport); i++) { -struct platform_device *root_port = cxl_root_port[i]; -struct platform_device *pdev; - - pdev =platform_device_alloc ("cxl_switch_uport" , i); -if (!pdev) - goto err_uport; - pdev->dev.parent = &root_port->dev; - - rc =cxl_mock_platform_device_add (pdev, &cxl_switch_uport[i]); -if (rc) - goto err_uport; - } - -for (i =0 ; i <ARRAY_SIZE (cxl_switch_dport); i++) { -struct platform_device *uport = - cxl_switch_uport[i %ARRAY_SIZE (cxl_switch_uport)]; -struct platform_device *pdev; - - pdev =platform_device_alloc ("cxl_switch_dport" , i); -if (!pdev) - goto err_dport; - pdev->dev.parent = &uport->dev; - - rc =cxl_mock_platform_device_add (pdev, &cxl_switch_dport[i]); -if (rc) - goto err_dport; - } + rc =cxl_switches_populate (); +if (rc) + goto err_root_ports; rc =cxl_single_topo_init ();if (rc) - goto err_dport; + goto err_switches; rc =cxl_rch_topo_init ();if (rc)
@@ -2001,24 +2142,12 @@ static __init int cxl_test_init(void)cxl_rch_topo_exit (); err_single:cxl_single_topo_exit (); -err_dport: -for (i =ARRAY_SIZE (cxl_switch_dport) -1 ; i >=0 ; i--) -platform_device_unregister (cxl_switch_dport[i]); -err_uport: -for (i =ARRAY_SIZE (cxl_switch_uport) -1 ; i >=0 ; i--) -platform_device_unregister (cxl_switch_uport[i]); -err_port: -for (i =ARRAY_SIZE (cxl_root_port) -1 ; i >=0 ; i--) -platform_device_unregister (cxl_root_port[i]); -err_bridge: -for (i =ARRAY_SIZE (cxl_host_bridge) -1 ; i >=0 ; i--) { -struct platform_device *pdev = cxl_host_bridge[i]; - -if (!pdev) -continue ; -sysfs_remove_link (&pdev->dev.kobj,"physical_node" ); -platform_device_unregister (cxl_host_bridge[i]); - } +err_switches: +cxl_switches_remove (); +err_root_ports: +cxl_rootports_remove (); +err_host_bridges: +host_bridges_remove (); err_populate:depopulate_all_mock_resources (); err_gen_pool_add:
@@ -2041,27 +2170,14 @@ static void free_decoder_registry(void) static __exit void cxl_test_exit(void) { -int i; -hmem_test_exit ();cxl_mem_exit ();platform_device_unregister (cxl_acpi);cxl_rch_topo_exit ();cxl_single_topo_exit (); -for (i =ARRAY_SIZE (cxl_switch_dport) -1 ; i >=0 ; i--) -platform_device_unregister (cxl_switch_dport[i]); -for (i =ARRAY_SIZE (cxl_switch_uport) -1 ; i >=0 ; i--) -platform_device_unregister (cxl_switch_uport[i]); -for (i =ARRAY_SIZE (cxl_root_port) -1 ; i >=0 ; i--) -platform_device_unregister (cxl_root_port[i]); -for (i =ARRAY_SIZE (cxl_host_bridge) -1 ; i >=0 ; i--) { -struct platform_device *pdev = cxl_host_bridge[i]; - -if (!pdev) -continue ; -sysfs_remove_link (&pdev->dev.kobj,"physical_node" ); -platform_device_unregister (cxl_host_bridge[i]); - } +cxl_switches_remove (); +cxl_rootports_remove (); +host_bridges_remove ();depopulate_all_mock_resources ();gen_pool_destroy (cxl_mock_pool);unregister_cxl_mock_ops (&cxl_mock_ops);
Signature · 1 line
2.54.0
Dave Jiang
maintainerPATCH v5 4/6 cxl/test: Add hierarchy enumeration support for type2 device
In reply to Dave JiangAdd enumeration of type2 device hierarchy in cxl-test. The type2 device is setup to be directly attached to a root port instead of rp -> switch -> device that type3 hierarchy is setup..
---
v5:
- Reverse device teardown (sashiko)
- Don't put device on platform device add. (sashiko)
--- tools/testing/cxl/test/cxl.c | 238 ++++++++++++++++++++++++++++------- 1 file changed, 192 insertions(+), 46 deletions(-)
tools/testing/cxl/test/cxl.c +192 -46
@@ -28,6 +28,7 @@ static bool type2_test;#define NR_CXL_SWITCH_PORTS 2#define NR_CXL_PORT_DECODERS 8#define NR_BRIDGES (NR_CXL_HOST_BRIDGES + NR_CXL_SINGLE_HOST + NR_CXL_RCH) +#define NR_CXL_TYPE2_ACCEL 1#define MOCK_AUTO_REGION_SIZE_DEFAULT SZ_512Mstatic int mock_auto_region_size =MOCK_AUTO_REGION_SIZE_DEFAULT ;
@@ -1734,19 +1735,93 @@ static void cxl_single_topo_exit(void) } } +static void cxl_type3_mem_exit (void ) +{ +struct platform_device *pdev; +int i; + +for (i =ARRAY_SIZE (cxl_rcd) -1 ; i >=0 ; i--) { + pdev = cxl_rcd[i]; +if (!pdev) +continue ; +platform_device_unregister (cxl_rcd[i]); + } + +for (i =ARRAY_SIZE (cxl_mem_single) -1 ; i >=0 ; i--) { + pdev = cxl_mem_single[i]; +if (!pdev) +continue ; +platform_device_unregister (cxl_mem_single[i]); + } + +for (i =ARRAY_SIZE (cxl_mem) -1 ; i >=0 ; i--) { + pdev = cxl_mem[i]; +if (!pdev) +continue ; +platform_device_unregister (pdev); + } +} + +static void cxl_type2_mem_exit (void ) +{ +for (int i =NR_CXL_TYPE2_ACCEL -1 ; i >=0 ; i--) { +struct platform_device *pdev = cxl_mem[i]; + +if (!pdev) +continue ; +platform_device_unregister (pdev); + } +} +static void cxl_mem_exit (void ) { -int i; - -for (i =ARRAY_SIZE (cxl_rcd) -1 ; i >=0 ; i--) -platform_device_unregister (cxl_rcd[i]); -for (i =ARRAY_SIZE (cxl_mem_single) -1 ; i >=0 ; i--) -platform_device_unregister (cxl_mem_single[i]); -for (i =ARRAY_SIZE (cxl_mem) -1 ; i >=0 ; i--) -platform_device_unregister (cxl_mem[i]); +if (type2_test) { +cxl_type2_mem_exit (); +return ; + } + +cxl_type3_mem_exit (); +} + +static int cxl_type2_mem_init (void ) +{ +int i, rc; + +for (i =0 ; i <NR_CXL_TYPE2_ACCEL ; i++) { +struct platform_device *dport = cxl_root_port[i]; +struct platform_device *pdev; + + pdev =platform_device_alloc ("cxl_type2_accel" , i); +if (!pdev) { + rc = -ENOMEM ; + goto err_mem; + } + pdev->dev.parent = &dport->dev; +set_dev_node (&pdev->dev, i %2 ); + + rc =platform_device_add (pdev); +if (rc) { + rc = -ENOMEM ; +platform_device_put (pdev); + goto err_mem; + } + cxl_mem[i] = pdev; + } + +return 0 ; + +err_mem: +for (i =NR_CXL_TYPE2_ACCEL -1 ; i >=0 ; i--) { +struct platform_device *pdev = cxl_mem[i]; + +if (!pdev) +continue ; +platform_device_unregister (pdev); + } +return rc; } -static int cxl_mem_init (void ) +static int cxl_type3_mem_init (void ) {int i, rc;
@@ -1755,8 +1830,10 @@ static int cxl_mem_init(void)struct platform_device *pdev; pdev =platform_device_alloc ("cxl_mem" , i); -if (!pdev) +if (!pdev) { + rc = -ENOMEM ; goto err_mem; + } pdev->dev.parent = &dport->dev;set_dev_node (&pdev->dev, i %2 );
@@ -1770,8 +1847,10 @@ static int cxl_mem_init(void)struct platform_device *pdev; pdev =platform_device_alloc ("cxl_mem" ,NR_MEM_MULTI + i); -if (!pdev) +if (!pdev) { + rc = -ENOMEM ; goto err_single; + } pdev->dev.parent = &dport->dev;set_dev_node (&pdev->dev, i %2 );
@@ -1786,8 +1865,10 @@ static int cxl_mem_init(void)struct platform_device *pdev; pdev =platform_device_alloc ("cxl_rcd" , idx); -if (!pdev) +if (!pdev) { + rc = -ENOMEM ; goto err_rcd; + } pdev->dev.parent = &rch->dev;set_dev_node (&pdev->dev, i %2 );
@@ -1810,6 +1891,13 @@ static int cxl_mem_init(void)return rc; } +static int cxl_mem_init (void ) +{ +if (type2_test) +return cxl_type2_mem_init (); +return cxl_type3_mem_init (); +} +static ssize_t decoder_reset_preserve_registry_show (struct device *dev,struct device_attribute *attr,char *buf)
@@ -2049,6 +2137,92 @@ static int cxl_switches_populate(void)return 0 ; } +static void cxl_type2_topo_exit (void ) +{ +cxl_rootports_remove (); +host_bridges_remove (); +} + +static int cxl_type2_topo_init (void ) +{ +int rc; + + rc =host_bridges_populate (); +if (rc) +return rc; + + rc =cxl_rootports_populate (); +if (rc) { +host_bridges_remove (); +return rc; + } + +return 0 ; +} + +static void cxl_type3_topo_exit (void ) +{ +cxl_rch_topo_exit (); +cxl_single_topo_exit (); +cxl_switches_remove (); +cxl_rootports_remove (); +host_bridges_remove (); +} + +static int cxl_type3_topo_init (void ) +{ +int rc; + + rc =host_bridges_populate (); +if (rc) +return rc; + + rc =cxl_rootports_populate (); +if (rc) + goto err_host_bridges; + + rc =cxl_switches_populate (); +if (rc) + goto err_root_ports; + + rc =cxl_single_topo_init (); +if (rc) + goto err_switches; + + rc =cxl_rch_topo_init (); +if (rc) + goto err_single; + +return 0 ; + +err_single: +cxl_single_topo_exit (); +err_switches: +cxl_switches_remove (); +err_root_ports: +cxl_rootports_remove (); +err_host_bridges: +host_bridges_remove (); +return rc; +} + +static void cxl_topo_exit (void ) +{ +if (type2_test) { +cxl_type2_topo_exit (); +return ; + } + +cxl_type3_topo_exit (); +} + +static int cxl_topo_init (void ) +{ +if (type2_test) +return cxl_type2_topo_init (); +return cxl_type3_topo_init (); +} +static __init int cxl_test_init (void ) {struct range mappable;
@@ -2092,29 +2266,13 @@ static __init int cxl_test_init(void)if (rc) goto err_populate; - rc =host_bridges_populate (); + rc =cxl_topo_init ();if (rc) goto err_populate; - rc =cxl_rootports_populate (); -if (rc) - goto err_host_bridges; - - rc =cxl_switches_populate (); -if (rc) - goto err_root_ports; - - rc =cxl_single_topo_init (); -if (rc) - goto err_switches; - - rc =cxl_rch_topo_init (); -if (rc) - goto err_single; - cxl_acpi =platform_device_alloc ("cxl_acpi" ,0 );if (!cxl_acpi) - goto err_rch; + goto err_topo;mock_companion (&acpi0017_mock, &cxl_acpi->dev); acpi0017_mock.dev.bus = &platform_bus_type;
@@ -2122,7 +2280,7 @@ static __init int cxl_test_init(void) rc =cxl_mock_platform_device_add (cxl_acpi,NULL );if (rc) - goto err_rch; + goto err_topo; rc =cxl_mem_init ();if (rc)
@@ -2138,16 +2296,8 @@ static __init int cxl_test_init(void)cxl_mem_exit (); err_root:platform_device_put (cxl_acpi); -err_rch: -cxl_rch_topo_exit (); -err_single: -cxl_single_topo_exit (); -err_switches: -cxl_switches_remove (); -err_root_ports: -cxl_rootports_remove (); -err_host_bridges: -host_bridges_remove (); +err_topo: +cxl_topo_exit (); err_populate:depopulate_all_mock_resources (); err_gen_pool_add:
@@ -2173,11 +2323,7 @@ static __exit void cxl_test_exit(void)hmem_test_exit ();cxl_mem_exit ();platform_device_unregister (cxl_acpi); -cxl_rch_topo_exit (); -cxl_single_topo_exit (); -cxl_switches_remove (); -cxl_rootports_remove (); -host_bridges_remove (); +cxl_topo_exit ();depopulate_all_mock_resources ();gen_pool_destroy (cxl_mock_pool);unregister_cxl_mock_ops (&cxl_mock_ops);
Signature · 1 line
2.54.0
Dave Jiang
maintainerPATCH v5 5/6 cxl/test: Fixup hdm init for auto region to support type2
In reply to Dave JiangAdd support to setup initialization of decoders in order to support type2 auto region.
--- tools/testing/cxl/test/cxl.c | 255 +++++++++++++++++++++++++---------- 1 file changed, 186 insertions(+), 69 deletions(-)
tools/testing/cxl/test/cxl.c +186 -69
@@ -1077,74 +1077,26 @@ static int first_decoder(struct device *dev, const void *data)return 0 ; } -/* -* Initialize a decoder during HDM enumeration. -* -* If a saved registry entry exists: -* - enabled decoders are restored from the saved programming -* - disabled decoders are initialized in a clean disabled state -* -* If no registry entry exists the decoder follows the normal mock -* initialization path, including the special auto-region setup for -* the first endpoints under host-bridge0. -* -* Returns true if decoder state was restored from the registry. In -* that case the saved decode configuration (including target mapping) -* has already been applied and the map_targets() is skipped. -*/ -static bool mock_init_hdm_decoder (struct cxl_decoder *cxld) +enum cxld_init_type { +MOCK_DECODER_INIT_DEFAULT , +MOCK_DECODER_INIT_SAVED , +MOCK_DECODER_INIT_TYPE3_AUTO , +MOCK_DECODER_INIT_TYPE2_AUTO , +}; + +static enum cxld_init_type get_decoder_init_type (struct cxl_decoder *cxld, +struct platform_device *pdev, +bool hb0, +struct cxl_test_decoder **td) { -struct acpi_cedt_cfmws *window = mock_cfmws[0 ]; -struct platform_device *pdev =NULL ; -struct cxl_endpoint_decoder *cxled; -struct cxl_switch_decoder *cxlsd; -struct cxl_port *port, *iter; -struct cxl_test_decoder *td; -struct cxl_memdev *cxlmd; -struct cxl_dport *dport; -struct device *dev; -bool hb0 = false; -u64 base; -int i; +struct cxl_test_decoder *found_td =cxld_registry_find (cxld); -if (is_endpoint_decoder (&cxld->dev)) { - cxled =to_cxl_endpoint_decoder (&cxld->dev); - cxlmd =cxled_to_memdev (cxled); -WARN_ON (!dev_is_platform (cxlmd->dev.parent)); - pdev =to_platform_device (cxlmd->dev.parent); - -/* check is endpoint is attach to host-bridge0 */ - port =cxled_to_port (cxled); -do { -if (port->uport_dev == &cxl_host_bridge[0 ]->dev) { - hb0 = true; -break ; - } -if (is_cxl_port (port->dev.parent)) - port =to_cxl_port (port->dev.parent); -else - port =NULL ; - }while (port); - port =cxled_to_port (cxled); - }else { - port =to_cxl_port (cxld->dev.parent); +if (found_td) { + *td = found_td; +return MOCK_DECODER_INIT_SAVED ; } - td =cxld_registry_find (cxld); -if (td) { -bool enabled; - -if (is_switch_decoder (&cxld->dev)) - enabled = td->cxlsd.cxld.flags &CXL_DECODER_F_ENABLE ; -else - enabled = td->cxled.cxld.flags &CXL_DECODER_F_ENABLE ; - -if (enabled) -return !cxld_registry_restore (cxld, td); - -init_disabled_mock_decoder (cxld); -return false; - } + *td =NULL ;/* * The first decoder on the first 2 devices on the first switch
@@ -1155,15 +1107,111 @@ static bool mock_init_hdm_decoder(struct cxl_decoder *cxld)* See 'cxl list -BMPu -m cxl_mem.0,cxl_mem.4' */ if (!is_endpoint_decoder (&cxld->dev) || !hb0 || pdev->id %4 || - pdev->id >4 || cxld->id >0 ) { -default_mock_decoder (cxld); -return false; - } + pdev->id >4 || cxld->id >0 ) +return MOCK_DECODER_INIT_DEFAULT ; + +return type2_test ?MOCK_DECODER_INIT_TYPE2_AUTO : +MOCK_DECODER_INIT_TYPE3_AUTO ; +} + +static bool mock_decoder_handle_saved (struct cxl_decoder *cxld,struct cxl_test_decoder *td) +{ +bool enabled; + +if (is_switch_decoder (&cxld->dev)) + enabled = td->cxlsd.cxld.flags &CXL_DECODER_F_ENABLE ; +else + enabled = td->cxled.cxld.flags &CXL_DECODER_F_ENABLE ; + +if (enabled) +return !cxld_registry_restore (cxld, td); + +init_disabled_mock_decoder (cxld); +return false; +} + +static void mock_init_hdm_type2_cxled (struct cxl_endpoint_decoder *cxled, +struct cxl_port *port, +struct platform_device *pdev) +{ +struct acpi_cedt_cfmws *window = mock_cfmws[0 ]; +struct cxl_decoder *cxld = &cxled->cxld; +struct cxl_switch_decoder *cxlsd; +struct cxl_dport *dport; +struct cxl_port *root_port; +struct device *dev; +u64 base; + + base = window->base_hpa; + cxld->hpa_range = (struct range ) { + .start = base, + .end = base + mock_auto_region_size -1 , + }; + + cxld->interleave_ways =1 ; +eig_to_granularity (window->granularity, &cxld->interleave_granularity); + cxld->target_type =CXL_DECODER_DEVMEM ; + cxld->flags =CXL_DECODER_F_ENABLE ; + cxled->state =CXL_DECODER_STATE_AUTO ; + port->commit_end = cxld->id; +devm_cxl_dpa_reserve (cxled,0 , + mock_auto_region_size / cxld->interleave_ways,0 ); + cxld->commit = mock_decoder_commit; + cxld->reset = mock_decoder_reset; + +WARN_ON_ONCE (!cxld_registry_new (cxld)); +/* +* Now that endpoint decoder is set up, walk up the hierarchy +* and setup the root port decoder targeting @cxlmd. +*/ + dport = port->parent_dport; + root_port = dport->port; + dev =device_find_child (&root_port->dev,NULL , first_decoder); +/* +* Ancestor ports are guaranteed to be enumerated before +* @port, and all ports have at least one decoder. +*/ +if (WARN_ON (!dev)) +return ; + + cxlsd =to_cxl_switch_decoder (dev); + cxlsd->target[0 ] = dport; + cxlsd->cxld.target_map[0 ] = dport->port_id; + cxld = &cxlsd->cxld; + cxld->target_type =CXL_DECODER_DEVMEM ; + cxld->flags =CXL_DECODER_F_ENABLE ; + root_port->commit_end =0 ; + cxld->interleave_ways =1 ; + cxld->interleave_granularity =4096 ; + cxld->hpa_range = (struct range ) { + .start = base, + .end = base + mock_auto_region_size -1 , + }; + cxld->commit = mock_decoder_commit; + cxld->reset = mock_decoder_reset; + +cxld_registry_update (cxld); +put_device (dev); +} + +static void mock_init_hdm_type3_cxled (struct cxl_endpoint_decoder *cxled, +struct cxl_port *port, +struct platform_device *pdev, +bool hb0) +{ +struct acpi_cedt_cfmws *window = mock_cfmws[0 ]; +struct cxl_decoder *cxld = &cxled->cxld; +struct cxl_switch_decoder *cxlsd; +struct cxl_dport *dport; +struct cxl_port *iter; +struct device *dev; +u64 base; +int i;/* Simulate missing cxl_mem.4 configuration */ if (hb0 && pdev->id ==4 && cxld->id ==0 && fail_autoassemble) {default_mock_decoder (cxld); -return false; +return ; } base = window->base_hpa;
@@ -1239,7 +1287,76 @@ static bool mock_init_hdm_decoder(struct cxl_decoder *cxld)cxld_registry_update (cxld);put_device (dev); } +} +/* +* Initialize a decoder during HDM enumeration. +* +* If a saved registry entry exists: +* - enabled decoders are restored from the saved programming +* - disabled decoders are initialized in a clean disabled state +* +* If no registry entry exists the decoder follows the normal mock +* initialization path, including the special auto-region setup for +* the first endpoints under host-bridge0. +* +* Returns true if decoder state was restored from the registry. In +* that case the saved decode configuration (including target mapping) +* has already been applied and the map_targets() is skipped. +*/ +static bool mock_init_hdm_decoder (struct cxl_decoder *cxld) +{ +struct cxl_endpoint_decoder *cxled =NULL ; +struct platform_device *pdev =NULL ; +struct cxl_test_decoder *td; +struct cxl_memdev *cxlmd; +struct cxl_port *port; +bool hb0 = false; + +if (is_endpoint_decoder (&cxld->dev)) { + cxled =to_cxl_endpoint_decoder (&cxld->dev); + cxlmd =cxled_to_memdev (cxled); +WARN_ON (!dev_is_platform (cxlmd->dev.parent)); + pdev =to_platform_device (cxlmd->dev.parent); + +/* check is endpoint is attach to host-bridge0 */ + port =cxled_to_port (cxled); +do { +if (port->uport_dev == &cxl_host_bridge[0 ]->dev) { + hb0 = true; +break ; + } +if (is_cxl_port (port->dev.parent)) + port =to_cxl_port (port->dev.parent); +else + port =NULL ; + }while (port); + port =cxled_to_port (cxled); + }else { + port =to_cxl_port (cxld->dev.parent); + } + +switch (get_decoder_init_type (cxld, pdev, hb0, &td)) { +case MOCK_DECODER_INIT_SAVED : +if (WARN_ON (!td)) +return false; +return mock_decoder_handle_saved (cxld, td); +case MOCK_DECODER_INIT_DEFAULT : +/* +* The default path picks up all the decoders that are not +* endpoint. +*/ +default_mock_decoder (cxld); +return false; +case MOCK_DECODER_INIT_TYPE3_AUTO : +mock_init_hdm_type3_cxled (cxled, port, pdev, hb0); +return false; +case MOCK_DECODER_INIT_TYPE2_AUTO : +mock_init_hdm_type2_cxled (cxled, port, pdev); +return false; +default : +return false; + }return false; }
Signature · 1 line
2.54.0
Dave Jiang
maintainerPATCH v5 6/6 cxl/test: Add cxl_test accelerator driver
In reply to Dave JiangAdd a type2 accelerator mock driver for the platform device that simulates a CXL type2 device. The driver exercises the same minimal API calls that a real CXL type2 driver would utilize.
--- tools/testing/cxl/test/Kbuild | 2 ++ tools/testing/cxl/test/accel.c | 66 ++++++++++++++++++++++++++++++++++ 2 files changed, 68 insertions(+) create mode 100644 tools/testing/cxl/test/accel.c
tools/testing/cxl/test/Kbuild +2 -0
@@ -5,10 +5,12 @@ obj-m += cxl_test.o obj-m += cxl_mock.o obj-m += cxl_mock_mem.o obj-m += cxl_translate.o +obj-m += cxl_mock_accel.o cxl_test-y := cxl.o cxl_test-y += hmem_test.o cxl_mock-y := mock.o cxl_mock_mem-y := mem.o +cxl_mock_accel-y := accel.o KBUILD_CFLAGS := $(filter-out -Wmissing-prototypes -Wmissing-declarations, $(KBUILD_CFLAGS))
tools/testing/cxl/test/accel.c new file +66 -0
66 lines not on this page · raw message
Signature · 1 line
2.54.0
[email protected]
AI reviewRe: [PATCH v5 6/6] cxl/test: Add cxl_test accelerator driver
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The patch invokes non-existent functions `cxl_set_capacity()` and `devm_cxl_probe_mem()`, resulting…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch invokes non-existent functions cxl_set_capacity() and devm_cxl_probe_mem(), resulting in a build failure. --
commit b886732115c0a94e1bae2a16b1299055ba5c99ea
Author: Dave Jiang <[email protected]>
cxl/test: Add cxl_test accelerator driver
Add a type2 accelerator mock driver for the platform device that simulates a CXL type2 device.
Quoted 5 lines
tools/testing/cxl/test/accel.c new file +0
-0
[ ... ]
Quoted 2 lines
tools/testing/cxl/test/accel.c new file +2
-0+static int cxl_mock_accel_probe (struct platform_device *pdev) +{
[ ... ]
tools/testing/cxl/test/accel.c line 38
Quoted 7 lines
tools/testing/cxl/test/accel.c new file +7
-0+ cxlds = &cxl_accel->cxlds; + cxlds->media_ready = true; + rc =cxl_set_capacity (cxlds,SZ_512M ); +if (rc) +return rc; + + cxlmd =devm_cxl_probe_mem (cxlds, &mock_range);
[Severity: Low]
Does this code cause a build failure?
It appears that cxl_set_capacity() and devm_cxl_probe_mem() are not defined anywhere in the CXL core subsystem, which would lead to unresolved symbol errors during compilation.
Quoted 3 lines
tools/testing/cxl/test/accel.c new file +3
-0+if (IS_ERR (cxlmd)) +return PTR_ERR (cxlmd); + cxl_accel->cxlmd = cxlmd;
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6
Re: [PATCH v5 6/6] cxl/test: Add cxl_test accelerator driver
Quoted 32 lines · On Thu, Jun 11, 2026 at 11:58:05PM +0800, [email protected] wrote:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch invokes non-existent functionscxl_set_capacity()anddevm_cxl_probe_mem(), resulting in a build failure. --commit
b886732115c0a94e1bae2a16b1299055ba5c99ea
Author: Dave Jiang <[email protected]>cxl/test: Add
cxl_testaccelerator driverAdd a type2 accelerator mock driver for the platform device that simulates a CXL type2 device.
Quoted 5 lines
tools/testing/cxl/test/accel.c new file +0
-0[ ... ]
Quoted 2 lines
tools/testing/cxl/test/accel.c new file +2
-0+static int cxl_mock_accel_probe (struct platform_device *pdev) +{[ ... ]
tools/testing/cxl/test/accel.c line 38
Quoted 7 lines
tools/testing/cxl/test/accel.c new file +7
-0+ cxlds = &cxl_accel->cxlds; + cxlds->media_ready = true; + rc =cxl_set_capacity (cxlds,SZ_512M ); +if (rc) +return rc; + + cxlmd =devm_cxl_probe_mem (cxlds, &mock_range);[Severity: Low]
Does this code cause a build failure?
Quoted 11 lines
It appears that
cxl_set_capacity()anddevm_cxl_probe_mem()are not defined anywhere in the CXL core subsystem, which would lead to unresolved symbol errors during compilation.Quoted 3 lines
tools/testing/cxl/test/accel.c new file +3
-0+if (IS_ERR (cxlmd)) +return PTR_ERR (cxlmd); + cxl_accel->cxlmd = cxlmd;Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6
This should be a false positive. devm_cxl_probe_mem() is introduced by Dan's series. cxl_set_capacity() is from Alejandro's series.
--Richard
Dave Jiang
maintainerRe: [PATCH v5 6/6] cxl/test: Add cxl_test accelerator driver
Quoted 45 lines · Richard Cheng
Quoted 32 lines · On Thu, Jun 11, 2026 at 11:58:05PM +0800, [email protected] wrote:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch invokes non-existent functionscxl_set_capacity()anddevm_cxl_probe_mem(), resulting in a build failure. --commit
b886732115c0a94e1bae2a16b1299055ba5c99ea
Author: Dave Jiang <[email protected]>cxl/test: Add
cxl_testaccelerator driverAdd a type2 accelerator mock driver for the platform device that simulates a CXL type2 device.
Quoted 5 lines
tools/testing/cxl/test/accel.c new file +0
-0[ ... ]
Quoted 2 lines
tools/testing/cxl/test/accel.c new file +2
-0+static int cxl_mock_accel_probe (struct platform_device *pdev) +{[ ... ]
tools/testing/cxl/test/accel.c line 38
Quoted 7 lines
tools/testing/cxl/test/accel.c new file +7
-0+ cxlds = &cxl_accel->cxlds; + cxlds->media_ready = true; + rc =cxl_set_capacity (cxlds,SZ_512M ); +if (rc) +return rc; + + cxlmd =devm_cxl_probe_mem (cxlds, &mock_range);[Severity: Low]
Does this code cause a build failure?Quoted 11 lines
It appears that
cxl_set_capacity()anddevm_cxl_probe_mem()are not defined anywhere in the CXL core subsystem, which would lead to unresolved symbol errors during compilation.Quoted 3 lines
tools/testing/cxl/test/accel.c new file +3
-0+if (IS_ERR (cxlmd)) +return PTR_ERR (cxlmd); + cxl_accel->cxlmd = cxlmd;Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6
Quoted 3 lines
This should be a false positive.
devm_cxl_probe_mem()is introduced by Dan's series.cxl_set_capacity()is from Alejandro's series.
Right definitely a false positive. Sashiko struggles a bit with cxl_test and it's outside of kernel tree structure.
Quoted 2 lines
--Richard
Re: [PATCH v5 6/6] cxl/test: Add cxl_test accelerator driver
In reply to Dave JiangHello,
tools/testing/cxl/test/accel.c line 49
Quoted 2 lines · Dave Jiang
tools/testing/cxl/test/accel.c new file +2
-0+static const struct platform_device_id cxl_mock_accel_ids[] = { + { .name ="cxl_type2_accel" ,0 },
Please drop the 0 here (and the comma before it).
Review
Quoted 2 lines
(quoted diff) +2
-0+ { } +};
Best regards
Uwe
Dave Jiang
maintainerRe: [PATCH v5 6/6] cxl/test: Add cxl_test accelerator driver
Quoted 7 lines · Uwe Kleine-König
Hello,
tools/testing/cxl/test/accel.c line 49
Quoted 2 lines · Dave Jiang
tools/testing/cxl/test/accel.c new file +2
-0+static const struct platform_device_id cxl_mock_accel_ids[] = { + { .name ="cxl_type2_accel" ,0 },Please drop the 0 here (and the comma before it).
Ok will do. thanks.
Quoted 6 lines
Review
Quoted 3 lines
(quoted diff) +2
-0+ { } +};Best regards
Uwe