feat(created-dts-for-pinetab-v): Created template for pinetab-v
PATCH 1/2 feat(created-dts-for-pinetab-v): Created template for pinetab-v
From: anoduck <[email protected]>
--- ...jh7110-starfive-visionfive-2-pinetab-v.dts | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 dts/upstream/src/riscv/starfive/jh7110-starfive-visionfive-2-pinetab-v.dts
dts/upstream/src/riscv/starfive/jh7110-starfive-visionfive-2-pinetab-v.dts new file +23 -0
@@ -0,0 +1,23 @@ +// SPDX-License-Identifier: GPL-2.0 OR MIT +/* + * Copyright (C) 2026 T Anoduck <[email protected]> + */ + +/dts-v1/; +#include "jh7110-starfive-visionfive-2.dtsi" + +/ { + model = "Pine64 Pinetab-V"; + compatible = "pine64,pinetab-v", "starfive,jh7110"; +}; + +// &sd-vcc { +// compatible = "regulator-fixed"; +// regulator-name = "sd_vcc"; +// regulator-min-microvolt = <3300000>; +// regulator-max-microvolt = <3300000>; +// gpio = <&sysgpio 35 GPIO_ACTIVE_LOW>; +// enable-active-low; +// regulator-boot-on; +// regulator-always-on; +// };
Signature · 1 line
2.53.0
PATCH 2/2 refactor: commented out changes to pinetab-v dts file
From: anoduck <[email protected]>
Commented out changes to pinetab-v dts file.
--- .../jh7110-starfive-visionfive-2-pinetab-v.dts | 11 ----------- 1 file changed, 11 deletions(-)
dts/upstream/src/riscv/starfive/jh7110-starfive-visionfive-2-pinetab-v.dts +0 -11
@@ -10,14 +10,3 @@ model = "Pine64 Pinetab-V"; compatible = "pine64,pinetab-v", "starfive,jh7110"; }; - -// &sd-vcc { -// compatible = "regulator-fixed"; -// regulator-name = "sd_vcc"; -// regulator-min-microvolt = <3300000>; -// regulator-max-microvolt = <3300000>; -// gpio = <&sysgpio 35 GPIO_ACTIVE_LOW>; -// enable-active-low; -// regulator-boot-on; -// regulator-always-on; -// };
Signature · 1 line
2.53.0
Hi anoduck,
Quoted 6 lines · On 6/11/26 17:33, [email protected] wrote:
From: anoduck <[email protected]>
--- ...jh7110-starfive-visionfive-2-pinetab-v.dts | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 dts/upstream/src/riscv/starfive/jh7110-starfive-visionfive-2-pinetab-v.dts
Okay, we don't touch dts/ that is a git remote of devicetree-rebasing, only maintainers will make changes there during a merge. If you need to stub out something just create an empty file with no code and prefix your series as RFC; changes can be brought in with the automatic inclusion strategy of the U-Boot build system in i.e. arch/riscv/dts/${soc}-${target}-u-boot.dtsi for example I would guess arch/riscv/dts/jh7110-pine64-pinetabv.dtsi matching the target in CONFIG_OF_LIST of configs/starfive_visionfive2_defconfig
Aside, you may think of configs/starfive_visionfive2_defconfig as "configs/starfive_jh7110_defconfig" it is a multi-board build config for all jh7110 boards supported by U-Boot.
If for some reason you are making modifications to dts/ in your series necessary for code review and feedback it should be prefixed "RFC" in the git format-patch command, and for multiple patches in a series then generate and edit a cover letter (patch "00") explaining what the purpose of the series is. I would suggest that anything destined for upstreaming first undergo review at the Linux kernel mailing list, and then can be referenced in U-Boot. When there is acceptance upstream then the following Linux release candidate would appear in the devicetree-rebasing tree and then eventually U-Boot as the git remote dts/ which can be cleanly cherry-pick'ed.
dts/upstream/src/riscv/starfive/jh7110-starfive-visionfive-2-pinetab-v.dts
Quoted 7 lines
dts/upstream/src/riscv/starfive/jh7110-starfive-visionfive-2-pinetab-v.dts new file +0
-0@@ -0,0 +1,23 @@
The filename "jh7110-starfive-visionfive-2-pinetab-v.dts" is not consistent with the existing file layout. Did you instead intend for "jh7110-pine64-pinetabv.dts" ?
dts/upstream/src/riscv/starfive/jh7110-starfive-visionfive-2-pinetab-v.dts line 8
Quoted 8 lines
dts/upstream/src/riscv/starfive/jh7110-starfive-visionfive-2-pinetab-v.dts new file +8
-0+// SPDX-License-Identifier: GPL-2.0 OR MIT +/* + * Copyright (C) 2026 T Anoduck <[email protected]> + */ + +/dts-v1/; +#include "jh7110-starfive-visionfive-2.dtsi" +
Do not include dtsi from unrelated boards. You may include "jh7110-common.dtsi" or "jh7110.dtsi" and if there are many variations of your board that have nodes in common not well represented by "jh7110-common.dtsi" then creating your own dts include for the variations.
dts/upstream/src/riscv/starfive/jh7110-starfive-visionfive-2-pinetab-v.dts line 12
Quoted 4 lines
dts/upstream/src/riscv/starfive/jh7110-starfive-visionfive-2-pinetab-v.dts new file +4
-0+/ { + model = "Pine64 Pinetab-V"; + compatible = "pine64,pinetab-v", "starfive,jh7110"; +};
Okay. I would suggest "pine64,pinetabv" but it is just a matter of style and preference. This needs a binding and to be submitted upstream however you will author it.
dts/upstream/src/riscv/starfive/jh7110-starfive-visionfive-2-pinetab-v.dts line 23
Quoted 11 lines
dts/upstream/src/riscv/starfive/jh7110-starfive-visionfive-2-pinetab-v.dts new file +11
-0+ +// &sd-vcc { +// compatible = "regulator-fixed"; +// regulator-name = "sd_vcc"; +// regulator-min-microvolt = <3300000>; +// regulator-max-microvolt = <3300000>; +// gpio = <&sysgpio 35 GPIO_ACTIVE_LOW>; +// enable-active-low; +// regulator-boot-on; +// regulator-always-on; +// };
Unclear what is the purpose of commented code?
Best regards,
- E Shattow