fs/nls: Change MODULE_LICENSE to use Unicode in place of BSD
Subsystems (2)
PATCH 1/1 fs/nls: Change MODULE_LICENSE to use Unicode in place of BSD
I believe the nls files were previously assigned a MODULE_LICENSE of "Dual BSD/GPL" incorrectly. At no time in the history of the files in the kernel source tree is there mention or reference to the BSD license being applicable to these files.
The license "BSD without advertising clause" was introduced in a set of changes for Linux version v2.4.10.2, in September of 2001 (right as MODULE_LICENSE was being introduced into the kernel).
I have searched lore and other lkml archives to see who was originally responsible for the assignment of the 'BSD...' license string, and I cannot find any stand-alone patch or any reference to this string or to the nls files for this time period, nor any justification for this license assignment. At this point, the nls files had been in the kernel tree for 4 years, with few modifications from their original submission in 1997.
Later in 2001, because this license string tainted the kernel, the license in the MODULE_LICENSE macro was changed to "Dual BSD/GPL". However, I believe the original "BSD without advertising clause" was assigned by mistake.
Correct this mistake and use what I believe is the correct license of "Dual Unicode/GPL" for these files. Also, add that string to the list of acceptable licenses for loading kernel modules in both the kernel and checkpatch.pl.
--- fs/nls/mac-celtic.c | 2 +- fs/nls/mac-centeuro.c | 2 +- fs/nls/mac-croatian.c | 2 +- fs/nls/mac-cyrillic.c | 2 +- fs/nls/mac-gaelic.c | 2 +- fs/nls/mac-greek.c | 2 +- fs/nls/mac-iceland.c | 2 +- fs/nls/mac-inuit.c | 2 +- fs/nls/mac-roman.c | 2 +- fs/nls/mac-romanian.c | 2 +- fs/nls/mac-turkish.c | 2 +- fs/nls/nls_ascii.c | 2 +- fs/nls/nls_base.c | 2 +- fs/nls/nls_cp1250.c | 2 +- fs/nls/nls_cp1251.c | 2 +- fs/nls/nls_cp1255.c | 2 +- fs/nls/nls_cp437.c | 2 +- fs/nls/nls_cp737.c | 2 +- fs/nls/nls_cp775.c | 2 +- fs/nls/nls_cp850.c | 2 +- fs/nls/nls_cp852.c | 2 +- fs/nls/nls_cp855.c | 2 +- fs/nls/nls_cp857.c | 2 +- fs/nls/nls_cp860.c | 2 +- fs/nls/nls_cp861.c | 2 +- fs/nls/nls_cp862.c | 2 +- fs/nls/nls_cp863.c | 2 +- fs/nls/nls_cp864.c | 2 +- fs/nls/nls_cp865.c | 2 +- fs/nls/nls_cp866.c | 2 +- fs/nls/nls_cp869.c | 2 +- fs/nls/nls_cp874.c | 2 +- fs/nls/nls_cp932.c | 2 +- fs/nls/nls_cp936.c | 2 +- fs/nls/nls_cp949.c | 2 +- fs/nls/nls_cp950.c | 2 +- fs/nls/nls_euc-jp.c | 2 +- fs/nls/nls_iso8859-1.c | 2 +- fs/nls/nls_iso8859-13.c | 2 +- fs/nls/nls_iso8859-14.c | 2 +- fs/nls/nls_iso8859-15.c | 2 +- fs/nls/nls_iso8859-2.c | 2 +- fs/nls/nls_iso8859-3.c | 2 +- fs/nls/nls_iso8859-4.c | 2 +- fs/nls/nls_iso8859-5.c | 2 +- fs/nls/nls_iso8859-6.c | 2 +- fs/nls/nls_iso8859-7.c | 2 +- fs/nls/nls_iso8859-9.c | 2 +- fs/nls/nls_koi8-r.c | 2 +- fs/nls/nls_koi8-ru.c | 2 +- fs/nls/nls_koi8-u.c | 2 +- fs/nls/nls_utf8.c | 2 +- include/linux/license.h | 3 ++- scripts/checkpatch.pl | 1 + 54 files changed, 55 insertions(+), 53 deletions(-)
fs/nls/mac-celtic.c +1 -1
@@ -566,4 +566,4 @@ module_init(init_nls_macceltic) module_exit(exit_nls_macceltic) MODULE_DESCRIPTION("NLS Codepage macceltic"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/mac-centeuro.c +1 -1
@@ -496,4 +496,4 @@ module_init(init_nls_maccenteuro) module_exit(exit_nls_maccenteuro) MODULE_DESCRIPTION("NLS Codepage maccenteuro"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/mac-croatian.c +1 -1
@@ -566,4 +566,4 @@ module_init(init_nls_maccroatian) module_exit(exit_nls_maccroatian) MODULE_DESCRIPTION("NLS Codepage maccroatian"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/mac-cyrillic.c +1 -1
@@ -461,4 +461,4 @@ module_init(init_nls_maccyrillic) module_exit(exit_nls_maccyrillic) MODULE_DESCRIPTION("NLS Codepage maccyrillic"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/mac-gaelic.c +1 -1
@@ -531,4 +531,4 @@ module_init(init_nls_macgaelic) module_exit(exit_nls_macgaelic) MODULE_DESCRIPTION("NLS Codepage macgaelic"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/mac-greek.c +1 -1
@@ -461,4 +461,4 @@ module_init(init_nls_macgreek) module_exit(exit_nls_macgreek) MODULE_DESCRIPTION("NLS Codepage macgreek"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/mac-iceland.c +1 -1
@@ -566,4 +566,4 @@ module_init(init_nls_maciceland) module_exit(exit_nls_maciceland) MODULE_DESCRIPTION("NLS Codepage maciceland"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/mac-inuit.c +1 -1
@@ -496,4 +496,4 @@ module_init(init_nls_macinuit) module_exit(exit_nls_macinuit) MODULE_DESCRIPTION("NLS Codepage macinuit"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/mac-roman.c +1 -1
@@ -601,4 +601,4 @@ module_init(init_nls_macroman) module_exit(exit_nls_macroman) MODULE_DESCRIPTION("NLS Codepage macroman"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/mac-romanian.c +1 -1
@@ -566,4 +566,4 @@ module_init(init_nls_macromanian) module_exit(exit_nls_macromanian) MODULE_DESCRIPTION("NLS Codepage macromanian"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/mac-turkish.c +1 -1
@@ -566,4 +566,4 @@ module_init(init_nls_macturkish) module_exit(exit_nls_macturkish) MODULE_DESCRIPTION("NLS Codepage macturkish"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_ascii.c +1 -1
@@ -165,4 +165,4 @@ module_init(init_nls_ascii)module_exit (exit_nls_ascii) MODULE_DESCRIPTION("NLS ASCII (United States)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_base.c +1 -1
@@ -558,4 +558,4 @@ EXPORT_SYMBOL(load_nls);EXPORT_SYMBOL (load_nls_default);MODULE_DESCRIPTION ("Base file system native language support" ); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_cp1250.c +1 -1
@@ -345,4 +345,4 @@ module_init(init_nls_cp1250) module_exit(exit_nls_cp1250) MODULE_DESCRIPTION("NLS Windows CP1250 (Slavic/Central European Languages)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_cp1251.c +1 -1
@@ -300,4 +300,4 @@ module_init(init_nls_cp1251) module_exit(exit_nls_cp1251) MODULE_DESCRIPTION("NLS Windows CP1251 (Bulgarian, Belarusian)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_cp1255.c +1 -1
@@ -382,5 +382,5 @@ module_init(init_nls_cp1255) module_exit(exit_nls_cp1255) MODULE_DESCRIPTION("NLS Hebrew charsets (ISO-8859-8, CP1255)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );MODULE_ALIAS_NLS (iso8859-8 );
fs/nls/nls_cp437.c +1 -1
@@ -386,4 +386,4 @@ module_init(init_nls_cp437) module_exit(exit_nls_cp437) MODULE_DESCRIPTION("NLS Codepage 437 (United States, Canada)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_cp737.c +1 -1
@@ -349,4 +349,4 @@ module_init(init_nls_cp737) module_exit(exit_nls_cp737) MODULE_DESCRIPTION("NLS Codepage 737 (Greek)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_cp775.c +1 -1
@@ -318,4 +318,4 @@ module_init(init_nls_cp775) module_exit(exit_nls_cp775) MODULE_DESCRIPTION("NLS Codepage 775 (Baltic Rim)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_cp850.c +1 -1
@@ -314,4 +314,4 @@ module_init(init_nls_cp850) module_exit(exit_nls_cp850) MODULE_DESCRIPTION("NLS Codepage 850 (Europe)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_cp852.c +1 -1
@@ -336,4 +336,4 @@ module_init(init_nls_cp852) module_exit(exit_nls_cp852) MODULE_DESCRIPTION("NLS Codepage 852 (Central/Eastern Europe)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_cp855.c +1 -1
@@ -298,4 +298,4 @@ module_init(init_nls_cp855) module_exit(exit_nls_cp855) MODULE_DESCRIPTION("NLS Codepage 855 (Cyrillic)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_cp857.c +1 -1
@@ -300,4 +300,4 @@ module_init(init_nls_cp857) module_exit(exit_nls_cp857) MODULE_DESCRIPTION("NLS Codepage 857 (Turkish)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_cp860.c +1 -1
@@ -363,4 +363,4 @@ module_init(init_nls_cp860) module_exit(exit_nls_cp860) MODULE_DESCRIPTION("NLS Codepage 860 (Portuguese)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_cp861.c +1 -1
@@ -386,4 +386,4 @@ module_init(init_nls_cp861) module_exit(exit_nls_cp861) MODULE_DESCRIPTION("NLS Codepage 861 (Icelandic)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_cp862.c +1 -1
@@ -420,4 +420,4 @@ module_init(init_nls_cp862) module_exit(exit_nls_cp862) MODULE_DESCRIPTION("NLS Codepage 862 (Hebrew)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_cp863.c +1 -1
@@ -380,4 +380,4 @@ module_init(init_nls_cp863) module_exit(exit_nls_cp863) MODULE_DESCRIPTION("NLS Codepage 863 (Canadian French)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_cp864.c +1 -1
@@ -406,4 +406,4 @@ module_init(init_nls_cp864) module_exit(exit_nls_cp864) MODULE_DESCRIPTION("NLS Codepage 864 (Arabic)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_cp865.c +1 -1
@@ -386,4 +386,4 @@ module_init(init_nls_cp865) module_exit(exit_nls_cp865) MODULE_DESCRIPTION("NLS Codepage 865 (Norwegian, Danish)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_cp866.c +1 -1
@@ -304,4 +304,4 @@ module_init(init_nls_cp866) module_exit(exit_nls_cp866) MODULE_DESCRIPTION("NLS Codepage 866 (Cyrillic/Russian)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_cp869.c +1 -1
@@ -314,4 +314,4 @@ module_init(init_nls_cp869) module_exit(exit_nls_cp869) MODULE_DESCRIPTION("NLS Codepage 869 (Greek)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_cp874.c +1 -1
@@ -273,5 +273,5 @@ module_init(init_nls_cp874) module_exit(exit_nls_cp874) MODULE_DESCRIPTION("NLS Thai charset (CP874, TIS-620)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );MODULE_ALIAS_NLS (tis-620 );
fs/nls/nls_cp932.c +1 -1
@@ -7931,5 +7931,5 @@ module_init(init_nls_cp932) module_exit(exit_nls_cp932) MODULE_DESCRIPTION("NLS Japanese charset (Shift-JIS)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );MODULE_ALIAS_NLS (sjis);
fs/nls/nls_cp936.c +1 -1
@@ -11109,5 +11109,5 @@ module_init(init_nls_cp936) module_exit(exit_nls_cp936) MODULE_DESCRIPTION("NLS Simplified Chinese charset (CP936, GB2312)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );MODULE_ALIAS_NLS (gb2312);
fs/nls/nls_cp949.c +1 -1
@@ -13944,5 +13944,5 @@ module_init(init_nls_cp949) module_exit(exit_nls_cp949) MODULE_DESCRIPTION("NLS Korean charset (CP949, EUC-KR)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );MODULE_ALIAS_NLS (euc-kr);
fs/nls/nls_cp950.c +1 -1
@@ -9480,5 +9480,5 @@ module_init(init_nls_cp950) module_exit(exit_nls_cp950) MODULE_DESCRIPTION("NLS Traditional Chinese charset (Big5)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );MODULE_ALIAS_NLS (big5);
fs/nls/nls_euc-jp.c +1 -1
@@ -579,4 +579,4 @@ module_init(init_nls_euc_jp) module_exit(exit_nls_euc_jp) MODULE_DESCRIPTION("NLS Japanese charset (EUC-JP)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_iso8859-1.c +1 -1
@@ -256,4 +256,4 @@ module_init(init_nls_iso8859_1) module_exit(exit_nls_iso8859_1) MODULE_DESCRIPTION("NLS ISO 8859-1 (Latin 1; Western European Languages)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_iso8859-13.c +1 -1
@@ -284,4 +284,4 @@ module_init(init_nls_iso8859_13) module_exit(exit_nls_iso8859_13) MODULE_DESCRIPTION("NLS ISO 8859-13 (Latin 7; Baltic)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_iso8859-14.c +1 -1
@@ -340,4 +340,4 @@ module_init(init_nls_iso8859_14) module_exit(exit_nls_iso8859_14) MODULE_DESCRIPTION("NLS ISO 8859-14 (Latin 8; Celtic)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_iso8859-15.c +1 -1
@@ -306,4 +306,4 @@ module_init(init_nls_iso8859_15) module_exit(exit_nls_iso8859_15) MODULE_DESCRIPTION("NLS ISO 8859-15 (Latin 9; Western European Languages with Euro)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_iso8859-2.c +1 -1
@@ -307,4 +307,4 @@ module_init(init_nls_iso8859_2) module_exit(exit_nls_iso8859_2) MODULE_DESCRIPTION("NLS ISO 8859-2 (Latin 2; Slavic/Central European Languages)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_iso8859-3.c +1 -1
@@ -307,4 +307,4 @@ module_init(init_nls_iso8859_3) module_exit(exit_nls_iso8859_3) MODULE_DESCRIPTION("NLS ISO 8859-3 (Latin 3; Esperanto, Galician, Maltese, Turkish)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_iso8859-4.c +1 -1
@@ -307,4 +307,4 @@ module_init(init_nls_iso8859_4) module_exit(exit_nls_iso8859_4) MODULE_DESCRIPTION("NLS ISO 8859-4 (Latin 4; old Baltic charset)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_iso8859-5.c +1 -1
@@ -271,4 +271,4 @@ module_init(init_nls_iso8859_5) module_exit(exit_nls_iso8859_5) MODULE_DESCRIPTION("NLS ISO 8859-5 (Cyrillic)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_iso8859-6.c +1 -1
@@ -262,4 +262,4 @@ module_init(init_nls_iso8859_6) module_exit(exit_nls_iso8859_6) MODULE_DESCRIPTION("NLS ISO 8859-6 (Arabic)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_iso8859-7.c +1 -1
@@ -316,4 +316,4 @@ module_init(init_nls_iso8859_7) module_exit(exit_nls_iso8859_7) MODULE_DESCRIPTION("NLS ISO 8859-7 (Modern Greek)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_iso8859-9.c +1 -1
@@ -271,4 +271,4 @@ module_init(init_nls_iso8859_9) module_exit(exit_nls_iso8859_9) MODULE_DESCRIPTION("NLS ISO 8859-9 (Latin 5; Turkish)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_koi8-r.c +1 -1
@@ -322,4 +322,4 @@ module_init(init_nls_koi8_r) module_exit(exit_nls_koi8_r) MODULE_DESCRIPTION("NLS KOI8-R (Russian)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_koi8-ru.c +1 -1
@@ -81,4 +81,4 @@ module_init(init_nls_koi8_ru) module_exit(exit_nls_koi8_ru) MODULE_DESCRIPTION("NLS KOI8-RU (Belarusian)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_koi8-u.c +1 -1
@@ -329,4 +329,4 @@ module_init(init_nls_koi8_u) module_exit(exit_nls_koi8_u) MODULE_DESCRIPTION("NLS KOI8-U (Ukrainian)"); -MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_LICENSE ("Dual Unicode/GPL" );
fs/nls/nls_utf8.c +1 -1
@@ -66,4 +66,4 @@ static void __exit exit_nls_utf8(void) module_init(init_nls_utf8) module_exit(exit_nls_utf8) MODULE_DESCRIPTION("NLS UTF-8"); -MODULE_LICENSE("Dual BSD/GPL"); +MODULE_LICENSE("Dual Unicode/GPL");
include/linux/license.h +2 -1
@@ -9,7 +9,8 @@ static inline int license_is_gpl_compatible(const char *license) || strcmp(license, "GPL and additional rights") == 0 ||strcmp (license,"Dual BSD/GPL" ) ==0 ||strcmp (license,"Dual MIT/GPL" ) ==0 - || strcmp(license, "Dual MPL/GPL") == 0); + ||strcmp (license,"Dual MPL/GPL" ) ==0 + || strcmp(license, "Dual Unicode/GPL") == 0); }#endif
scripts/checkpatch.pl +1 -0
@@ -7753,6 +7753,7 @@ sub process { Dual\ BSD/GPL| Dual\ MIT/GPL| Dual\ MPL/GPL| + Dual\ Unicode/GPL| Proprietary }x; if ($extracted_string !~ /^"(?:$valid_licenses)"$/x) {
Signature · 1 line
2.43.0
Quoted 23 lines · Tim Bird
I believe the nls files were previously assigned a
MODULE_LICENSEof "Dual BSD/GPL" incorrectly. At no time in the history of the files in the kernel source tree is there mention or reference to the BSD license being applicable to these files.The license "BSD without advertising clause" was introduced in a set of changes for Linux version v2.4.10.2, in September of 2001 (right as
MODULE_LICENSEwas being introduced into the kernel).I have searched lore and other lkml archives to see who was originally responsible for the assignment of the 'BSD...' license string, and I cannot find any stand-alone patch or any reference to this string or to the nls files for this time period, nor any justification for this license assignment. At this point, the nls files had been in the kernel tree for 4 years, with few modifications from their original submission in 1997.
Later in 2001, because this license string tainted the kernel, the license in the
MODULE_LICENSEmacro was changed to "Dual BSD/GPL". However, I believe the original "BSD without advertising clause" was assigned by mistake.
Quoted 4 lines
Correct this mistake and use what I believe is the correct license of "Dual Unicode/GPL" for these files. Also, add that string to the list of acceptable licenses for loading kernel modules in both the kernel and checkpatch.pl.
I haven't attempted to try to understand this nonsuperficially but I understand the "Dual BSD/GPL" tradition here to mean something corresponding to what SPDX would call BSD-3-Clause OR GPL-2.0, i.e. "Dual" refers to a disjunctive dual license, the module can be regarded as licensed under either BSD or GPL, but you've characterized the license of these files as Unicode-3.0 AND GPL-2.0, i.e. a conjunctive license (meaning "some of this stuff is under Unicode-3.0 and some of this stuff is under GPL-2.0"). I.e. from my admittedly naive perspective this looks wrong, or else sort of arbitrary. I.e. it feels to me like you're taking the conclusion you reached as to the license of the file - let's just say "Foo AND Bar" -- and then shoehorning that into the MODULE_LICENSE macro in a context that ought to mean "Foo OR Bar".
Also, I'm not actually sure why you took the source files that had the old Unicode license and concluded that they should be represented as 'Unicode-3.0 AND GPL-2.0' instead of just 'Unicode-3.0'. What are you asserting is under the GPL in these files that is not (purportedly) under the Unicode license?
Not sure whether this ultimately matters, to be sure.
Richard
Hey Richard,
Thanks for looking at this.
Quoted 31 lines
-----Original Message-----
From: Richard Fontana <[email protected]>Quoted 23 lines · Tim Bird
I believe the nls files were previously assigned a
MODULE_LICENSEof "Dual BSD/GPL" incorrectly. At no time in the history of the files in the kernel source tree is there mention or reference to the BSD license being applicable to these files.The license "BSD without advertising clause" was introduced in a set of changes for Linux version v2.4.10.2, in September of 2001 (right as
MODULE_LICENSEwas being introduced into the kernel).I have searched lore and other lkml archives to see who was originally responsible for the assignment of the 'BSD...' license string, and I cannot find any stand-alone patch or any reference to this string or to the nls files for this time period, nor any justification for this license assignment. At this point, the nls files had been in the kernel tree for 4 years, with few modifications from their original submission in 1997.
Later in 2001, because this license string tainted the kernel, the license in the
MODULE_LICENSEmacro was changed to "Dual BSD/GPL". However, I believe the original "BSD without advertising clause" was assigned by mistake.Quoted 4 lines
Correct this mistake and use what I believe is the correct license of "Dual Unicode/GPL" for these files. Also, add that string to the list of acceptable licenses for loading kernel modules in both the kernel and checkpatch.pl.
Quoted 13 lines
I haven't attempted to try to understand this nonsuperficially but I understand the "Dual BSD/GPL" tradition here to mean something corresponding to what SPDX would call
BSD-3-Clause OR GPL-2.0, i.e. "Dual" refers to a disjunctive dual license, the module can be regarded as licensed under either BSD or GPL, but you've characterized the license of these files asUnicode-3.0 AND GPL-2.0, i.e. a conjunctive license (meaning "some of this stuff is under Unicode-3.0 and some of this stuff is under GPL-2.0"). I.e. from my admittedly naive perspective this looks wrong, or else sort of arbitrary. I.e. it feels to me like you're taking the conclusion you reached as to the license of the file - let's just say "Foo AND Bar" -- and then shoehorning that into theMODULE_LICENSEmacro in a context that ought to mean "Foo OR Bar".
Yeah, I thought about making the license string be:
"Both Unicode/GPL" or something that expressed this. I could still be talked into it, as I recognize that all other uses of the word "Dual" in the MODULE_LICENSE strings refer to 'OR' situations, and this is an 'AND'.
The reason I didn't go that route was that "Dual" semantically could go either way, and I wanted this string to conform to the established pattern. But if it's misleading, maybe I should change it.
I believe and OR clause means that the entire file can be used, copied, etc. under either of the mentioned licenses. That is, one of the licenses could be dropped in subsequent usages outside of Linux kernel context. I went with AND because I don't think that's the case here.
Quoted 6 lines
Also, I'm not actually sure why you took the source files that had the old Unicode license and concluded that they should be represented as 'Unicode-3.0 AND GPL-2.0' instead of just 'Unicode-3.0'. What are you asserting is under the GPL in these files that is not (purportedly) under the Unicode license?
All of these files have both source code and data elements. I believe that the source code is GPL-2.0 and the data elements are Unicode-3.0. I didn't see any source that was obtained from the www.unicode.org web site - only data points.
Some of the source has been filled in by other parties (e.g. case-handling functions). It was added to existing code that was without an explicit license (except for the mistaken BSD attribution in the MODULE_LICENSE line), and copied from file to file after that. As extensions to the original source, which I interpret as GPL-2.0 given that was the default license for the kernel, I believe this additional code would be GPL-2.0 also.
Quoted 2 lines
Not sure whether this ultimately matters, to be sure.
It might not. The MODULE_LICENSE macro was originally created to
allow the kernel to signal that a module that did not have source available had been loaded into the kernel, and the 'tainted' flag was intended to allow upstream developers to avoid support work for such modules. I might be wrong, but I don't think the MODULE_LICENSE string should be treated as dispositive of the license for the file. That, in my view, is the role of the SPDX-License-Identifier line. Even so, I changed these because I didn't want there to be a conflict between those two elements of the file. It will be confusing in the future in the SPDX line says one thing, and MODULE_LICENSE says something else.
-- Tim