fbdev: modedb: Fix misaligned fields in the 1920x1080-60 mode
Subsystems (3)
PATCH 1/1 fbdev: modedb: Fix misaligned fields in the 1920x1080-60 mode
The 1920x1080@60 modedb entry has one too many initializers before its sync field: a stray "0" occupies the sync slot, which shifts the remaining values by one field. The entry therefore decodes as sync = 0, vmode = FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT (0x3, i.e. FB_VMODE_INTERLACED | FB_VMODE_DOUBLE), and flag = FB_VMODE_NONINTERLACED, instead of the intended sync = positive H/V, vmode = non-interlaced.
fb_find_mode() then returns a 1920x1080 mode flagged as interlaced + doublescan with active-low syncs. Drivers that honour var->vmode and var->sync when programming display timing enable doublescan and the wrong sync polarity, corrupting the output.
Drop the stray initializer so sync and vmode hold their intended values (positive H/V sync, non-interlaced), matching the adjacent 1920x1200 entry.
--- drivers/video/fbdev/core/modedb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/fbdev/core/modedb.c +1 -1
@@ -258,7 +258,7 @@ static const struct fb_videomode modedb[] = { FB_VMODE_DOUBLE },/* 1920x1080 @ 60 Hz, 67.3 kHz hsync */ - {NULL ,60 ,1920 ,1080 ,6734 ,148 ,88 ,36 ,4 ,44 ,5 ,0 , + {NULL ,60 ,1920 ,1080 ,6734 ,148 ,88 ,36 ,4 ,44 ,5 ,FB_SYNC_HOR_HIGH_ACT |FB_SYNC_VERT_HIGH_ACT , FB_VMODE_NONINTERLACED },
Signature · 1 line
2.40.1
Helge Deller
maintainerQuoted 17 lines · Steffen Persvold
The 1920x1080@60 modedb entry has one too many initializers before its sync field: a stray "0" occupies the sync slot, which shifts the remaining values by one field. The entry therefore decodes as sync = 0, vmode =
FB_SYNC_HOR_HIGH_ACT|FB_SYNC_VERT_HIGH_ACT(0x3, i.e.FB_VMODE_INTERLACED|FB_VMODE_DOUBLE), and flag =FB_VMODE_NONINTERLACED, instead of the intended sync = positive H/V, vmode = non-interlaced.
fb_find_mode()then returns a 1920x1080 mode flagged as interlaced + doublescan with active-low syncs. Drivers that honourvar->vmodeandvar->syncwhen programming display timing enable doublescan and the wrong sync polarity, corrupting the output.Drop the stray initializer so sync and vmode hold their intended values (positive H/V sync, non-interlaced), matching the adjacent 1920x1200 entry.
Quoted 6 lines
Fixes c8902258b2b8 ("fbdev: modedb: Add 1920x1080 at 60 Hz video mode")Signed-off-by Steffen Persvold <[email protected]>--- drivers/video/fbdev/core/modedb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Steffen, thanks for fixing the bug which was actually introduced by me!
This patch is now applied to the fbdev git tree.
Thanks!
Helge