Skip to contentSkip to conversation

ASoC: dt-bindings: Fix RT5677 "realtek,gpio-config" type

PATCH In review Rob Herring (Arm) 3 participants 3 messages Jun 12 – Jun 14

Subsystems (3)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 ASoC: dt-bindings: Fix RT5677 "realtek,gpio-config" type

"realtek,gpio-config" is described as six 8-bit GPIO configuration values, and the RT5677 driver stores and reads those values as bytes. The binding incorrectly documented the property as a uint32 array.

Document "realtek,gpio-config" as a uint8-array so the generated schema matches the hardware definition and the existing driver helper.

Assisted-by Codex:gpt-5-5
---
 Documentation/devicetree/bindings/sound/realtek,rt5677.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/sound/realtek,rt5677.yaml +2 -2
index 9ce23e58e5ea..ae27ae78b1b2 100644
@@ -58,7 +58,7 @@ properties:
       0 - floating (reset value)
       1 - pull down
       2 - pull up
-    $ref: /schemas/types.yaml#/definitions/uint32-array
+    $ref: /schemas/types.yaml#/definitions/uint8-array
     minItems: 6
     maxItems: 6
     items:
@@ -130,6 +130,6 @@ examples:
             realtek,pow-ldo2-gpio = <&gpio 3 GPIO_ACTIVE_HIGH>;
             realtek,reset-gpio = <&gpio 3 GPIO_ACTIVE_LOW>;
             realtek,in1-differential;
-            realtek,gpio-config = <0 0 0 0 0 2>;
+            realtek,gpio-config = /bits/ 8 <0 0 0 0 0 2>;
         };
     };
Signature · 1 line
2.53.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Rob Herring (Arm)

"realtek,gpio-config" is described as six 8-bit GPIO configuration values, and the RT5677 driver stores and reads those values as bytes. The binding incorrectly documented the property as a uint32 array.

Quoted 8 lines

Document "realtek,gpio-config" as a uint8-array so the generated schema matches the hardware definition and the existing driver helper.

Assisted-by Codex:gpt-5-5
---
 Documentation/devicetree/bindings/sound/realtek,rt5677.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Best regards,
Krzysztof

maintainer
#2 lore raw
In reply to Rob Herring (Arm)
Quoted 1 line · Rob Herring (Arm)

ASoC: dt-bindings: Fix RT5677 "realtek,gpio-config" type

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.2

Thanks!

[1/1] ASoC: dt-bindings: Fix RT5677 "realtek,gpio-config" type

      https://git.kernel.org/broonie/sound/c/4346d91cfa47

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark