Skip to contentSkip to conversation

iio: stm32-dfsdm: Treat flags as booleans

PATCH In review Rob Herring (Arm) 4 participants 6 messages Jun 12 – Jun 23

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: stm32-dfsdm: Treat flags as booleans

The "st,adc-alt-channel" and "st,filter0-sync" properties are documented as boolean flags. The legacy parser read them as integer cells, unlike the child-node parser which already checks only for presence.

Use presence and boolean helpers so both parsers follow the binding and the property type checker no longer reports the flags.

Assisted-by Codex:gpt-5-5
---
 drivers/iio/adc/stm32-dfsdm-adc.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)
drivers/iio/adc/stm32-dfsdm-adc.c +4 -8
index 9664b9bd75d4..00f05e167afc 100644
@@ -660,11 +660,8 @@ static int stm32_dfsdm_channel_parse_of(struct stm32_dfsdm *dfsdm,
 	}
 	df_ch->src = val;
 
-	ret = of_property_read_u32_index(indio_dev->dev.of_node,
-					 "st,adc-alt-channel", chan_idx,
-					 &df_ch->alt_si);
-	if (ret < 0)
-		df_ch->alt_si = 0;
+	df_ch->alt_si = of_property_present(indio_dev->dev.of_node,
+					    "st,adc-alt-channel");
 
 	return 0;
 }
@@ -1815,9 +1812,8 @@ static int stm32_dfsdm_adc_probe(struct platform_device *pdev)
 
 	adc->dfsdm->fl_list[adc->fl_id].ford = val;
 
-	ret = of_property_read_u32(dev->of_node, "st,filter0-sync", &val);
-	if (!ret)
-		adc->dfsdm->fl_list[adc->fl_id].sync_mode = val;
+	adc->dfsdm->fl_list[adc->fl_id].sync_mode =
+		of_property_read_bool(dev->of_node, "st,filter0-sync");
 
 	adc->dev_data = dev_data;
 	ret = dev_data->init(dev, iio);
Signature · 1 line
2.53.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Rob Herring (Arm)

The "st,adc-alt-channel" and "st,filter0-sync" properties are documented as boolean flags. The legacy parser read them as integer cells, unlike the child-node parser which already checks only for presence.

Use presence and boolean helpers so both parsers follow the binding and the property type checker no longer reports the flags.

For the patch

However one interesting remark below.

...

drivers/iio/adc/stm32-dfsdm-adc.c static int stm32_dfsdm_channel_parse_of(struct stm32_dfsdm *dfsdm,

Quoted 5 lines
drivers/iio/adc/stm32-dfsdm-adc.c +1 -3
-	ret = of_property_read_u32_index(indio_dev->dev.of_node,
-					 "st,adc-alt-channel", chan_idx,
-					 &df_ch->alt_si);
 
+	df_ch->alt_si = of_property_present(indio_dev->dev.of_node,

I believe it still has another (serious?) issue. We usually don't use indio_dev for device properties. It's not a device that is described in DT. It seems the only driver in IIO that does that. Note, I haven't conducted any deeper research, it might be (however I'm quite in doubt) that this is correct use and one device registers a few indio_dev:s.

Quoted 1 line
drivers/iio/adc/stm32-dfsdm-adc.c +1 -0
+					    "st,adc-alt-channel");
Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#2 lore raw
Quoted 20 lines · On Sat, 13 Jun 2026 16:39:16 +0300 Andy Shevchenko…
Quoted 7 lines · Rob Herring (Arm)

The "st,adc-alt-channel" and "st,filter0-sync" properties are documented as boolean flags. The legacy parser read them as integer cells, unlike the child-node parser which already checks only for presence.

Use presence and boolean helpers so both parsers follow the binding and the property type checker no longer reports the flags.

For the patch

However one interesting remark below.

...

Quoted 3 lines
drivers/iio/adc/stm32-dfsdm-adc.c +0 -3
-	ret = of_property_read_u32_index(indio_dev->dev.of_node,
-					 "st,adc-alt-channel", chan_idx,
-					 &df_ch->alt_si);  
Quoted 7 lines

drivers/iio/adc/stm32-dfsdm-adc.c static int stm32_dfsdm_channel_parse_of(struct stm32_dfsdm *dfsdm, · line 663

Quoted 1 line
drivers/iio/adc/stm32-dfsdm-adc.c +1 -0
+	df_ch->alt_si = of_property_present(indio_dev->dev.of_node,  

I believe it still has another (serious?) issue. We usually don't use indio_dev for device properties. It's not a device that is described in DT. It seems the only driver in IIO that does that. Note, I haven't conducted any deeper research, it might be (however I'm quite in doubt) that this is correct use and one device registers a few indio_dev:s.

It is curious. The registration sequence in this driver is complex, but I'm not seeing anything that sets the fwnode for the struct iio_dev->dev before calling the init() callbacks that end up in this code. It is set later by iio_device_register() (iirc that has something to do with consumers turning up later).

St folk could you take a look at this and see what we are missing if it does currently work?

For now I'll apply this patch but might need to drop it if a fix clashes with it.

Thanks,

Jonathan

Quoted 3 lines
Quoted 2 lines
drivers/iio/adc/stm32-dfsdm-adc.c +1 -0
+					    "st,adc-alt-channel");  
#3 lore raw

Hi Andy, Jonathan,

Sorry for the late answer.

Quoted 39 lines · Jonathan Cameron
Quoted 20 lines · On Sat, 13 Jun 2026 16:39:16 +0300 Andy Shevchenko…
Quoted 7 lines · Rob Herring (Arm)

The "st,adc-alt-channel" and "st,filter0-sync" properties are documented as boolean flags. The legacy parser read them as integer cells, unlike the child-node parser which already checks only for presence.

Use presence and boolean helpers so both parsers follow the binding and the property type checker no longer reports the flags.

For the patch

However one interesting remark below.

...

Quoted 3 lines
drivers/iio/adc/stm32-dfsdm-adc.c +0 -3
-	ret = of_property_read_u32_index(indio_dev->dev.of_node,
-					 "st,adc-alt-channel", chan_idx,
-					 &df_ch->alt_si);
Quoted 7 lines

drivers/iio/adc/stm32-dfsdm-adc.c static int stm32_dfsdm_channel_parse_of(struct stm32_dfsdm *dfsdm, · line 663

Quoted 1 line
drivers/iio/adc/stm32-dfsdm-adc.c +1 -0
+	df_ch->alt_si = of_property_present(indio_dev->dev.of_node,

I believe it still has another (serious?) issue. We usually don't use indio_dev for device properties. It's not a device that is described in DT. It seems the only driver in IIO that does that. Note, I haven't conducted any deeper research, it might be (however I'm quite in doubt) that this is correct use and one device registers a few indio_dev:s.

It is curious. The registration sequence in this driver is complex, but I'm not seeing anything that sets the fwnode for the struct iio_dev->dev before calling the init() callbacks that end up in this code. It is set later by iio_device_register() (iirc that has something to do with consumers turning up later).

St folk could you take a look at this and see what we are missing if it does currently work?

Quoted 8 lines

For now I'll apply this patch but might need to drop it if a fix clashes with it.

Thanks,

Jonathan

I confirm that the current legacy path is functional (With the st,adc-alt-channel property fix applied)

It currently works because the driver initializes np from dev->of_node in probe, and that value is then used in init callbacks.

I agree that this approach is not robust, as it depends on initialization sequencing and on using an IIO object that is not the DT owner object. I will prepare a patch to use the DT device directly as the single source for DT properties.

I also suggest keeping a fallback path for st,adc-alt-channel so we do not break legacy DTs that have not yet migrated to the new binding. I prepare this also.

BRs
Olivier

Quoted 6 lines
Quoted 4 lines
Quoted 3 lines
drivers/iio/adc/stm32-dfsdm-adc.c +1 -0
+					    "st,adc-alt-channel");
#4 lore raw
Quoted 4 lines · Olivier MOYSAN
Quoted 3 lines · Jonathan Cameron
Quoted 1 line · On Sat, 13 Jun 2026 16:39:16 +0300 Andy Shevchenko…

On Fri, Jun 12, 2026 at 04:51:50PM -0500, Rob Herring (Arm) wrote:

...

Quoted 17 lines
Quoted 17 lines
Quoted 11 lines

drivers/iio/adc/stm32-dfsdm-adc.c static int stm32_dfsdm_channel_parse_of(struct stm32_dfsdm *dfsdm,

Quoted 5 lines
drivers/iio/adc/stm32-dfsdm-adc.c +1 -3
-	ret = of_property_read_u32_index(indio_dev->dev.of_node,
-					 "st,adc-alt-channel", chan_idx,
-					 &df_ch->alt_si);
 
+	df_ch->alt_si = of_property_present(indio_dev->dev.of_node,

I believe it still has another (serious?) issue. We usually don't use indio_dev for device properties. It's not a device that is described in DT. It seems the only driver in IIO that does that. Note, I haven't conducted any deeper research, it might be (however I'm quite in doubt) that this is correct use and one device registers a few indio_dev:s.

It is curious. The registration sequence in this driver is complex, but I'm not seeing anything that sets the fwnode for the struct iio_dev->dev before calling the init() callbacks that end up in this code. It is set later by iio_device_register() (iirc that has something to do with consumers turning up later).

Quoted 8 lines
Quoted 5 lines

St folk could you take a look at this and see what we are missing if it does currently work?

For now I'll apply this patch but might need to drop it if a fix clashes with it.

I confirm that the current legacy path is functional (With the st,adc-alt-channel property fix applied)

Yeah, it's here
https://elixir.bootlin.com/linux/v7.1.1/source/drivers/iio/adc/stm32-dfsdm-adc.c#L1772
and should gone. Basically one wants to replace all these to use device and fwnode propery APIs and proper device node, without that hack.

Quoted 11 lines

It currently works because the driver initializes np from dev->of_node in probe, and that value is then used in init callbacks.

I agree that this approach is not robust, as it depends on initialization sequencing and on using an IIO object that is not the DT owner object. I will prepare a patch to use the DT device directly as the single source for DT properties.

I also suggest keeping a fallback path for st,adc-alt-channel so we do not break legacy DTs that have not yet migrated to the new binding. I prepare this also.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#5 lore raw
Quoted 31 lines · On Tue, 23 Jun 2026 12:54:36 +0300 Andy Shevchenko…
Quoted 4 lines · Olivier MOYSAN
Quoted 3 lines · Jonathan Cameron
Quoted 1 line · On Sat, 13 Jun 2026 16:39:16 +0300 Andy Shevchenko…

On Fri, Jun 12, 2026 at 04:51:50PM -0500, Rob Herring (Arm) wrote:

...

Quoted 23 lines
Quoted 22 lines
Quoted 11 lines

drivers/iio/adc/stm32-dfsdm-adc.c static int stm32_dfsdm_channel_parse_of(struct stm32_dfsdm *dfsdm,

Quoted 5 lines
drivers/iio/adc/stm32-dfsdm-adc.c +1 -3
-	ret = of_property_read_u32_index(indio_dev->dev.of_node,
-					 "st,adc-alt-channel", chan_idx,
-					 &df_ch->alt_si);  
 
+	df_ch->alt_si = of_property_present(indio_dev->dev.of_node,  

I believe it still has another (serious?) issue. We usually don't use indio_dev for device properties. It's not a device that is described in DT. It seems the only driver in IIO that does that. Note, I haven't conducted any deeper research, it might be (however I'm quite in doubt) that this is correct use and one device registers a few indio_dev:s.

It is curious. The registration sequence in this driver is complex, but I'm not seeing anything that sets the fwnode for the struct iio_dev->dev before calling the init() callbacks that end up in this code. It is set later by iio_device_register() (iirc that has something to do with consumers turning up later).

St folk could you take a look at this and see what we are missing if it does currently work?

For now I'll apply this patch but might need to drop it if a fix clashes with it.

Quoted 7 lines
Quoted 2 lines

I confirm that the current legacy path is functional (With the st,adc-alt-channel property fix applied)

Yeah, it's here
https://elixir.bootlin.com/linux/v7.1.1/source/drivers/iio/adc/stm32-dfsdm-adc.c#L1772
and should gone. Basically one wants to replace all these to use device and fwnode propery APIs and proper device node, without that hack.

If we 'were' going to keep this it should have been using the helper to set that. I thought all those had been cleaned up so didn't check for it being directly written :( Obviously this comment is irrelevant given the code is going away!

Jonathan

Quoted 13 lines
Quoted 12 lines

It currently works because the driver initializes np from dev->of_node in probe, and that value is then used in init callbacks.

I agree that this approach is not robust, as it depends on initialization sequencing and on using an IIO object that is not the DT owner object. I will prepare a patch to use the DT device directly as the single source for DT properties.

I also suggest keeping a fallback path for st,adc-alt-channel so we do not break legacy DTs that have not yet migrated to the new binding. I prepare this also.