Skip to contentSkip to conversation

dt-bindings: dma: xilinx: Fix "xlnx,irq-delay" type

PATCH Applied Rob Herring (Arm) 3 participants 3 messages Jun 12 – Jul 2

Subsystems (3)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: dma: xilinx: Fix "xlnx,irq-delay" type

"xlnx,irq-delay" programs an 8-bit delay field in the DMA control register, and the driver stores and reads it as a byte. The binding described the property as a uint32 cell, which made the helper type check report the driver as wrong.

Document "xlnx,irq-delay" as uint8 so the generated schema reflects the hardware field width and the existing driver access.

Assisted-by Codex:gpt-5-5
---
 Documentation/devicetree/bindings/dma/xilinx/xlnx,axi-dma.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/dma/xilinx/xlnx,axi-dma.yaml +1 -1
index 340ae9e91cb0..ba0fc515d825 100644
@@ -93,7 +93,7 @@ properties:
       Width in bits of the length register as configured in hardware.
 
   xlnx,irq-delay:
-    $ref: /schemas/types.yaml#/definitions/uint32
+    $ref: /schemas/types.yaml#/definitions/uint8
     minimum: 0
     maximum: 255
     description:
Signature · 1 line
2.53.0
Reviewed-by Radhey Shyam Pandey on v1 1/1
#1 lore raw
Quoted 10 lines

"xlnx,irq-delay" programs an 8-bit delay field in the DMA control register, and the driver stores and reads it as a byte. The binding described the property as a uint32 cell, which made the helper type check report the driver as wrong.

Document "xlnx,irq-delay" as uint8 so the generated schema reflects the hardware field width and the existing driver access.

Assisted-by Codex:gpt-5-5

Thanks!

Quoted 17 lines
---
  Documentation/devicetree/bindings/dma/xilinx/xlnx,axi-dma.yaml | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/dma/xilinx/xlnx,axi-dma.yaml +1 -1
index 340ae9e91cb0..ba0fc515d825 100644
@@ -93,7 +93,7 @@ properties:
        Width in bits of the length register as configured in hardware.
 
    xlnx,irq-delay:
-    $ref: /schemas/types.yaml#/definitions/uint32
+    $ref: /schemas/types.yaml#/definitions/uint8
      minimum: 0
      maximum: 255
      description:
maintainer Applied
#2 lore raw
In reply to Rob Herring (Arm)
Quoted 9 lines · Rob Herring (Arm)

"xlnx,irq-delay" programs an 8-bit delay field in the DMA control register, and the driver stores and reads it as a byte. The binding described the property as a uint32 cell, which made the helper type check report the driver as wrong.

Document "xlnx,irq-delay" as uint8 so the generated schema reflects the hardware field width and the existing driver access.

[...]

Applied, thanks!

[1/1] dt-bindings: dma: xilinx: Fix "xlnx,irq-delay" type

      commit: fa9cb11584851414b25fd8bf9f59518424b5917c

Best regards,

Signature · 1 line
~Vinod