clk: at91: Read "reg" with helper
Subsystems (2)
PATCH 1/1 clk: at91: Read "reg" with helper
The "reg" property is an address-sized DT cell property. The AT91 compat clock parser only uses a small bus id from it, but reading it with the u8 helper does not match the property encoding.
Use of_property_read_reg() so the code goes through the helper for "reg" properties, then keep the existing range check before passing the bus id to the clock registration code.
--- drivers/clk/at91/dt-compat.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/clk/at91/dt-compat.c +3 -2
@@ -2,6 +2,7 @@#include <linux/clk-provider.h> #include <linux/clk/at91_pmc.h> #include <linux/of.h> +#include <linux/of_address.h> #include <linux/mfd/syscon.h> #include <linux/regmap.h> #include <linux/slab.h>
@@ -217,7 +218,7 @@ CLK_OF_DECLARE(of_sama5d4_clk_h32mx_setup, "atmel,sama5d4-clk-h32mx",static void __init of_sama5d2_clk_i2s_mux_setup (struct device_node *np) {struct regmap *regmap_sfr; -u8 bus_id; +u64 bus_id;const char *parent_names[2 ];struct device_node *i2s_mux_np;struct clk_hw *hw;
@@ -228,7 +229,7 @@ static void __init of_sama5d2_clk_i2s_mux_setup(struct device_node *np)return ;for_each_child_of_node (np, i2s_mux_np) { -if (of_property_read_u8 (i2s_mux_np,"reg" , &bus_id)) +if (of_property_read_reg (i2s_mux_np,0 , &bus_id,NULL ))continue ;if (bus_id >I2S_BUS_NR )
Signature · 1 line
2.53.0
Quoted 10 lines · Rob Herring (Arm)
The "reg" property is an address-sized DT cell property. The AT91 compat clock parser only uses a small bus id from it, but reading it with the u8 helper does not match the property encoding.
Use
of_property_read_reg()so the code goes through the helper for "reg" properties, then keep the existing range check before passing the bus id to the clock registration code.Assisted-by Codex:gpt-5-5Signed-off-by Rob Herring (Arm) <[email protected]>
Quoted 10 lines · Rob Herring (Arm)
The "reg" property is an address-sized DT cell property. The AT91 compat clock parser only uses a small bus id from it, but reading it with the u8 helper does not match the property encoding.
Use
of_property_read_reg()so the code goes through the helper for "reg" properties, then keep the existing range check before passing the bus id to the clock registration code.Assisted-by Codex:gpt-5-5Signed-off-by Rob Herring (Arm)<[email protected]>
Applied to clk-microchip, thanks!