Skip to contentSkip to conversation

dt-bindings: power: maxim,max17042: Fix temp types to signed

PATCH Applied Rob Herring (Arm) 2 participants 3 messages Jun 12 – Jul 20

Subsystems (3)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: power: maxim,max17042: Fix temp types to signed

The max17042 binding described "maxim,cold-temp" and "maxim,over-heat-temp" as unsigned values, but in-tree DTS examples use negative temperatures such as a cold threshold below zero degrees.

Document the temperature properties as signed int32 values so the schema matches existing DTS data and the driver can use signed helpers.

Assisted-by Codex:gpt-5-5
---
 .../devicetree/bindings/power/supply/maxim,max17042.yaml      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml +2 -2
index 242b33f2bcba..8687009b4057 100644
@@ -44,13 +44,13 @@ properties:
       Defining this property enables current-sense functionality.
 
   maxim,cold-temp:
-    $ref: /schemas/types.yaml#/definitions/uint32
+    $ref: /schemas/types.yaml#/definitions/int32
     description:
       Temperature threshold to report battery as cold (in tenths of degree Celsius).
       Default is not to report cold events.
 
   maxim,over-heat-temp:
-    $ref: /schemas/types.yaml#/definitions/uint32
+    $ref: /schemas/types.yaml#/definitions/int32
     description:
       Temperature threshold to report battery as over heated (in tenths of degree Celsius).
       Default is not to report over heating events.
Signature · 1 line
2.53.0
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Rob Herring (Arm)

The max17042 binding described "maxim,cold-temp" and "maxim,over-heat-temp" as unsigned values, but in-tree DTS examples use negative temperatures such as a cold threshold below zero degrees.

Quoted 9 lines

Document the temperature properties as signed int32 values so the schema matches existing DTS data and the driver can use signed helpers.

Assisted-by Codex:gpt-5-5
---
 .../devicetree/bindings/power/supply/maxim,max17042.yaml      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Best regards,
Krzysztof

author maintainer Applied
#2 lore raw
In reply to Rob Herring (Arm)
Quoted 4 lines · Rob Herring (Arm)

The max17042 binding described "maxim,cold-temp" and "maxim,over-heat-temp" as unsigned values, but in-tree DTS examples use negative temperatures such as a cold threshold below zero degrees.

Quoted 9 lines

Document the temperature properties as signed int32 values so the schema matches existing DTS data and the driver can use signed helpers.

Assisted-by Codex:gpt-5-5
---
 .../devicetree/bindings/power/supply/maxim,max17042.yaml      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks!