power: reset: Read "priority" as unsigned
PATCH 1/1 power: reset: Read "priority" as unsigned
The restart-handler binding documents "priority" as a uint32 value in the range 0 to 255. The syscon reboot driver stored it in an int and used the signed DT helper, which makes the helper type disagree with the schema.
Read "priority" as u32 so the driver follows the binding while preserving the same default value.
--- drivers/power/reset/syscon-reboot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/power/reset/syscon-reboot.c +2 -2
@@ -67,7 +67,7 @@ static int syscon_reboot_probe(struct platform_device *pdev) {struct syscon_reboot_context *ctx;struct device *dev = &pdev->dev; -int priority; +u32 priority;int err; ctx =devm_kzalloc (&pdev->dev,sizeof (*ctx),GFP_KERNEL );
@@ -81,7 +81,7 @@ static int syscon_reboot_probe(struct platform_device *pdev)return PTR_ERR (ctx->map); } -if (of_property_read_s32 (pdev->dev.of_node,"priority" , &priority)) +if (of_property_read_u32 (pdev->dev.of_node,"priority" , &priority)) priority =192 ; ctx->rd =of_device_get_match_data (dev);
Signature · 1 line
2.53.0
Sebastian Reichel
AppliedQuoted 9 lines · Rob Herring (Arm)
The restart-handler binding documents "priority" as a uint32 value in the range 0 to 255. The syscon reboot driver stored it in an int and used the signed DT helper, which makes the helper type disagree with the schema.
Read "priority" as u32 so the driver follows the binding while preserving the same default value.
[...]
Applied, thanks!
[1/1] power: reset: Read "priority" as unsigned
commit: 6539d798e9faf6e98d64ad7cb3af91d42180a886
Best regards,
Signature · 1 line
Sebastian Reichel <[email protected]>