Skip to contentSkip to conversation

Docs/mm/damon/design: fix a typo in the Address Unit section

PATCH In review Shardul Deshpande 4 participants 7 messages Jun 12 – Jun 13

Subsystems (14)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Docs/mm/damon/design: fix a typo in the Address Unit section

The "Address Unit" section misspelled the C type that the DAMON core layer uses for monitoring target address ranges. Correct it to read "unsigned long".

---
 Documentation/mm/damon/design.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/mm/damon/design.rst +1 -1
index afc7d52bd..899ac9c69 100644
@@ -140,7 +140,7 @@ as Idle page tracking does.
 Address Unit
 ------------
 
-DAMON core layer uses ``unsinged long`` type for monitoring target address
+DAMON core layer uses ``unsigned long`` type for monitoring target address
 ranges.  In some cases, the address space for a given operations set could be
 too large to be handled with the type.  ARM (32-bit) with large physical
 address extension is an example.  For such cases, a per-operations set
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 9 lines · On Fri, 12 Jun 2026 21:10:54 +0530 Shardul Deshpande <[email protected]>…

The "Address Unit" section misspelled the C type that the DAMON core layer uses for monitoring target address ranges. Correct it to read "unsigned long".

...

Documentation/mm/damon/design.rst as Idle page tracking does. · line 146

Quoted 8 lines
Documentation/mm/damon/design.rst +1 -1
@@ -140,7 +140,7 @@ as Idle page tracking does.
 Address Unit
 ------------
 
-DAMON core layer uses ``unsinged long`` type for monitoring target address
+DAMON core layer uses ``unsigned long`` type for monitoring target address
 ranges.  In some cases, the address space for a given operations set could be
 too large to be handled with the type.  ARM (32-bit) with large physical
 address extension is an example.  For such cases, a per-operations set

Well we don't want our longs to be singed.

`grep -ri singed .' shows quite a few typos. "assinged" is popular. Perhaps you could prepare a patch which fixes them all and adds "assinged" to scripts/spelling.txt?

#2 lore raw

PATCH 1/1 treewide: fix transposed "sign" typos and update spelling.txt

In reply to Shardul Deshpande

Several comments and one documentation file transpose the letters in "assigned" and "unsigned", spelling them with "sing" instead of "sign". Correct all of them.

Of these, the misspelling of "assigned" is not yet flagged by checkpatch, so also add it to scripts/spelling.txt.

The remaining matches of grep -ri singed are RISINGEDGE register and enum names, not typos.

---
 Documentation/mm/damon/design.rst          | 2 +-
 arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 2 +-
 drivers/gpu/drm/drm_color_mgmt.c           | 2 +-
 drivers/scsi/elx/efct/efct_hw.h            | 2 +-
 drivers/scsi/isci/host.c                   | 2 +-
 drivers/scsi/isci/port.c                   | 2 +-
 drivers/scsi/isci/port_config.c            | 2 +-
 kernel/bpf/helpers.c                       | 2 +-
 scripts/spelling.txt                       | 1 +
 9 files changed, 9 insertions(+), 8 deletions(-)
Documentation/mm/damon/design.rst +1 -1
index afc7d52bd..899ac9c69 100644
@@ -140,7 +140,7 @@ as Idle page tracking does.
 Address Unit
 ------------
 
-DAMON core layer uses ``unsinged long`` type for monitoring target address
+DAMON core layer uses ``unsigned long`` type for monitoring target address
 ranges.  In some cases, the address space for a given operations set could be
 too large to be handled with the type.  ARM (32-bit) with large physical
 address extension is an example.  For such cases, a per-operations set
arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi +1 -1
index 469a5d103..9ae9af40f 100644
@@ -562,7 +562,7 @@ &sdc1_rclk {
  *
  * This has entries that are defined by Qcard even if they go to the main
  * board. In cases where the pulls may be board dependent we defer those
- * settings to the board device tree. Drive strengths tend to be assinged here
+ * settings to the board device tree. Drive strengths tend to be assigned here
  * but could conceivably be overwridden by board device trees.
  */
 
drivers/gpu/drm/drm_color_mgmt.c +1 -1
index e7db4e4ea..cb7f51ff8 100644
@@ -54,7 +54,7 @@
  *	&drm_crtc_state.degamma_lut.
  *
  * “DEGAMMA_LUT_SIZE”:
- *	Unsinged range property to give the size of the lookup table to be set
+ *	Unsigned range property to give the size of the lookup table to be set
  *	on the DEGAMMA_LUT property (the size depends on the underlying
  *	hardware). If drivers support multiple LUT sizes then they should
  *	publish the largest size, and sub-sample smaller sized LUTs (e.g. for
drivers/scsi/elx/efct/efct_hw.h +1 -1
index f3f4aa78d..20aae0402 100644
@@ -59,7 +59,7 @@
 #define EFCT_HW_EQ_DEPTH		1024
 
 /*
- * A CQ will be assinged to each WQ
+ * A CQ will be assigned to each WQ
  * (CQ must have 2X entries of the WQ for abort
  * processing), plus a separate one for each RQ PAIR and one for MQ
  */
drivers/scsi/isci/host.c +1 -1
index ff199bab5..1592fc552 100644
@@ -2488,7 +2488,7 @@ struct isci_request *sci_request_by_tag(struct isci_host *ihost, u16 io_tag)
  *    free remote node ids
  * @idev: This is the device object which is requesting the a remote node
  *    id
- * @node_id: This is the remote node id that is assinged to the device if one
+ * @node_id: This is the remote node id that is assigned to the device if one
  *    is available
  *
  * enum sci_status SCI_FAILURE_OUT_OF_RESOURCES if there are no available remote
drivers/scsi/isci/port.c +1 -1
index 10bd2aac2..0dea0abb9 100644
@@ -464,7 +464,7 @@ static enum sci_status sci_port_set_phy(struct isci_port *iport, struct isci_phy
 {
 	/* Check to see if we can add this phy to a port
 	 * that means that the phy is not part of a port and that the port does
-	 * not already have a phy assinged to the phy index.
+	 * not already have a phy assigned to the phy index.
 	 */
 	if (!iport->phy_table[iphy->phy_index] &&
 	    !phy_get_non_dummy_port(iphy) &&
drivers/scsi/isci/port_config.c +1 -1
index 3b4820def..d709c9df8 100644
@@ -259,7 +259,7 @@ sci_mpc_agent_validate_phy_configuration(struct isci_host *ihost,
 		if (!phy_mask)
 			continue;
 		/*
-		 * Make sure that one or more of the phys were not already assinged to
+		 * Make sure that one or more of the phys were not already assigned to
 		 * a different port. */
 		if ((phy_mask & ~assigned_phy_mask) == 0) {
 			return SCI_FAILURE_UNSUPPORTED_PORT_CONFIGURATION;
kernel/bpf/helpers.c +1 -1
index b5314c9fe..6f56ba88f 100644
@@ -3601,7 +3601,7 @@ __bpf_kfunc int bpf_copy_from_user_task_str(void *dst, u32 dst__sz,
 	return ret + 1;
 }
 
-/* Keep unsinged long in prototype so that kfunc is usable when emitted to
+/* Keep unsigned long in prototype so that kfunc is usable when emitted to
  * vmlinux.h in BPF programs directly, but note that while in BPF prog, the
  * unsigned long always points to 8-byte region on stack, the kernel may only
  * read and write the 4-bytes on 32-bit.
scripts/spelling.txt +1 -0
index 2f2e81dbd..3372873cd 100644
@@ -176,6 +176,7 @@ assgined||assigned
 assiged||assigned
 assigment||assignment
 assigments||assignments
+assinged||assigned
 assistent||assistant
 assocaited||associated
 assocated||associated
Signature · 1 line
2.43.0
maintainer Reviewed-by on v1 1/1
#3 lore raw

Re: [PATCH] treewide: fix transposed "sign" typos and update spelling.txt

Quoted 29 lines · On Fri, 12 Jun 2026 23:46:32 +0530 Shardul Deshpande <[email protected]>…

Several comments and one documentation file transpose the letters in "assigned" and "unsigned", spelling them with "sing" instead of "sign". Correct all of them.

Of these, the misspelling of "assigned" is not yet flagged by checkpatch, so also add it to scripts/spelling.txt.

The remaining matches of grep -ri singed are RISINGEDGE register and enum names, not typos.

---
 Documentation/mm/damon/design.rst          | 2 +-
 arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 2 +-
 drivers/gpu/drm/drm_color_mgmt.c           | 2 +-
 drivers/scsi/elx/efct/efct_hw.h            | 2 +-
 drivers/scsi/isci/host.c                   | 2 +-
 drivers/scsi/isci/port.c                   | 2 +-
 drivers/scsi/isci/port_config.c            | 2 +-
 kernel/bpf/helpers.c                       | 2 +-
 scripts/spelling.txt                       | 1 +
 9 files changed, 9 insertions(+), 8 deletions(-)
Documentation/mm/damon/design.rst +0 -0
index afc7d52bd..899ac9c69 100644

Documentation/mm/damon/design.rst as Idle page tracking does. · line 146

Quoted 8 lines
Documentation/mm/damon/design.rst +1 -1
@@ -140,7 +140,7 @@ as Idle page tracking does.
 Address Unit
 ------------
 
-DAMON core layer uses ``unsinged long`` type for monitoring target address
+DAMON core layer uses ``unsigned long`` type for monitoring target address
 ranges.  In some cases, the address space for a given operations set could be
 too large to be handled with the type.  ARM (32-bit) with large physical
 address extension is an example.  For such cases, a per-operations set

For the above DAMON part,

Thanks,
SJ

[...]

#4 lore raw

Re: [PATCH] treewide: fix transposed "sign" typos and update spelling.txt

Quoted 42 lines · SeongJae Park
Quoted 29 lines · On Fri, 12 Jun 2026 23:46:32 +0530 Shardul Deshpande <[email protected]>…

Several comments and one documentation file transpose the letters in "assigned" and "unsigned", spelling them with "sing" instead of "sign". Correct all of them.

Of these, the misspelling of "assigned" is not yet flagged by checkpatch, so also add it to scripts/spelling.txt.

The remaining matches of grep -ri singed are RISINGEDGE register and enum names, not typos.

---
 Documentation/mm/damon/design.rst          | 2 +-
 arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 2 +-
 drivers/gpu/drm/drm_color_mgmt.c           | 2 +-
 drivers/scsi/elx/efct/efct_hw.h            | 2 +-
 drivers/scsi/isci/host.c                   | 2 +-
 drivers/scsi/isci/port.c                   | 2 +-
 drivers/scsi/isci/port_config.c            | 2 +-
 kernel/bpf/helpers.c                       | 2 +-
 scripts/spelling.txt                       | 1 +
 9 files changed, 9 insertions(+), 8 deletions(-)
Documentation/mm/damon/design.rst +0 -0
index afc7d52bd..899ac9c69 100644

Documentation/mm/damon/design.rst as Idle page tracking does. · line 146

Quoted 8 lines
Documentation/mm/damon/design.rst +1 -1
@@ -140,7 +140,7 @@ as Idle page tracking does.
 Address Unit
 ------------
 
-DAMON core layer uses ``unsinged long`` type for monitoring target address
+DAMON core layer uses ``unsigned long`` type for monitoring target address
 ranges.  In some cases, the address space for a given operations set could be
 too large to be handled with the type.  ARM (32-bit) with large physical
 address extension is an example.  For such cases, a per-operations set

For the above DAMON part,

Quoted 1 line

This one has already been fixed in mm-new. See
https://lore.kernel.org/[email protected] .

Thanks,
Zenghui

maintainer
#5 lore raw

Re: [PATCH] treewide: fix transposed "sign" typos and update spelling.txt

Quoted 43 lines · On Sat, 13 Jun 2026 10:32:43 +0800 Zenghui Yu <[email protected]> wrote:
Quoted 42 lines · SeongJae Park
Quoted 29 lines · On Fri, 12 Jun 2026 23:46:32 +0530 Shardul Deshpande <[email protected]>…

Several comments and one documentation file transpose the letters in "assigned" and "unsigned", spelling them with "sing" instead of "sign". Correct all of them.

Of these, the misspelling of "assigned" is not yet flagged by checkpatch, so also add it to scripts/spelling.txt.

The remaining matches of grep -ri singed are RISINGEDGE register and enum names, not typos.

---
 Documentation/mm/damon/design.rst          | 2 +-
 arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 2 +-
 drivers/gpu/drm/drm_color_mgmt.c           | 2 +-
 drivers/scsi/elx/efct/efct_hw.h            | 2 +-
 drivers/scsi/isci/host.c                   | 2 +-
 drivers/scsi/isci/port.c                   | 2 +-
 drivers/scsi/isci/port_config.c            | 2 +-
 kernel/bpf/helpers.c                       | 2 +-
 scripts/spelling.txt                       | 1 +
 9 files changed, 9 insertions(+), 8 deletions(-)
Documentation/mm/damon/design.rst +0 -0
index afc7d52bd..899ac9c69 100644

Documentation/mm/damon/design.rst as Idle page tracking does. · line 146

Quoted 8 lines
Documentation/mm/damon/design.rst +1 -1
@@ -140,7 +140,7 @@ as Idle page tracking does.
 Address Unit
 ------------
 
-DAMON core layer uses ``unsinged long`` type for monitoring target address
+DAMON core layer uses ``unsigned long`` type for monitoring target address
 ranges.  In some cases, the address space for a given operations set could be
 too large to be handled with the type.  ARM (32-bit) with large physical
 address extension is an example.  For such cases, a per-operations set

For the above DAMON part,

Quoted 4 lines
Quoted 1 line

This one has already been fixed in mm-new. See
https://lore.kernel.org/[email protected] .

Ah, you're right. Thank you for catching this! Please drop the DAMON part. That said, now I reviewed all the rest parts of this patch, and all look good. Please feel free to keep having my R-b: tag.

Thanks,
SJ

[...]

maintainer
#6 lore raw
In reply to Shardul Deshpande
Quoted 3 lines · On Fri, 12 Jun 2026 21:10:54 +0530 Shardul Deshpande <[email protected]>…

The "Address Unit" section misspelled the C type that the DAMON core layer uses for monitoring target address ranges. Correct it to read "unsigned long".

Thank you! I found you sent another patch having this change following Andrew's comment. So I reviewed there.

[1] https://lore.kernel.org/[email protected]

Thanks,
SJ

[...]