iio: adc: Initialize completions before requesting IRQs
Subsystems (2)
cover iio: adc: Initialize completions before requesting IRQs
Hi all,
This short patch series fixes the issues raised by Jaeyoung Chung, Sangyun Kim, and Kyungwook Boo regarding init_completion() and spurious IRQs. The report is linked below [1], but I will also put it here inline:
"lpc32xx_adc_probe() in drivers/iio/adc/lpc32xx_adc.c and spear_adc_probe() in drivers/iio/adc/spear_adc.c register their interrupt handler with devm_request_irq() before they initialize st->completion with init_completion(). If an interrupt arrives after devm_request_irq() and before init_completion(), the handler calls complete() on an uninitialized completion, causing a kernel panic.
The probe path, in lpc32xx_adc_probe():
iodev = devm_iio_device_alloc(&pdev->dev, sizeof(*st)); /* st kzalloc-zeroed */
...
retval = devm_request_irq(&pdev->dev, irq, lpc32xx_adc_isr, 0,
LPC32XXAD_NAME, st); /* register handler */
...
init_completion(&st->completion); /* initialize completion */spear_adc_probe() has the same ordering: devm_request_irq() for spear_adc_isr() before init_completion(&st->completion).
Both interrupt handlers, lpc32xx_adc_isr() and spear_adc_isr(), call complete():
complete(&st->completion);
If the device raises an interrupt before init_completion() runs, complete() acquires the uninitialized wait.lock and walks the zeroed task_list in swake_up_locked(). The zeroed task_list makes list_empty() return false, so swake_up_locked() dereferences a NULL list entry, triggering a KASAN wild-memory-access.
Suggested fix: move init_completion(&st->completion) above devm_request_irq(), so the completion is valid before the handler can run.
+ Reported-by: Jaeyoung Chung <[email protected]>
Quick note, I ended up editing the report a little in the individual commits to match the driver we were fixing.
[1] Link: https://lore.kernel.org/linux-iio/[email protected]/
Maxwell Doose (2):
iio: adc: lpc32xx: Initialize completion before requesting IRQ
iio: adc: spear: Initialize completion before requesting IRQ
drivers/iio/adc/lpc32xx_adc.c | 4 ++-- drivers/iio/adc/spear_adc.c | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-)
Signature · 1 line
2.54.0
PATCH 1/2 iio: adc: lpc32xx: Initialize completion before requesting IRQ
In the report from Jaeyoung Chung:
"lpc32xx_adc_probe() in drivers/iio/adc/lpc32xx_adc.c registers its interrupt handler with devm_request_irq() before it initializes st->completion with init_completion(). If an interrupt arrives after devm_request_irq() and before init_completion(), the handler calls complete() on an uninitialized completion, causing a kernel panic.
The probe path, in lpc32xx_adc_probe():
iodev = devm_iio_device_alloc(&pdev->dev, sizeof(*st)); /* st kzalloc-zeroed */
...
retval = devm_request_irq(&pdev->dev, irq, lpc32xx_adc_isr, 0,
LPC32XXAD_NAME, st); /* register handler */
...
init_completion(&st->completion); /* initialize completion */lpc32xx_adc_isr() calls complete():
complete(&st->completion);
If the device raises an interrupt before init_completion() runs, complete() acquires the uninitialized wait.lock and walks the zeroed task_list in swake_up_locked(). The zeroed task_list makes list_empty() return false, so swake_up_locked() dereferences a NULL list entry, triggering a KASAN wild-memory-access."
Fix the chance of a spurious IRQ causing an uninitialized pointer dereference by moving init_completion() above devm_request_irq().
--- drivers/iio/adc/lpc32xx_adc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/adc/lpc32xx_adc.c +2 -2
@@ -179,6 +179,8 @@ static int lpc32xx_adc_probe(struct platform_device *pdev)if (irq <0 )return irq; +init_completion (&st->completion); + retval =devm_request_irq (&pdev->dev, irq, lpc32xx_adc_isr,0 ,LPC32XXAD_NAME , st);if (retval <0 ) {
@@ -197,8 +199,6 @@ static int lpc32xx_adc_probe(struct platform_device *pdev)platform_set_drvdata (pdev, iodev); -init_completion (&st->completion); - iodev->name =LPC32XXAD_NAME ; iodev->info = &lpc32xx_adc_iio_info; iodev->modes =INDIO_DIRECT_MODE ;
Signature · 1 line
2.54.0
Re: [PATCH 1/2] iio: adc: lpc32xx: Initialize completion before requesting IRQ
Quoted 54 lines · Maxwell Doose
In the report from Jaeyoung Chung:
"
lpc32xx_adc_probe()indrivers/iio/adc/lpc32xx_adc.cregisters its interrupt handler withdevm_request_irq()before it initializesst->completionwithinit_completion(). If an interrupt arrives afterdevm_request_irq()and beforeinit_completion(), the handler callscomplete()on an uninitialized completion, causing a kernel panic.The probe path, in
lpc32xx_adc_probe():iodev = devm_iio_device_alloc(&pdev->dev, sizeof(*st)); /* st kzalloc-zeroed */ ... retval = devm_request_irq(&pdev->dev, irq, lpc32xx_adc_isr, 0, LPC32XXAD_NAME, st); /* register handler */ ... init_completion(&st->completion); /* initialize completion */
lpc32xx_adc_isr()callscomplete():complete(&st->completion);If the device raises an interrupt before
init_completion()runs,complete()acquires the uninitialized wait.lock and walks the zeroedtask_listinswake_up_locked(). The zeroedtask_listmakeslist_empty()return false, soswake_up_locked()dereferences a NULL list entry, triggering a KASAN wild-memory-access."Fix the chance of a spurious IRQ causing an uninitialized pointer dereference by moving
init_completion()abovedevm_request_irq().Fixes 7901b2a1453e ("staging:iio:adc:lpc32xx rename local state structure to _state")Reported-by Sangyun Kim <[email protected]>Reported-by Kyungwook Boo <[email protected]>Reported-by Jaeyoung Chung <[email protected]>Signed-off-by Maxwell Doose <[email protected]>--- drivers/iio/adc/lpc32xx_adc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/iio/adc/lpc32xx_adc.c +2
-0@@ -179,6 +179,8 @@ static int lpc32xx_adc_probe(struct platform_device *pdev)if (irq <0 )return irq; +init_completion (&st->completion); + retval =devm_request_irq (&pdev->dev, irq, lpc32xx_adc_isr,0 ,LPC32XXAD_NAME , st);if (retval <0 ) {
drivers/iio/adc/lpc32xx_adc.c static int lpc32xx_adc_probe(struct platform_device *pdev) · line 204
Quoted 8 lines
drivers/iio/adc/lpc32xx_adc.c +0
-2@@ -197,8 +199,6 @@ static int lpc32xx_adc_probe(struct platform_device *pdev)platform_set_drvdata (pdev, iodev); -init_completion (&st->completion); - iodev->name =LPC32XXAD_NAME ; iodev->info = &lpc32xx_adc_iio_info; iodev->modes =INDIO_DIRECT_MODE ;
Signature · 2 lines
Best wishes, Vladimir
PATCH 2/2 iio: adc: spear: Initialize completion before requesting IRQ
In reply to Maxwell DooseIn the report from Jaeyoung Chung:
"spear_adc_probe() in drivers/iio/adc/spear_adc.c registers its interrupt handler with devm_request_irq() before it initializes st->completion with init_completion(). If an interrupt arrives after devm_request_irq() and before init_completion(), the handler calls complete() on an uninitialized completion, causing a kernel panic.
The probe path, in spear_adc_probe():
iodev = devm_iio_device_alloc(&pdev->dev, sizeof(*st)); /* st kzalloc-zeroed */
...
retval = devm_request_irq(&pdev->dev, irq, spear_adc_isr, 0,
LPC32XXAD_NAME, st); /* register handler */
...
init_completion(&st->completion); /* initialize completion */spear_adc_isr() calls complete():
complete(&st->completion);
If the device raises an interrupt before init_completion() runs, complete() acquires the uninitialized wait.lock and walks the zeroed task_list in swake_up_locked(). The zeroed task_list makes list_empty() return false, so swake_up_locked() dereferences a NULL list entry, triggering a KASAN wild-memory-access."
Fix the chance of a spurious IRQ causing an uninitialized pointer dereference by moving init_completion() above devm_request_irq().
--- drivers/iio/adc/spear_adc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/iio/adc/spear_adc.c +1 -2
@@ -283,6 +283,7 @@ static int spear_adc_probe(struct platform_device *pdev) st =iio_priv (indio_dev); st->dev = dev; +init_completion (&st->completion);mutex_init (&st->lock);/*
@@ -329,8 +330,6 @@ static int spear_adc_probe(struct platform_device *pdev)spear_adc_configure (st); -init_completion (&st->completion); - indio_dev->name =SPEAR_ADC_MOD_NAME ; indio_dev->info = &spear_adc_info; indio_dev->modes =INDIO_DIRECT_MODE ;
Signature · 1 line
2.54.0
Re: [PATCH 2/2] iio: adc: spear: Initialize completion before requesting IRQ
Quoted 53 lines · Maxwell Doose
In the report from Jaeyoung Chung:
"
spear_adc_probe()indrivers/iio/adc/spear_adc.cregisters its interrupt handler withdevm_request_irq()before it initializesst->completionwithinit_completion(). If an interrupt arrives afterdevm_request_irq()and beforeinit_completion(), the handler callscomplete()on an uninitialized completion, causing a kernel panic.The probe path, in
spear_adc_probe():iodev = devm_iio_device_alloc(&pdev->dev, sizeof(*st)); /* st kzalloc-zeroed */ ... retval = devm_request_irq(&pdev->dev, irq, spear_adc_isr, 0, LPC32XXAD_NAME, st); /* register handler */ ... init_completion(&st->completion); /* initialize completion */
spear_adc_isr()callscomplete():complete(&st->completion);If the device raises an interrupt before
init_completion()runs,complete()acquires the uninitialized wait.lock and walks the zeroedtask_listinswake_up_locked(). The zeroedtask_listmakeslist_empty()return false, soswake_up_locked()dereferences a NULL list entry, triggering a KASAN wild-memory-access."Fix the chance of a spurious IRQ causing an uninitialized pointer dereference by moving
init_completion()abovedevm_request_irq().Fixes b586e5d9eee0 ("staging:iio:adc:spear rename device specific state structure to _state")Reported-by Sangyun Kim <[email protected]>Reported-by Kyungwook Boo <[email protected]>Reported-by Jaeyoung Chung <[email protected]>Signed-off-by Maxwell Doose <[email protected]>--- drivers/iio/adc/spear_adc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/iio/adc/spear_adc.c +1
-0@@ -283,6 +283,7 @@ static int spear_adc_probe(struct platform_device *pdev) st =iio_priv (indio_dev); st->dev = dev; +init_completion (&st->completion);mutex_init (&st->lock);/*
drivers/iio/adc/spear_adc.c static int spear_adc_probe(struct platform_device *pdev) · line 335
Quoted 8 lines
drivers/iio/adc/spear_adc.c +0
-2@@ -329,8 +330,6 @@ static int spear_adc_probe(struct platform_device *pdev)spear_adc_configure (st); -init_completion (&st->completion); - indio_dev->name =SPEAR_ADC_MOD_NAME ; indio_dev->info = &spear_adc_info; indio_dev->modes =INDIO_DIRECT_MODE ;
Signature · 2 lines
Best wishes, Vladimir
Quoted 43 lines · On Fri, 12 Jun 2026 19:58:09 -0500 Maxwell Doose <[email protected]> wrote:
Hi all,
This short patch series fixes the issues raised by Jaeyoung Chung, Sangyun Kim, and Kyungwook Boo regarding
init_completion()and spurious IRQs. The report is linked below [1], but I will also put it here inline:"
lpc32xx_adc_probe()indrivers/iio/adc/lpc32xx_adc.candspear_adc_probe()indrivers/iio/adc/spear_adc.cregister their interrupt handler withdevm_request_irq()before they initializest->completionwithinit_completion(). If an interrupt arrives afterdevm_request_irq()and beforeinit_completion(), the handler callscomplete()on an uninitialized completion, causing a kernel panic.The probe path, in
lpc32xx_adc_probe():iodev = devm_iio_device_alloc(&pdev->dev, sizeof(*st)); /* st kzalloc-zeroed */ ... retval = devm_request_irq(&pdev->dev, irq, lpc32xx_adc_isr, 0, LPC32XXAD_NAME, st); /* register handler */ ... init_completion(&st->completion); /* initialize completion */
spear_adc_probe()has the same ordering:devm_request_irq()forspear_adc_isr()beforeinit_completion(&st->completion).Both interrupt handlers,
lpc32xx_adc_isr()andspear_adc_isr(), callcomplete():complete(&st->completion);If the device raises an interrupt before
init_completion()runs,complete()acquires the uninitialized wait.lock and walks the zeroedtask_listinswake_up_locked(). The zeroedtask_listmakeslist_empty()return false, soswake_up_locked()dereferences a NULL list entry, triggering a KASAN wild-memory-access.Suggested fix: move
init_completion(&st->completion)abovedevm_request_irq(), so the completion is valid before the handler can run.Reported-by Sangyun Kim <[email protected]>Reported-by Kyungwook Boo <[email protected]>"
Quoted 6 lines
+ Reported-by: Jaeyoung Chung <[email protected]>
Quick note, I ended up editing the report a little in the individual commits to match the driver we were fixing.
[1] Link: https://lore.kernel.org/linux-iio/[email protected]/
Applied to the fixes-togreg branch of iio.git and marked for stable. Note that I'll be rebasing on rc1 once available.
Thanks
Jonathan
Quoted 9 lines
Maxwell Doose (2):
iio: adc: lpc32xx: Initialize completion before requesting IRQ
iio: adc: spear: Initialize completion before requesting IRQdrivers/iio/adc/lpc32xx_adc.c | 4 ++-- drivers/iio/adc/spear_adc.c | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-)
Quoted 37 lines · Maxwell Doose
Hi all,
This short patch series fixes the issues raised by Jaeyoung Chung, Sangyun Kim, and Kyungwook Boo regarding
init_completion()and spurious IRQs. The report is linked below [1], but I will also put it here inline:"
lpc32xx_adc_probe()indrivers/iio/adc/lpc32xx_adc.candspear_adc_probe()indrivers/iio/adc/spear_adc.cregister their interrupt handler withdevm_request_irq()before they initializest->completionwithinit_completion(). If an interrupt arrives afterdevm_request_irq()and beforeinit_completion(), the handler callscomplete()on an uninitialized completion, causing a kernel panic.The probe path, in
lpc32xx_adc_probe():iodev = devm_iio_device_alloc(&pdev->dev, sizeof(*st)); /* st kzalloc-zeroed */ ... retval = devm_request_irq(&pdev->dev, irq, lpc32xx_adc_isr, 0, LPC32XXAD_NAME, st); /* register handler */ ... init_completion(&st->completion); /* initialize completion */
spear_adc_probe()has the same ordering:devm_request_irq()forspear_adc_isr()beforeinit_completion(&st->completion).Both interrupt handlers,
lpc32xx_adc_isr()andspear_adc_isr(), callcomplete():complete(&st->completion);If the device raises an interrupt before
init_completion()runs,complete()acquires the uninitialized wait.lock and walks the zeroedtask_listinswake_up_locked(). The zeroedtask_listmakeslist_empty()return false, soswake_up_locked()dereferences a NULL list entry, triggering a KASAN wild-memory-access.
Quoted 5 lines
Suggested fix: move
init_completion(&st->completion)abovedevm_request_irq(), so the completion is valid before the handler can run.Reported-by Sangyun Kim <[email protected]>Reported-by Kyungwook Boo <[email protected]>"
Signature · 2 lines
With Best Regards, Andy Shevchenko