Skip to contentSkip to conversation

accel/hvf: Reduce hvf_kernel_irqchip_override scope

PATCH In review Philippe Mathieu-Daudé 2 participants 2 messages Jun 13

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 accel/hvf: Reduce hvf_kernel_irqchip_override scope

hvf_kernel_irqchip_override is only used within the accel/hvf/hvf-all.c file, no need to expose the symbol.

---
 include/system/hvf_int.h | 1 -
 accel/hvf/hvf-all.c      | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)
include/system/hvf_int.h +0 -1
index d5eaf26dda8..58fb865ebae 100644
@@ -113,5 +113,4 @@ bool hvf_arch_cpu_realize(CPUState *cpu, Error **errp);
 uint32_t hvf_arch_get_default_ipa_bit_size(void);
 uint32_t hvf_arch_get_max_ipa_bit_size(void);
 
-extern bool hvf_kernel_irqchip_override;
 #endif
accel/hvf/hvf-all.c +1 -1
index 946dbca59d0..21b9b71a6df 100644
@@ -25,7 +25,7 @@
 bool hvf_allowed;
 bool hvf_kernel_irqchip;
 bool hvf_nested_virt;
-bool hvf_kernel_irqchip_override;
+static bool hvf_kernel_irqchip_override;
 
 void hvf_nested_virt_enable(bool nested_virt)
 {
Signature · 1 line
2.53.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Philippe Mathieu-Daudé

hvf_kernel_irqchip_override is only used within the accel/hvf/hvf-all.c file, no need to expose the symbol.

Quoted 32 lines

---
include/system/hvf_int.h | 1 -
accel/hvf/hvf-all.c | 2 +-

2 files changed, 1 insertion(+), 2 deletions(-)
include/system/hvf_int.h +0 -1
index d5eaf26dda8..58fb865ebae 100644
@@ -113,5 +113,4 @@ bool hvf_arch_cpu_realize(CPUState *cpu, Error **errp);
 uint32_t hvf_arch_get_default_ipa_bit_size(void);
 uint32_t hvf_arch_get_max_ipa_bit_size(void);
 
-extern bool hvf_kernel_irqchip_override;
 #endif
accel/hvf/hvf-all.c +1 -1
index 946dbca59d0..21b9b71a6df 100644
@@ -25,7 +25,7 @@
 bool hvf_allowed;
 bool hvf_kernel_irqchip;
 bool hvf_nested_virt;
-bool hvf_kernel_irqchip_override;
+static bool hvf_kernel_irqchip_override;
 
 void hvf_nested_virt_enable(bool nested_virt)
 {
Signature · 1 line
2.53.0