Skip to contentSkip to conversation

genirq/msi: correct CONFIG_PCI_MSI_ARCH_FALLBACKS macro name in comment

PATCH Applied Ethan Nelson-Moore 3 participants 4 messages Jun 13 – Jun 26

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 genirq/msi: correct CONFIG_PCI_MSI_ARCH_FALLBACKS macro name in comment

A comment in kernel/irq/msi.c incorrectly refers to CONFIG_PCI_MSI_ARCH_FALLBACK instead of CONFIG_PCI_MSI_ARCH_FALLBACKS. Correct it.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

---
 kernel/irq/msi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/irq/msi.c +1 -1
index 3cafa40e6ce3..903be7289c53 100644
@@ -591,7 +591,7 @@ void msi_device_destroy_sysfs(struct device *dev)
 	msi_for_each_desc(desc, dev, MSI_DESC_ALL)
 		msi_sysfs_remove_desc(dev, desc);
 }
-#endif /* CONFIG_PCI_MSI_ARCH_FALLBACK || CONFIG_PCI_XEN */
+#endif /* CONFIG_PCI_MSI_ARCH_FALLBACKS || CONFIG_PCI_XEN */
 #else /* CONFIG_SYSFS */
 static inline int msi_sysfs_create_group(struct device *dev) { return 0; }
 static inline int msi_sysfs_populate_desc(struct device *dev, struct msi_desc *desc) { return 0; }
Signature · 1 line
2.43.0
#1 lore raw
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 8 lines

A comment in kernel/irq/msi.c incorrectly refers to CONFIG_PCI_MSI_ARCH_FALLBACK instead of CONFIG_PCI_MSI_ARCH_FALLBACKS. Correct it.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

Sashiko has reviewed this patch and found no issues. It looks great!

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
#2 lore raw

[tip: irq/urgent] genirq/msi: Correct CONFIG_PCI_MSI_ARCH_FALLBACKS macro name in comment

In reply to Ethan Nelson-Moore
The following commit has been merged into the irq/urgent branch of tip:

The following commit has been merged into the irq/urgent branch of tip:

Commit-ID:     865730eec5435ce40a5dc3c615077d04c8f95098
Gitweb:        https://git.kernel.org/tip/865730eec5435ce40a5dc3c615077d04c8f95098
Author:        Ethan Nelson-Moore <[email protected]>
AuthorDate:    Sat, 13 Jun 2026 14:35:43 -07:00
Committer:     Thomas Gleixner <[email protected]>
CommitterDate: Mon, 22 Jun 2026 22:32:01 +02:00

genirq/msi: Correct CONFIG_PCI_MSI_ARCH_FALLBACKS macro name in comment

A comment in kernel/irq/msi.c incorrectly refers to CONFIG_PCI_MSI_ARCH_FALLBACK instead of CONFIG_PCI_MSI_ARCH_FALLBACKS. Correct it.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

---
 kernel/irq/msi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/irq/msi.c +1 -1
index 3cafa40..903be72 100644
@@ -591,7 +591,7 @@ void msi_device_destroy_sysfs(struct device *dev)
 	msi_for_each_desc(desc, dev, MSI_DESC_ALL)
 		msi_sysfs_remove_desc(dev, desc);
 }
-#endif /* CONFIG_PCI_MSI_ARCH_FALLBACK || CONFIG_PCI_XEN */
+#endif /* CONFIG_PCI_MSI_ARCH_FALLBACKS || CONFIG_PCI_XEN */
 #else /* CONFIG_SYSFS */
 static inline int msi_sysfs_create_group(struct device *dev) { return 0; }
 static inline int msi_sysfs_populate_desc(struct device *dev, struct msi_desc *desc) { return 0; }
#3 lore raw

[tip: irq/msi] genirq/msi: Correct CONFIG_PCI_MSI_ARCH_FALLBACKS macro name in comment

In reply to Ethan Nelson-Moore
The following commit has been merged into the irq/msi branch of tip:

The following commit has been merged into the irq/msi branch of tip:

Commit-ID:     93630ceb882635dcddacc3856d34547c572b2970
Gitweb:        https://git.kernel.org/tip/93630ceb882635dcddacc3856d34547c572b2970
Author:        Ethan Nelson-Moore <[email protected]>
AuthorDate:    Sat, 13 Jun 2026 14:35:43 -07:00
Committer:     Thomas Gleixner <[email protected]>
CommitterDate: Fri, 26 Jun 2026 15:32:20 +02:00

genirq/msi: Correct CONFIG_PCI_MSI_ARCH_FALLBACKS macro name in comment

A comment in kernel/irq/msi.c incorrectly refers to CONFIG_PCI_MSI_ARCH_FALLBACK instead of CONFIG_PCI_MSI_ARCH_FALLBACKS. Correct it.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

---
 kernel/irq/msi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/irq/msi.c +1 -1
index 3cafa40..903be72 100644
@@ -591,7 +591,7 @@ void msi_device_destroy_sysfs(struct device *dev)
 	msi_for_each_desc(desc, dev, MSI_DESC_ALL)
 		msi_sysfs_remove_desc(dev, desc);
 }
-#endif /* CONFIG_PCI_MSI_ARCH_FALLBACK || CONFIG_PCI_XEN */
+#endif /* CONFIG_PCI_MSI_ARCH_FALLBACKS || CONFIG_PCI_XEN */
 #else /* CONFIG_SYSFS */
 static inline int msi_sysfs_create_group(struct device *dev) { return 0; }
 static inline int msi_sysfs_populate_desc(struct device *dev, struct msi_desc *desc) { return 0; }