Skip to contentSkip to conversation

Input: synaptics-rmi4 - correct CONFIG_RMI4_F34 macro name in comment

PATCH New Ethan Nelson-Moore 2 participants 2 messages Jun 13

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Input: synaptics-rmi4 - correct CONFIG_RMI4_F34 macro name in comment

A comment in the synaptics-rmi4 driver incorrectly refers to CONFIG_RMI4_F34 instead of CONFIG_RMI4_F34. Correct it.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

---
 drivers/input/rmi4/rmi_driver.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/rmi4/rmi_driver.h +1 -1
index e84495caab15..7d0ae80dc8ea 100644
@@ -127,7 +127,7 @@ static inline int rmi_f34_create_sysfs(struct rmi_device *rmi_dev)
 static inline void rmi_f34_remove_sysfs(struct rmi_device *rmi_dev)
 {
 }
-#endif /* CONFIG_RMI_F34 */
+#endif /* CONFIG_RMI4_F34 */
 
 extern struct rmi_function_handler rmi_f01_handler;
 extern struct rmi_function_handler rmi_f03_handler;
Signature · 1 line
2.43.0
#1 lore raw
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The commit message contains a typo and repeats the same macro name twice when describing the…

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message contains a typo and repeats the same macro name twice when describing the change. It states that the comment 'incorrectly refers to CONFIG_RMI4_F34 instead of CONFIG_RMI4_F34', whereas the actual code diff shows the old macro name was 'CONFIG_RMI_F34'. --

commit 0b9599ce581aac6de8ca3435e1928df9a8121100
Author: Ethan Nelson-Moore <[email protected]>

Input: synaptics-rmi4 - correct CONFIG_RMI4_F34 macro name in comment

This commit fixes a typo in a preprocessor endif comment in the synaptics-rmi4 driver, changing CONFIG_RMI_F34 to CONFIG_RMI4_F34.

Quoted 2 lines

A comment in the synaptics-rmi4 driver incorrectly refers to CONFIG_RMI4_F34 instead of CONFIG_RMI4_F34. Correct it.

[Severity: Low]
This isn't a bug, but there is a typo in the commit message description. It states the comment refers to CONFIG_RMI4_F34 instead of CONFIG_RMI4_F34, repeating the same macro name twice. The actual code diff shows the old macro name was CONFIG_RMI_F34.

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1